2ab7d9bfe3
gh v2.99 gained a native --attach flag for issues, PRs and comments, so the custom trusted-publisher chain (gh-image extension + GH_IMAGE_SESSION_TOKEN workflow_run job + attachment-upload script) is superseded. Remove: - .github/workflows/publish-e2e-evidence.yml (workflow_run publisher) - scripts/ci/publish_e2e_evidence.py + its tests - e2e-evidence-* artifact upload + evidence staging in e2e-desktop.yml / e2e_screenshot_status.py, incl. the 'inline evidence is publishing...' marker placeholder in the CI review comment status Keep: the review-comment screenshot/diff counts and artifact links produced by e2e_screenshot_status.py.
54 lines
1.9 KiB
Python
54 lines
1.9 KiB
Python
"""Tests for scripts/ci/e2e_screenshot_status.py."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib.util
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
_PATH = Path(__file__).resolve().parents[2] / "scripts" / "ci" / "e2e_screenshot_status.py"
|
|
_spec = importlib.util.spec_from_file_location("e2e_screenshot_status", _PATH)
|
|
if _spec is None or _spec.loader is None:
|
|
raise ImportError("Failed to load e2e_screenshot_status.py")
|
|
_mod = importlib.util.module_from_spec(_spec)
|
|
_spec.loader.exec_module(_mod)
|
|
|
|
|
|
def test_status_selects_only_new_explicit_screenshots_and_all_diffs(tmp_path):
|
|
for name in (
|
|
"explicit-proof.png",
|
|
"test-finished-1.png",
|
|
"visual-actual.png",
|
|
"visual-expected.png",
|
|
"visual-diff.png",
|
|
):
|
|
(tmp_path / name).write_bytes(b"png")
|
|
|
|
base_manifest = tmp_path / "main-manifest.json"
|
|
base_manifest.write_text('{"screenshot_names":["already-on-main.png"]}', encoding="utf-8")
|
|
(tmp_path / "already-on-main.png").write_bytes(b"png")
|
|
|
|
selection = _mod.select_evidence(tmp_path, base_manifest)
|
|
status = _mod.build_status(selection, "https://github.test/artifacts/1")
|
|
|
|
result = status[0]["results"][0]
|
|
assert result["kind"] == "info"
|
|
assert result["summary"] == "1 new screenshot vs main; 1 visual diff."
|
|
assert "detail" not in result
|
|
assert result["link"] == "https://github.test/artifacts/1"
|
|
|
|
|
|
def test_cli_output_ends_with_newline_for_github_output_delimiter(tmp_path, monkeypatch):
|
|
output = tmp_path / "review-status.json"
|
|
manifest = tmp_path / "main-manifest.json"
|
|
monkeypatch.setattr(sys, "argv", [
|
|
"e2e_screenshot_status.py",
|
|
"--results-dir", str(tmp_path),
|
|
"--manifest-output", str(manifest),
|
|
"--output", str(output),
|
|
])
|
|
|
|
assert _mod.main() == 0
|
|
assert output.read_text(encoding="utf-8") == "[]\n"
|
|
assert manifest.read_text(encoding="utf-8") == '{"screenshot_names": [], "version": 1}\n'
|