9fa23760bc
The desktop package.json carries a 0.0.0 placeholder on main (real versions come from channel builds and the live backend), but two About paths repeated it verbatim: appVersionInfo fell back to packageVersion when no display version was baked, and the native panel was seeded - and could be refreshed - with an empty applicationVersion, which macOS renders as the bundle's 0.0.0. Skip placeholder values ('', 0.0.0, unknown) across every candidate, and map the native panel string through nativeAboutVersion so unknown becomes an explicit label (backend spelling git.<short>[.dirty]) instead of 0.0.0. The renderer keeps its ''-means-unavailable contract. Closes #124581.
126 lines
4.1 KiB
TypeScript
126 lines
4.1 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
|
|
import { appVersionInfo, assertSourceUpdateChannel, nativeAboutVersion } from './app-version'
|
|
import type { InstallStamp } from './install-stamp'
|
|
|
|
describe('artifact version identity', (): void => {
|
|
it.each([
|
|
['v1.2.3', 'stable'],
|
|
['v1.2.4+canary.20260911T010101Z', 'canary'],
|
|
[null, null]
|
|
] as const)(
|
|
'reports the client version and fixed channel for %s, not a remote runtime',
|
|
(tag: string | null, channel: 'stable' | 'canary' | null): void => {
|
|
const stamp: InstallStamp = {
|
|
payload: 'bundled',
|
|
tag,
|
|
displayVersion: '1.2.3+gabcdef12',
|
|
source: tag ? 'ci' : 'commit-build',
|
|
updateMechanism: 'external'
|
|
} as InstallStamp
|
|
|
|
expect(appVersionInfo(stamp, '9.9.9-remote', '1.2.3')).toMatchObject({
|
|
appVersion: stamp.displayVersion,
|
|
channel,
|
|
source: stamp.source
|
|
})
|
|
expect((): void => assertSourceUpdateChannel(stamp)).toThrow()
|
|
}
|
|
)
|
|
|
|
it('reports baked channel source version independently of native sequence version', (): void => {
|
|
const stamp: InstallStamp = {
|
|
schemaVersion: 1,
|
|
source: 'channel-build',
|
|
payload: 'bundled',
|
|
distribution: 'desktop-app',
|
|
updateMechanism: 'electron-updater',
|
|
tag: null,
|
|
commit: 'a'.repeat(40),
|
|
commitDate: null,
|
|
branch: null,
|
|
builtAt: null,
|
|
dirty: false,
|
|
baseVersion: '1.2.3',
|
|
displayVersion: '0.0.7',
|
|
distance: null,
|
|
channelBuild: {
|
|
schema: 1,
|
|
buildId: 'b'.repeat(32),
|
|
channel: 'new-name',
|
|
sequence: 7,
|
|
repository: 'example/hermes-agent',
|
|
commit: 'a'.repeat(40),
|
|
sourceVersion: '1.2.3',
|
|
version: '0.0.7',
|
|
windowsVersion: '0.0.7.0',
|
|
publicBase: 'https://example.com',
|
|
bundleEnv: {},
|
|
identity: {
|
|
token: '1234567890abcdef',
|
|
displayName: 'Preview',
|
|
appId: 'chat.preview',
|
|
appNamePascal: 'Preview',
|
|
artifactNamePascal: 'Preview',
|
|
cliName: 'preview',
|
|
windowsExecutableName: 'Preview.exe',
|
|
msixAppIdWithOrg: 'Nous.Preview'
|
|
}
|
|
}
|
|
}
|
|
|
|
expect(appVersionInfo(stamp, '9.9.9-remote', '0.0.7')).toMatchObject({
|
|
channel: 'new-name',
|
|
baseVersion: '1.2.3',
|
|
appVersion: '1.2.3 (new-name #7, aaaaaaaa)',
|
|
sequence: 7,
|
|
buildId: 'b'.repeat(32)
|
|
})
|
|
})
|
|
|
|
it('keeps source installs on their runtime version without a fixed package channel', (): void => {
|
|
expect(appVersionInfo(null, '9.9.9-runtime', '1.2.3')).toMatchObject({ appVersion: '9.9.9-runtime' })
|
|
expect((): void => assertSourceUpdateChannel(null)).not.toThrow()
|
|
})
|
|
|
|
// #124581: the desktop package.json carries a 0.0.0 placeholder, so the
|
|
// About panel must never repeat it as the running version.
|
|
it('skips the 0.0.0 package placeholder for builds without a baked display version', (): void => {
|
|
const stamp: InstallStamp = {
|
|
payload: 'bundled',
|
|
tag: null,
|
|
displayVersion: null,
|
|
baseVersion: '1.2.3',
|
|
source: 'local',
|
|
updateMechanism: 'external'
|
|
} as InstallStamp
|
|
|
|
expect(appVersionInfo(stamp, '', '0.0.0').appVersion).toBe('1.2.3')
|
|
})
|
|
|
|
it('keeps an offline source install unknown instead of reporting 0.0.0', (): void => {
|
|
const stamp: InstallStamp = {
|
|
payload: 'bootstrap',
|
|
tag: null,
|
|
displayVersion: null,
|
|
baseVersion: null,
|
|
commit: 'a'.repeat(40),
|
|
branch: 'main',
|
|
dirty: false,
|
|
source: 'local',
|
|
updateMechanism: 'self'
|
|
} as InstallStamp
|
|
|
|
const info = appVersionInfo(stamp, '', '0.0.0')
|
|
expect(info.appVersion).not.toBe('0.0.0')
|
|
// The native panel cannot render empty; it gets a truthful label.
|
|
expect(nativeAboutVersion(info)).toBe(`git.${'a'.repeat(7)}`)
|
|
})
|
|
|
|
it('maps an unresolvable native About version to unknown, never empty', (): void => {
|
|
expect(nativeAboutVersion({ appVersion: '9.9.9' })).toBe('9.9.9')
|
|
expect(nativeAboutVersion({ appVersion: '0.0.0', baseVersion: '1.2.3' })).toBe('1.2.3')
|
|
expect(nativeAboutVersion({ appVersion: '' })).toBe('unknown')
|
|
})
|
|
})
|