d4e0df1e8d
_to_async_client rebuilds default_headers from scratch and dropped the blank Authorization set by _create_openai_client, so every async aux call (the path aux tasks actually take) for a free-tier OpenCode model still shipped the keyless placeholder as a bearer and 401'd. Re-apply the same keyless policy on the async twin. Review finding: fourth client builder (_to_async_client) missed the keyless header policy.
128 lines
4.8 KiB
Python
128 lines
4.8 KiB
Python
"""Regression guard: opencode-free client keyless header handling.
|
|
|
|
OpenCode's free tier at ``https://opencode.ai/zen/v1`` is served ANONYMOUSLY:
|
|
requests with no recognizable Authorization bearer succeed, while any bearer
|
|
the relay doesn't recognize — placeholders included — is rejected with 401
|
|
"Invalid API key" (verified live 2026-08-21).
|
|
|
|
The client therefore must ship an EMPTY ``Authorization`` default header for
|
|
every opencode-free build, which overrides the OpenAI SDK's always-injected
|
|
``Authorization: Bearer <api_key>`` so no credential-shaped value ever
|
|
reaches the wire.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from agent.agent_runtime_helpers import create_openai_client
|
|
|
|
ZEN_V1 = "https://opencode.ai/zen/v1"
|
|
|
|
|
|
class _FakeAgent:
|
|
def __init__(self, api_key):
|
|
self.provider = "opencode-free"
|
|
self.base_url = ZEN_V1
|
|
self.api_key = api_key
|
|
self.model = "x-preview-f-free"
|
|
self.api_mode = "chat_completions"
|
|
|
|
def _client_log_context(self):
|
|
return {}
|
|
|
|
def _build_keepalive_http_client(self, base_url, verify=True):
|
|
return None
|
|
|
|
|
|
def _zen_call_headers(mock_openai):
|
|
matching = [
|
|
c for c in mock_openai.call_args_list
|
|
if c.kwargs.get("base_url") == ZEN_V1
|
|
]
|
|
assert matching, "OpenAI was never constructed with the zen base_url"
|
|
return dict(matching[-1].kwargs.get("default_headers") or {})
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_opencode_free_blanks_authorization_header(mock_openai):
|
|
"""Whatever api_key value reaches the client build (placeholder, stale
|
|
key, empty), the Authorization default header must be blanked so the
|
|
SDK's Bearer never hits the wire."""
|
|
mock_openai.return_value = MagicMock()
|
|
for key in ("opencode-zen-free-keyless", "no-key-required", "", "sk-stale"):
|
|
mock_openai.reset_mock()
|
|
create_openai_client(
|
|
_FakeAgent(api_key=key),
|
|
{"api_key": key, "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
headers = _zen_call_headers(mock_openai)
|
|
assert headers.get("Authorization") == "", (
|
|
f"opencode-free with api_key={key!r} must blank Authorization; "
|
|
f"got {headers!r}"
|
|
)
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_opencode_free_sends_hermes_attribution(mock_openai):
|
|
"""Keyless requests still identify as Hermes (attribution headers match
|
|
the opencode zen/go profiles)."""
|
|
mock_openai.return_value = MagicMock()
|
|
create_openai_client(
|
|
_FakeAgent(api_key="opencode-zen-free-keyless"),
|
|
{"api_key": "opencode-zen-free-keyless", "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
headers = _zen_call_headers(mock_openai)
|
|
assert headers.get("X-Title") == "Hermes Agent"
|
|
assert str(headers.get("User-Agent", "")).startswith("HermesAgent/")
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_other_providers_unaffected(mock_openai):
|
|
"""The opencode-free header policy must not leak to other providers."""
|
|
mock_openai.return_value = MagicMock()
|
|
agent = _FakeAgent(api_key="sk-real")
|
|
agent.provider = "opencode-zen"
|
|
create_openai_client(
|
|
agent,
|
|
{"api_key": "sk-real", "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
headers = _zen_call_headers(mock_openai)
|
|
assert "Authorization" not in headers, (
|
|
"opencode-zen (keyed) must not have its Authorization header blanked"
|
|
)
|
|
|
|
|
|
@patch("agent.process_bootstrap.OpenAI")
|
|
def test_keyless_placeholder_blanks_authorization_under_paid_opencode_profile(mock_openai):
|
|
"""A free slug selected under the paid ``opencode`` profile resolves to the keyless
|
|
placeholder; it must be blanked exactly like under ``opencode-free``, or every request
|
|
401s with nothing in the pool to rotate (#110831)."""
|
|
mock_openai.return_value = MagicMock()
|
|
agent = _FakeAgent(api_key="opencode-zen-free-keyless")
|
|
agent.provider = "opencode"
|
|
create_openai_client(
|
|
agent,
|
|
{"api_key": "opencode-zen-free-keyless", "base_url": ZEN_V1},
|
|
reason="test",
|
|
shared=False,
|
|
)
|
|
assert _zen_call_headers(mock_openai).get("Authorization") == ""
|
|
|
|
|
|
def test_async_aux_wrapper_keeps_keyless_authorization_blank():
|
|
"""``_to_async_client`` rebuilds default_headers; the keyless placeholder must stay
|
|
blanked on the async twin too, or every async aux call ships the placeholder bearer."""
|
|
import openai
|
|
import agent.auxiliary_client as aux
|
|
|
|
sync_client = aux._create_openai_client(api_key="opencode-zen-free-keyless", base_url=ZEN_V1)
|
|
async_client, _ = aux._to_async_client(sync_client, "x-preview-f-free")
|
|
request = async_client._build_request(
|
|
openai._models.FinalRequestOptions.construct(method="post", url="/chat/completions", json_data={})
|
|
)
|
|
assert request.headers.get("authorization") == ""
|