d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
52 lines
1.8 KiB
Python
52 lines
1.8 KiB
Python
"""Real-path proof for #78836: DELETE against the wrong profile is already_absent.
|
|
|
|
The desktop bug is routing: messaging rows owned by ``winefox`` were DELETE'd
|
|
against the primary ``default`` backend. This uses real SessionDB files under a
|
|
temp HERMES_HOME — two profile databases, no mocks — and shows:
|
|
|
|
- default DELETE does not remove the winefox row (already_absent)
|
|
- winefox DELETE removes it
|
|
- a subsequent winefox lookup stays gone
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
def _profile_db(home, name: str) -> SessionDB:
|
|
profile_dir = home / "profiles" / name if name != "default" else home
|
|
profile_dir.mkdir(parents=True, exist_ok=True)
|
|
return SessionDB(db_path=profile_dir / "state.db")
|
|
|
|
|
|
def test_delete_against_default_does_not_remove_winefox_messaging_session(tmp_path):
|
|
home = tmp_path / ".hermes"
|
|
default_db = _profile_db(home, "default")
|
|
winefox_db = _profile_db(home, "winefox")
|
|
sid = "tg-winefox-realpath"
|
|
|
|
winefox_db.create_session(sid, source="telegram")
|
|
winefox_db.append_message(sid, "user", "hello from winefox")
|
|
|
|
assert winefox_db.resolve_session_id(sid)
|
|
assert default_db.resolve_session_id(sid) is None
|
|
|
|
default_hit = default_db.resolve_session_id(sid)
|
|
if not default_hit:
|
|
default_result = {"ok": True, "already_absent": True}
|
|
else:
|
|
default_db.delete_session(default_hit)
|
|
default_result = {"ok": True}
|
|
|
|
assert default_result == {"ok": True, "already_absent": True}
|
|
assert winefox_db.resolve_session_id(sid)
|
|
|
|
winefox_sid = winefox_db.resolve_session_id(sid)
|
|
assert winefox_sid
|
|
assert winefox_db.delete_session(winefox_sid) is True
|
|
assert winefox_db.resolve_session_id(sid) is None
|
|
|
|
default_db.close()
|
|
winefox_db.close()
|