26aa12337a
Rework of salvaged PR #6372 (@ag9920) onto current main: - /save promoted from CLI-only JSON snapshot to a cross-platform session export: `/save [json|md|html] [filename] [redact]` on CLI and every gateway platform (sent as a document via adapter.send_document). - Rendering routes through the existing shared renderers (hermes_cli/session_export.py + session_export_html.py) instead of the PR's new hermes_state formatter — new helpers normalize_save_format / render_session_for_save / default_save_filename are shared by both surfaces. - `redact` arg runs the export through the force-mode secret redaction pass (session_export_md.redact_session_data) before writing. - Gateway handler awaits AsyncSessionDB correctly, sanitizes user-supplied filenames with basename, and lands in gateway/slash_commands.py (the handlers moved out of gateway/run.py since the PR was authored). - /export stays profile export (name collision resolved: session export lives on /save). - Slack 50-slash cap curation: /platform moves to the /hermes-only set to free a native slot for /save (parity test updated rationale comment). - Folds in PR #62268 (@briandevans): None title/model coalescing in the single-session HTML export. Closes #4249. Closes #51200.
88 lines
2.7 KiB
Python
88 lines
2.7 KiB
Python
"""Tests for the /save current-session export helpers."""
|
|
|
|
import json
|
|
|
|
import pytest
|
|
|
|
from hermes_cli.session_export import (
|
|
SAVE_FORMATS,
|
|
default_save_filename,
|
|
normalize_save_format,
|
|
render_session_for_save,
|
|
)
|
|
|
|
|
|
SESSION = {
|
|
"id": "20260814_abc123",
|
|
"title": "Test Session",
|
|
"model": "test-model",
|
|
"started_at": 1755100000,
|
|
"messages": [
|
|
{"role": "user", "content": "Hello"},
|
|
{"role": "assistant", "content": "Hi there"},
|
|
{"role": "tool", "content": "tool output"},
|
|
],
|
|
}
|
|
|
|
|
|
class TestNormalizeSaveFormat:
|
|
def test_default_is_json(self):
|
|
assert normalize_save_format(None) == "json"
|
|
assert normalize_save_format("") == "json"
|
|
|
|
def test_aliases(self):
|
|
assert normalize_save_format("markdown") == "md"
|
|
assert normalize_save_format("MD") == "md"
|
|
assert normalize_save_format("HTML") == "html"
|
|
assert normalize_save_format("snapshot") == "json"
|
|
|
|
def test_unknown_raises(self):
|
|
with pytest.raises(ValueError):
|
|
normalize_save_format("pdf")
|
|
|
|
def test_all_declared_formats_normalize_to_themselves(self):
|
|
for fmt in SAVE_FORMATS:
|
|
assert normalize_save_format(fmt) == fmt
|
|
|
|
|
|
class TestRenderSessionForSave:
|
|
def test_json_round_trips(self):
|
|
out = render_session_for_save(SESSION, "json")
|
|
data = json.loads(out)
|
|
assert data["id"] == SESSION["id"]
|
|
assert len(data["messages"]) == 3
|
|
|
|
def test_markdown_contains_messages(self):
|
|
out = render_session_for_save(SESSION, "md")
|
|
assert "Hello" in out
|
|
assert "Hi there" in out
|
|
|
|
def test_html_is_standalone_document(self):
|
|
out = render_session_for_save(SESSION, "html")
|
|
assert out.lstrip().lower().startswith("<!doctype html")
|
|
assert "Hello" in out
|
|
|
|
def test_html_survives_none_title_and_model(self):
|
|
# Async title generation may not have run yet — None title/model is
|
|
# the default state for a fresh session (PR #62268 regression).
|
|
session = {**SESSION, "title": None, "model": None}
|
|
out = render_session_for_save(session, "html")
|
|
assert "<title>None</title>" not in out
|
|
|
|
def test_unknown_format_raises(self):
|
|
with pytest.raises(ValueError):
|
|
render_session_for_save(SESSION, "pdf")
|
|
|
|
|
|
class TestDefaultSaveFilename:
|
|
def test_basic(self):
|
|
assert default_save_filename("abc-123", "md") == "hermes_session_abc-123.md"
|
|
|
|
def test_hostile_session_id_sanitized(self):
|
|
name = default_save_filename("../../etc/passwd", "json")
|
|
assert "/" not in name
|
|
assert ".." not in name.replace("etcpasswd", "")
|
|
|
|
def test_empty_session_id(self):
|
|
assert default_save_filename("", "html") == "hermes_session_session.html"
|