4b67380698
Change-detectors, tautologies, source-reading tests, redundant duplicates, mock-echo tests and dead/unrunnable tests. Per-test rationale in the lane ledger (category + reason for every removal).
70 lines
2.8 KiB
Python
70 lines
2.8 KiB
Python
"""
|
|
Tests for skip_confirm and invalidate_cache behavior in /skills install
|
|
and /skills uninstall slash commands.
|
|
|
|
Slash commands always skip confirmation (input() hangs in TUI).
|
|
Cache invalidation is deferred by default; --now opts into immediate
|
|
invalidation (at the cost of breaking prompt cache mid-session).
|
|
|
|
Based on PR #1595 by 333Alden333 (salvaged).
|
|
Updated for PR #3586 (cache-aware install/uninstall).
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
|
|
class TestHandleSkillsSlashInstallFlags:
|
|
"""Test flag parsing in handle_skills_slash for install."""
|
|
|
|
def test_yes_flag_sets_skip_confirm(self):
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_install") as mock_install:
|
|
handle_skills_slash("/skills install test/skill --yes")
|
|
mock_install.assert_called_once()
|
|
_, kwargs = mock_install.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
assert kwargs.get("force") is False
|
|
|
|
|
|
class TestHandleSkillsSlashUninstallFlags:
|
|
"""Test flag parsing in handle_skills_slash for uninstall."""
|
|
|
|
|
|
def test_no_flags_still_skips_confirm(self):
|
|
"""Slash commands always skip confirmation — input() hangs in TUI."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("skip_confirm") is True
|
|
|
|
def test_default_defers_cache_invalidation(self):
|
|
"""Without --now, cache invalidation is deferred to next session."""
|
|
from hermes_cli.skills_hub import handle_skills_slash
|
|
with patch("hermes_cli.skills_hub.do_uninstall") as mock_uninstall:
|
|
handle_skills_slash("/skills uninstall test-skill")
|
|
mock_uninstall.assert_called_once()
|
|
_, kwargs = mock_uninstall.call_args
|
|
assert kwargs.get("invalidate_cache") is False
|
|
|
|
|
|
# We don't get to the input() call because resolve returns None,
|
|
# but the parameter wiring is correct
|
|
|
|
|
|
class TestDoUninstallSkipConfirm:
|
|
"""Test that do_uninstall respects skip_confirm parameter."""
|
|
|
|
def test_skip_confirm_bypasses_input(self):
|
|
"""With skip_confirm=True, input() should not be called."""
|
|
from hermes_cli.skills_hub import do_uninstall
|
|
with patch("hermes_cli.skills_hub._console") as mock_console, \
|
|
patch("tools.skills_hub_install.uninstall_skill", return_value=(True, "Removed")) as mock_uninstall, \
|
|
patch("builtins.input") as mock_input:
|
|
do_uninstall("test-skill", skip_confirm=True)
|
|
mock_input.assert_not_called()
|
|
mock_uninstall.assert_called_once_with("test-skill")
|
|
|
|
|