9d6e4e72a4
Independent-review follow-up for the group room failed-turn fix.
- Group room poll: a retained error newer than the pre-submit snapshot
(turn start replaces it with a fresh started_at) is this turn's failure
and wins over transcript text. The core closer writes no failed-turn row
behind a tool row, so "said X, called a tool, provider 401" left X as the
newest assistant row and the room posted it, dropped the 401 and re-drove
the member to the round cap (live repro on the PR head).
- Both pickers end the turn at a failed_turn row instead of scanning past
it; with the retained error gone (backend restart) the row's notice is
reported through the failed path instead of a silent pass / dropped
stranded marker. The stranded harvest treats a retained error as the
stranded turn's own the same way.
- REST cold-load/paging (/api/sessions/{id}/messages, /messages/around)
type legacy untyped notice rows like session.resume does, via one
read-side helper in agent/turn_failure_copy.py.
- Gateway closer: the fresh-session closure test now asserts the row's
display_kind through a real SessionDB round-trip (red without the
run_turn.py stamp).
- E2E: mock trigger that says text + calls a tool, then 401s; spec asserts
the room reports the error and never posts that text.
87 lines
3.6 KiB
Python
87 lines
3.6 KiB
Python
from pathlib import Path
|
|
|
|
import pytest
|
|
from fastapi import FastAPI
|
|
from fastapi.testclient import TestClient
|
|
|
|
|
|
@pytest.mark.parametrize("serving_profile", ["work", None])
|
|
def test_message_pages_identify_the_serving_profile(tmp_path, monkeypatch, serving_profile):
|
|
from hermes_state import SessionDB
|
|
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
default_home = tmp_path / ".hermes"
|
|
work_home = default_home / "profiles" / "work" if serving_profile else default_home / "custom-home"
|
|
default_home.mkdir(parents=True)
|
|
work_home.mkdir(parents=True)
|
|
monkeypatch.setenv("HERMES_HOME", str(work_home))
|
|
# conftest redirects this legacy override independently of HERMES_HOME.
|
|
monkeypatch.setattr("hermes_state.DEFAULT_DB_PATH", work_home / "state.db")
|
|
|
|
for home, count in ((default_home, 1), (work_home, 199)):
|
|
db = SessionDB(db_path=home / "state.db")
|
|
try:
|
|
db.create_session(session_id="same-id", source="desktop")
|
|
db.append_messages_batch("same-id", [
|
|
{"role": "user", "content": f"message-{index}"}
|
|
for index in range(count)
|
|
])
|
|
finally:
|
|
db.close()
|
|
|
|
from hermes_cli.web_routers.sessions import manage_router
|
|
|
|
app = FastAPI()
|
|
app.include_router(manage_router)
|
|
with TestClient(app) as client:
|
|
query = "limit=120&order=latest&include_compacted=true"
|
|
tail = client.get(f"/api/sessions/same-id/messages?{query}").json()
|
|
older = client.get(f"/api/sessions/same-id/messages?{query}&offset=120").json()
|
|
default = client.get(f"/api/sessions/same-id/messages?{query}&profile=default").json()
|
|
|
|
assert tail["profile"] == older["profile"] == (serving_profile or "default")
|
|
assert default["profile"] == "default"
|
|
assert len(tail["messages"]) == 120
|
|
assert len(older["messages"]) == 79
|
|
assert len(default["messages"]) == 1
|
|
assert [row["content"] for row in older["messages"] + tail["messages"]] == [
|
|
f"message-{index}" for index in range(199)
|
|
]
|
|
|
|
|
|
def test_message_pages_type_untyped_failed_turn_rows(tmp_path, monkeypatch):
|
|
"""Desktop cold-loads and pages through REST, not ``session.resume``: a failed-turn boundary
|
|
written before the closers typed it must reach it as ``failed_turn``, not model text."""
|
|
from agent.turn_failure_copy import FAILED_TURN_DISPLAY_KIND, FAILED_TURN_NOTICE, PARTIAL_FAILED_TURN_NOTICE
|
|
from hermes_state import SessionDB
|
|
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setattr("hermes_state.DEFAULT_DB_PATH", home / "state.db")
|
|
db = SessionDB(db_path=home / "state.db")
|
|
try:
|
|
db.create_session(session_id="s", source="desktop")
|
|
db.append_messages_batch("s", [
|
|
{"role": "user", "content": "a"},
|
|
{"role": "assistant", "content": FAILED_TURN_NOTICE},
|
|
{"role": "user", "content": "b"},
|
|
{"role": "assistant", "content": PARTIAL_FAILED_TURN_NOTICE},
|
|
{"role": "user", "content": "c"},
|
|
{"role": "assistant", "content": f"Quoting Hermes: {FAILED_TURN_NOTICE}"},
|
|
])
|
|
finally:
|
|
db.close()
|
|
|
|
from hermes_cli.web_routers.sessions import manage_router
|
|
|
|
app = FastAPI()
|
|
app.include_router(manage_router)
|
|
with TestClient(app) as client:
|
|
rows = client.get("/api/sessions/s/messages").json()["messages"]
|
|
|
|
assert [row.get("display_kind") for row in rows] == [
|
|
None, FAILED_TURN_DISPLAY_KIND, None, FAILED_TURN_DISPLAY_KIND, None, None,
|
|
]
|