d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
84 lines
3.5 KiB
Python
84 lines
3.5 KiB
Python
"""Tests for the CLI exit summary's resume hint, including profile-flag support."""
|
|
|
|
from datetime import datetime
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli(session_id="20260524_000001_abc123"):
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj.session_id = session_id
|
|
# _print_exit_summary requires a populated conversation history (msg_count > 0)
|
|
# to print the resume hint at all. One synthetic user turn is enough.
|
|
cli_obj.conversation_history = [{"role": "user", "content": "hi"}]
|
|
cli_obj.agent = None
|
|
cli_obj._session_db = None
|
|
cli_obj.session_start = datetime.now()
|
|
return cli_obj
|
|
|
|
|
|
class TestExitSummaryResumeHint:
|
|
"""The exit-line ``Resume this session with:`` hint must include the
|
|
active profile (`-p <name>`) so session IDs round-trip across
|
|
profile boundaries — sessions live under `~/.hermes-profiles/<profile>/`,
|
|
so a hint copied without `-p` from a non-default profile won't find
|
|
the session.
|
|
"""
|
|
|
|
def test_resume_hint_no_profile_flag_on_default(self, capsys):
|
|
cli_obj = _make_cli()
|
|
with patch("hermes_cli.profiles.get_active_profile_name", return_value="default"):
|
|
cli_obj._print_exit_summary()
|
|
out = capsys.readouterr().out
|
|
# No `-p` for the default profile.
|
|
assert "hermes --resume 20260524_000001_abc123" in out
|
|
assert " -p " not in out
|
|
|
|
def test_resume_hint_no_profile_flag_on_custom(self, capsys):
|
|
cli_obj = _make_cli()
|
|
with patch("hermes_cli.profiles.get_active_profile_name", return_value="custom"):
|
|
cli_obj._print_exit_summary()
|
|
out = capsys.readouterr().out
|
|
# "custom" is the standard HERMES_HOME indicator — no -p needed.
|
|
assert "hermes --resume 20260524_000001_abc123" in out
|
|
assert " -p " not in out
|
|
|
|
def test_resume_hint_includes_profile_flag_for_named_profile(self, capsys):
|
|
cli_obj = _make_cli()
|
|
with patch("hermes_cli.profiles.get_active_profile_name", return_value="dev"):
|
|
cli_obj._print_exit_summary()
|
|
out = capsys.readouterr().out
|
|
assert "hermes --resume 20260524_000001_abc123 -p dev" in out
|
|
|
|
def test_resume_hint_includes_profile_flag_on_title_hint_too(self, capsys, tmp_path):
|
|
"""When a session title is available, the `hermes -c "title"` hint
|
|
must also include the `-p` flag for non-default profiles.
|
|
"""
|
|
cli_obj = _make_cli()
|
|
fake_db = MagicMock()
|
|
fake_db.get_session_title.return_value = "My Cool Session"
|
|
cli_obj._session_db = fake_db
|
|
|
|
with patch("hermes_cli.profiles.get_active_profile_name", return_value="dev"):
|
|
cli_obj._print_exit_summary()
|
|
out = capsys.readouterr().out
|
|
assert 'hermes -c "My Cool Session" -p dev' in out
|
|
assert "hermes --resume 20260524_000001_abc123 -p dev" in out
|
|
|
|
def test_resume_hint_falls_back_when_profile_lookup_fails(self, capsys):
|
|
"""If `get_active_profile_name` raises (e.g. profiles module
|
|
missing during ``hermes update`` mid-flight), fall back to no
|
|
flag rather than crashing the exit summary.
|
|
"""
|
|
cli_obj = _make_cli()
|
|
with patch(
|
|
"hermes_cli.profiles.get_active_profile_name",
|
|
side_effect=RuntimeError("profiles unavailable"),
|
|
):
|
|
cli_obj._print_exit_summary()
|
|
out = capsys.readouterr().out
|
|
# Resume hint still printed without -p.
|
|
assert "hermes --resume 20260524_000001_abc123" in out
|
|
assert " -p " not in out
|