c1693d7dcc
tests/gateway/conftest.py already installs a comprehensive telegram mock at collection time (line 330), before any test module's imports run. The per-file copies were fully redundant — each was a simpler subset (plain strings, setdefault, fewer error classes) of the conftest version (which uses _fake_str_enum for PTB-faithful StrEnum semantics, sys.modules overwrite to win over partial/broken imports, and a full error hierarchy including BadRequest, Forbidden, RetryAfter, Conflict, InvalidToken). Removed: function def + module-level call + now-unused imports (sys, MagicMock where no longer referenced) + dangling comment blocks that referenced the deleted mock, in 27 test files. Left untouched: tests/gateway/conftest.py (canonical source) and tests/e2e/conftest.py (separate conftest tree that may run in isolation). Found by /simplify-code review of PR #90560.
87 lines
2.9 KiB
Python
87 lines
2.9 KiB
Python
"""Telegram typing indicator transient backoff tests."""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import AsyncMock
|
|
|
|
import pytest
|
|
|
|
_repo = str(Path(__file__).resolve().parents[2])
|
|
if _repo not in sys.path:
|
|
sys.path.insert(0, _repo)
|
|
from gateway.config import PlatformConfig
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
|
|
|
|
def _make_adapter():
|
|
adapter = TelegramAdapter(PlatformConfig(enabled=True, token="test-token"))
|
|
adapter._bot = AsyncMock()
|
|
return adapter
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_transient_failure_enters_cooldown(monkeypatch):
|
|
adapter = _make_adapter()
|
|
now = {"value": 1000.0}
|
|
monkeypatch.setattr("plugins.platforms.telegram.adapter.asyncio.get_running_loop", lambda: type("Loop", (), {"time": lambda self: now["value"]})())
|
|
monkeypatch.setattr(adapter, "_telegram_typing_cooldown_seconds", 30.0, raising=False)
|
|
|
|
async def fail_once(**kwargs):
|
|
raise OSError("temporary telegram network failure")
|
|
|
|
adapter._bot.send_chat_action = AsyncMock(side_effect=fail_once)
|
|
|
|
await adapter.send_typing("123")
|
|
await adapter.send_typing("123")
|
|
|
|
assert adapter._bot.send_chat_action.await_count == 1
|
|
assert adapter._telegram_typing_cooldown_until["123"] == pytest.approx(1030.0)
|
|
|
|
now["value"] = 1031.0
|
|
adapter._bot.send_chat_action = AsyncMock(return_value=None)
|
|
await adapter.send_typing("123")
|
|
|
|
assert adapter._bot.send_chat_action.await_count == 1
|
|
assert "123" not in adapter._telegram_typing_cooldown_until
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_dm_topic_fallback_success_does_not_cool_down(monkeypatch):
|
|
adapter = _make_adapter()
|
|
monkeypatch.setattr("plugins.platforms.telegram.adapter.asyncio.get_running_loop", lambda: type("Loop", (), {"time": lambda self: 10.0})())
|
|
|
|
calls = []
|
|
|
|
async def send_chat_action(**kwargs):
|
|
calls.append(kwargs)
|
|
if "message_thread_id" in kwargs:
|
|
raise RuntimeError("message thread not found")
|
|
return None
|
|
|
|
adapter._bot.send_chat_action = AsyncMock(side_effect=send_chat_action)
|
|
|
|
await adapter.send_typing(
|
|
"123",
|
|
metadata={"thread_id": "99", "telegram_dm_topic_reply_fallback": True},
|
|
)
|
|
|
|
assert len(calls) == 2
|
|
assert "123" not in adapter._telegram_typing_cooldown_until
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_typing_bad_thread_failure_does_not_cool_down(monkeypatch):
|
|
adapter = _make_adapter()
|
|
monkeypatch.setattr("plugins.platforms.telegram.adapter.asyncio.get_running_loop", lambda: type("Loop", (), {"time": lambda self: 10.0})())
|
|
|
|
async def bad_request(**kwargs):
|
|
raise ValueError("message thread not found")
|
|
|
|
adapter._bot.send_chat_action = AsyncMock(side_effect=bad_request)
|
|
|
|
await adapter.send_typing("123", metadata={"thread_id": "99"})
|
|
await adapter.send_typing("123", metadata={"thread_id": "99"})
|
|
|
|
assert adapter._bot.send_chat_action.await_count == 2
|
|
assert "123" not in adapter._telegram_typing_cooldown_until
|