6351d60a6f
The "atomic write != atomic load/merge/save triple" rationale was stated three times in our text. The canonical statement stays on `rich_sent_store._LOCK`; the inline `_update` comment and the `test_concurrent_record_async_calls_lose_no_entry` docstring now reference it in one line each. Behaviour-neutral: comments and a docstring only. PROOF: `git diff HEAD~1 --stat` touches 2 files, no code lines; ruff clean; `import gateway.rich_sent_store` ok; scripts/run_tests.sh tests/gateway/test_rich_sent_store_off_loop.py green. The sticker_cache.py async docstring and both off-loop test-module docstrings are blame-attributed to contributor commits 4a77e841d4 / 1642d6a093 and were left untouched per the fold rule; the helpers.py:116-127 two-lock comment is the canonical tracker statement and was kept.
59 lines
1.8 KiB
Python
59 lines
1.8 KiB
Python
"""The rich-sent index write runs off the event loop for coroutine callers."""
|
|
|
|
import asyncio
|
|
import threading
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from gateway import rich_sent_store
|
|
|
|
|
|
@pytest.fixture
|
|
def isolated_store(tmp_path, monkeypatch):
|
|
monkeypatch.setattr(rich_sent_store, "_store_path", lambda: str(tmp_path / "rich_sent.json"))
|
|
|
|
|
|
def test_record_async_runs_off_the_loop_thread(isolated_store, monkeypatch):
|
|
writer_thread: list[int] = []
|
|
real_update = rich_sent_store._update
|
|
|
|
def spy_update(chat_id, message_id, fields):
|
|
writer_thread.append(threading.get_ident())
|
|
real_update(chat_id, message_id, fields)
|
|
|
|
monkeypatch.setattr(rich_sent_store, "_update", spy_update)
|
|
|
|
async def go():
|
|
await rich_sent_store.record_async("chat", "42", "hello")
|
|
return threading.get_ident()
|
|
|
|
loop_thread = asyncio.run(go())
|
|
assert writer_thread and writer_thread[0] != loop_thread
|
|
assert rich_sent_store.lookup("chat", "42") == "hello"
|
|
|
|
|
|
def test_concurrent_record_async_calls_lose_no_entry(isolated_store, monkeypatch):
|
|
"""Two off-loop RMWs for different keys must both land in the durable file.
|
|
|
|
Slowing the write forces the lost-update race described on
|
|
``rich_sent_store._LOCK`` unless ``_update`` is serialized.
|
|
"""
|
|
real_write = rich_sent_store.atomic_json_write
|
|
|
|
def slow_write(path, data, *a, **kw):
|
|
time.sleep(0.2)
|
|
return real_write(path, data, *a, **kw)
|
|
|
|
monkeypatch.setattr(rich_sent_store, "atomic_json_write", slow_write)
|
|
|
|
async def go():
|
|
await asyncio.gather(
|
|
rich_sent_store.record_async("chat", "1", "one"),
|
|
rich_sent_store.record_async("chat", "2", "two"),
|
|
)
|
|
|
|
asyncio.run(go())
|
|
assert rich_sent_store.lookup("chat", "1") == "one"
|
|
assert rich_sent_store.lookup("chat", "2") == "two"
|