f27c719a93
`gateway/mirror.py` captured `sessions.json` under the home that was live at import. Under the multiplexed gateway one process serves every profile, so the pre-migration fallback in `_find_session_id()` resolved every profile's lookup against the launch profile's index — a `platform`+`chat_id` pair present in both indexes returns the launch profile's session id, mirroring a delivery into a session that belongs to another profile. Only the fallback is affected: the primary `state.db` query goes through a bare `acquire()`, which follows `get_hermes_home()` at call time and is already profile-correct. The access is read-only, so nothing was written to the wrong profile. Applies the resolve pattern the rest of the repo already uses (gateway/hooks.py, gateway/sticker_cache.py, tools/process_registry.py, tools/checkpoint_manager.py): keep the module constant as the monkeypatch surface, snapshot it at import, and re-resolve only when unchanged. The added test reloads the module under a launch home and then serves a lookup for a second profile; without the fix it returns `sess_launch` instead of `sess_active`. Fixes #112844
211 lines
8.3 KiB
Python
211 lines
8.3 KiB
Python
"""Tests for gateway/mirror.py — session mirroring."""
|
|
|
|
import importlib
|
|
import json
|
|
from unittest.mock import patch, MagicMock
|
|
|
|
import gateway.mirror as mirror_mod
|
|
from gateway.mirror import (
|
|
mirror_to_session,
|
|
_find_session_id,
|
|
)
|
|
|
|
|
|
def _setup_sessions(tmp_path, sessions_data):
|
|
"""Helper to write a fake sessions.json and patch module-level paths."""
|
|
sessions_dir = tmp_path / "sessions"
|
|
sessions_dir.mkdir(parents=True, exist_ok=True)
|
|
index_file = sessions_dir / "sessions.json"
|
|
index_file.write_text(json.dumps(sessions_data), encoding="utf-8")
|
|
return sessions_dir, index_file
|
|
|
|
|
|
class TestFindSessionId:
|
|
def test_finds_matching_session(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"agent:main:telegram:dm": {
|
|
"session_id": "sess_abc",
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
}
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = _find_session_id("telegram", "12345")
|
|
|
|
assert result == "sess_abc"
|
|
|
|
def test_returns_most_recent(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"old": {
|
|
"session_id": "sess_old",
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
"new": {
|
|
"session_id": "sess_new",
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-02-01T00:00:00",
|
|
},
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = _find_session_id("telegram", "12345")
|
|
|
|
assert result == "sess_new"
|
|
|
|
def test_thread_id_disambiguates_same_chat(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"topic_a": {
|
|
"session_id": "sess_topic_a",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "thread_id": "10"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
"topic_b": {
|
|
"session_id": "sess_topic_b",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "thread_id": "11"},
|
|
"updated_at": "2026-02-01T00:00:00",
|
|
},
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = _find_session_id("telegram", "-1001", thread_id="10")
|
|
|
|
assert result == "sess_topic_a"
|
|
|
|
|
|
class TestMirrorToSession:
|
|
|
|
|
|
def test_successful_mirror_uses_user_id_for_group_session(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"alice": {
|
|
"session_id": "sess_alice",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "user_id": "alice"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
"bob": {
|
|
"session_id": "sess_bob",
|
|
"origin": {"platform": "telegram", "chat_id": "-1001", "user_id": "bob"},
|
|
"updated_at": "2026-02-01T00:00:00",
|
|
},
|
|
})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file), \
|
|
patch("gateway.mirror._append_to_sqlite") as mock_sqlite:
|
|
result = mirror_to_session(
|
|
"telegram",
|
|
"-1001",
|
|
"Hello group!",
|
|
source_label="cli",
|
|
user_id="alice",
|
|
)
|
|
|
|
assert result is True
|
|
mock_sqlite.assert_called_once()
|
|
assert mock_sqlite.call_args[0][0] == "sess_alice"
|
|
|
|
def test_no_matching_session(self, tmp_path):
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {})
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file):
|
|
result = mirror_to_session("telegram", "99999", "Hello!")
|
|
|
|
assert result is False
|
|
|
|
|
|
def test_failed_sqlite_write_reports_false(self, tmp_path):
|
|
"""A mirror whose transcript write raises must not report success (#10130)."""
|
|
sessions_dir, index_file = _setup_sessions(tmp_path, {
|
|
"dm": {
|
|
"session_id": "sess_dm",
|
|
"origin": {"platform": "telegram", "chat_id": "123"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
},
|
|
})
|
|
broken_db = MagicMock()
|
|
broken_db.find_session_by_origin.return_value = None # resolve via sessions.json
|
|
broken_db.append_message.side_effect = OSError("disk full")
|
|
|
|
with patch.object(mirror_mod, "_SESSIONS_DIR", sessions_dir), \
|
|
patch.object(mirror_mod, "_SESSIONS_INDEX", index_file), \
|
|
patch("hermes_state_registry.acquire", return_value=broken_db), \
|
|
patch("hermes_state_registry.release_or_close"):
|
|
result = mirror_to_session("telegram", "123", "Hello!")
|
|
|
|
assert result is False
|
|
broken_db.append_message.assert_called_once()
|
|
|
|
|
|
class TestAppendToSqlite:
|
|
def test_connection_is_released_after_use(self, tmp_path):
|
|
"""Verify _append_to_sqlite returns the shared SessionDB reference."""
|
|
from gateway.mirror import _append_to_sqlite
|
|
mock_db = MagicMock()
|
|
released = []
|
|
|
|
with patch("hermes_state_registry.acquire", return_value=mock_db), \
|
|
patch(
|
|
"hermes_state_registry.release_or_close",
|
|
side_effect=lambda db: released.append(db),
|
|
):
|
|
_append_to_sqlite("sess_1", {"role": "assistant", "content": "hello"})
|
|
|
|
mock_db.append_message.assert_called_once()
|
|
assert released == [mock_db], (
|
|
"the shared handle must be released exactly once after use"
|
|
)
|
|
|
|
|
|
class TestSessionsIndexProfileScoping:
|
|
"""#112844: the fallback index must follow the active profile, not the launch one."""
|
|
|
|
@staticmethod
|
|
def _write_index(home, session_id):
|
|
d = home / "sessions"
|
|
d.mkdir(parents=True, exist_ok=True)
|
|
(d / "sessions.json").write_text(json.dumps({
|
|
"agent:main:telegram:dm": {
|
|
"session_id": session_id,
|
|
"origin": {"platform": "telegram", "chat_id": "12345"},
|
|
"updated_at": "2026-01-01T00:00:00",
|
|
}
|
|
}), encoding="utf-8")
|
|
|
|
def test_fallback_follows_active_profile_home(self, tmp_path, monkeypatch):
|
|
"""A profile switched in after import must be read, not the launch profile's index.
|
|
|
|
The module captures ``sessions.json`` under the home that was live at import. Under the
|
|
multiplexed gateway one process serves every profile, so a lookup for another profile
|
|
must not resolve against the launch profile's index and return its session id.
|
|
"""
|
|
launch_home, active_home = tmp_path / "launch", tmp_path / "active"
|
|
self._write_index(launch_home, "sess_launch")
|
|
self._write_index(active_home, "sess_active")
|
|
|
|
# Re-import the module with the launch home live: this is the import-time capture.
|
|
monkeypatch.setenv("HERMES_HOME", str(launch_home))
|
|
importlib.reload(mirror_mod)
|
|
try:
|
|
# A request for a different profile is now served by the same process.
|
|
monkeypatch.setenv("HERMES_HOME", str(active_home))
|
|
assert mirror_mod._find_session_id("telegram", "12345") == "sess_active"
|
|
finally:
|
|
monkeypatch.undo()
|
|
importlib.reload(mirror_mod)
|
|
|
|
def test_patched_constant_still_wins(self, tmp_path, monkeypatch):
|
|
"""Tests that patch ``_SESSIONS_INDEX`` keep overriding the live home."""
|
|
patched = tmp_path / "patched"
|
|
self._write_index(patched, "sess_patched")
|
|
|
|
monkeypatch.setattr(mirror_mod, "_SESSIONS_INDEX", patched / "sessions" / "sessions.json")
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path / "elsewhere"))
|
|
|
|
assert mirror_mod._find_session_id("telegram", "12345") == "sess_patched"
|