Files
hermes-agent/tools/computer_use/permissions.py
kshitijk4poor db1f3f4564 fix(computer-use): doctor names the stale TCC row on the health_report path too
The first cut appended the recovery only in `_tcc_row`, which is built by the
0.10 fallback probes. Drivers that serve health_report (0.22+, the ones a
stale row actually bites) render their own tcc_* rows untouched, so `doctor`
never showed it. Apply the hint at the report seam like the display-count
guard so both paths get it.

Also: one CUA_DRIVER_BUNDLE_ID (permissions.py is the leaf; the daemon
imports it), the CLI derives the field set from the same table, and the
unverified "--upgrade repairs stale rows" claim is dropped from hint + docs
(the user hitting this is already on a current driver).
2026-09-21 16:21:00 +05:30

137 lines
7.5 KiB
Python

"""Cross-platform Computer Use readiness + macOS permission helpers. "Ready to drive" differs per platform: macOS
needs explicit TCC grants (Accessibility + Screen Recording) via cua-driver ``permissions status`` / ``permissions
grant``; Windows/Linux have no TCC toggles, so readiness == driver health. The grants attach to cua-driver's OWN
identity (``com.trycua.driver``), not Hermes, so ``grant`` launches CuaDriver via LaunchServices for correct dialog
attribution. ``cua-driver doctor --json`` is the universal signal; ``computer_use_status`` folds it with the macOS
detail into one payload for the desktop card, the ``permissions`` CLI and ``/api/tools/computer-use/status``."""
from __future__ import annotations
import json
import os
import subprocess
import sys
from contextlib import suppress
from typing import Any, Dict, Optional
from hermes_cli._subprocess_compat import windows_hide_flags
_RUNTIME_PLATFORMS = frozenset({"darwin", "win32", "linux"}) # mirrors the toolset platform_gate
_BOOLS = ("accessibility", "screen_recording", "screen_recording_capturable")
CUA_DRIVER_BUNDLE_ID = "com.trycua.driver" # the only identity TCC rows and the private daemon are keyed to
_TCC_SERVICES = {"accessibility": "Accessibility", "screen_recording": "ScreenCapture"} # status field -> tccutil service
TCC_FIELDS = tuple(_TCC_SERVICES)
def stale_tcc_grant_hint(*missing: str) -> str:
"""Recovery text for grants the daemon reports missing while System Settings shows the CuaDriver toggle ON.
TCC keys each row to the app's code-signing requirement, so a row written for an earlier CuaDriver build can
stop matching after a driver update: the toggle stays ON, the daemon is denied, and flipping the toggle does
not rewrite the requirement (trycua/cua#3170). Only a reset + re-grant recovers it, so the hint names the
exact rows for the *missing* status fields.
"""
resets = " && ".join(f"tccutil reset {_TCC_SERVICES[f]} {CUA_DRIVER_BUNDLE_ID}" for f in missing if f in _TCC_SERVICES)
if not resets:
return ""
return ("If System Settings already shows CuaDriver ON, the stored grant is stale (it no longer matches the installed "
f"driver's signature): run `{resets}`, then `hermes computer-use permissions grant`.")
def _child_env() -> Dict[str, str]:
"""cua-driver child env (telemetry policy + provider secrets stripped); ``os.environ`` on import error.
cua-driver is a third-party binary — it must never inherit provider API keys (#53503/#55709/#58889
lineage). Each layer degrades gracefully so permission probes never break on a helper import error.
"""
try:
from tools.computer_use.cua_backend import sanitized_cua_driver_env
return sanitized_cua_driver_env()
except Exception:
return dict(os.environ)
def _run(binary: str, *args: str, timeout: float) -> subprocess.CompletedProcess:
return subprocess.run([binary, *args], capture_output=True, text=True, encoding='utf-8', errors='replace',
timeout=timeout, env=_child_env(), stdin=subprocess.DEVNULL, creationflags=windows_hide_flags())
def _json_out(binary: str, *args: str, timeout: float) -> Any:
"""Run ``binary args`` and parse stdout as JSON (``None`` on empty output)."""
raw = (_run(binary, *args, timeout=timeout).stdout or "").strip()
return json.loads(raw) if raw else None
def _doctor(binary: str) -> Optional[Dict[str, Any]]:
"""``cua-driver doctor --json`` → ``{ok, checks:[{label,status,message}]}`` (None on any failure)."""
try:
data = _json_out(binary, "doctor", "--json", timeout=12)
except Exception:
data = None
if not isinstance(data, dict):
return None
checks = [{k: str(p.get(k, "")) for k in ("label", "status", "message")} for p in data.get("probes", []) if isinstance(p, dict)]
return {"ok": bool(data.get("ok")), "checks": checks}
def _mac_permissions(binary: str, out: Dict[str, Any]) -> None:
"""Fold ``cua-driver permissions status --json`` booleans (+ ``source``) into ``out``."""
try:
data = _json_out(binary, "permissions", "status", "--json", timeout=10)
except subprocess.TimeoutExpired:
out["error"] = "cua-driver permissions status timed out"
except Exception as exc: # spawn failure or malformed JSON
out["error"] = f"cua-driver permissions status failed: {exc}"
else:
if isinstance(data, dict):
out.update({k: data[k] for k in _BOOLS if isinstance(data.get(k), bool)})
if isinstance(data.get("source"), dict):
out["source"] = data["source"]
def computer_use_status(driver_cmd: Optional[str] = None) -> Dict[str, Any]:
"""OS-aware readiness for the desktop card; key order is an API payload contract. ``ready`` is the single signal the
UI keys off: macOS = both TCC grants, elsewhere = driver health (no TCC model); ``None`` = unknown (binary missing /
probe failed). ``can_grant`` is macOS-only."""
from tools.computer_use.cua_backend_driver import resolve_cua_driver_cmd # same resolver as the tool itself
plat, binary = sys.platform, resolve_cua_driver_cmd(driver_cmd)
out: Dict[str, Any] = {"platform": plat, "platform_supported": plat in _RUNTIME_PLATFORMS,
"installed": bool(binary), "version": None, "ready": None, "can_grant": plat == "darwin",
"checks": [], "source": None, "error": None, **{k: None for k in _BOOLS}}
if not binary:
return out
with suppress(Exception):
out["version"] = (_run(binary, "--version", timeout=5).stdout or "").strip() or None
doctor = _doctor(binary)
if doctor is not None:
out["checks"] = doctor["checks"]
if plat == "darwin":
_mac_permissions(binary, out)
if out["error"] is None:
out["ready"] = out["accessibility"] is True and out["screen_recording"] is True
elif doctor is not None:
out["ready"] = doctor["ok"] # no TCC model off macOS
return out
def request_permissions_grant(driver_cmd: Optional[str] = None) -> int:
"""Run ``cua-driver permissions grant`` (macOS), streaming its output. Returns the driver's exit code (0 ok), 2 if
the binary is missing, 64 on a non-macOS platform (no TCC model to grant)."""
if sys.platform != "darwin":
print("Computer Use permissions are a macOS concept; nothing to grant here.")
return 64
from tools.computer_use.cua_backend_driver import resolve_cua_driver_cmd
binary = resolve_cua_driver_cmd(driver_cmd)
if not binary:
print("cua-driver: not installed. Run: hermes computer-use install")
return 2
print("Requesting Accessibility + Screen Recording for CuaDriver.\n"
f"macOS will show a dialog attributed to CuaDriver ({CUA_DRIVER_BUNDLE_ID}) — approve it, then return here.")
try:
return int(subprocess.run([binary, "permissions", "grant"], env=_child_env(), stdin=subprocess.DEVNULL).returncode)
except KeyboardInterrupt: # pragma: no cover - interactive
return 130
except Exception as exc: # pragma: no cover - defensive
print(f"cua-driver permissions grant failed: {exc}", file=sys.stderr)
return 2
# ---- BEGIN PLUGIN-COMPAT (revert-scheduled; see COMPAT_MANIFEST.md) ----
# Names external plugins imported from this module before the Sep 2026 decomposition.
# Internal code MUST NOT use these (scripts/check_compat_pointers.py fails CI if it does).
# The whole block is removed by reverting the commit that added it.
from typing import List # noqa: F401,E402
# ---- END PLUGIN-COMPAT ----