d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
31 lines
1.1 KiB
Python
31 lines
1.1 KiB
Python
"""Regression tests for install.sh Python environment sanitization.
|
|
|
|
When install.sh is launched from another Python-driven tool session, inherited
|
|
PYTHONPATH/PYTHONHOME can shadow the freshly installed checkout. The installer
|
|
must sanitize those vars both during installation and at runtime launch.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent
|
|
INSTALL_SH = REPO_ROOT / "scripts" / "install.sh"
|
|
|
|
|
|
def test_install_script_unsets_pythonpath_and_pythonhome_early() -> None:
|
|
text = INSTALL_SH.read_text()
|
|
|
|
# During install, inherited Python env must be sanitized before pip/venv use.
|
|
assert 'unset PYTHONPATH' in text
|
|
assert 'unset PYTHONHOME' in text
|
|
|
|
|
|
def test_hermes_launcher_wrapper_clears_python_env_before_exec() -> None:
|
|
text = INSTALL_SH.read_text()
|
|
|
|
# Wrapper should clear env and forward args untouched to the venv entrypoint.
|
|
assert 'cat > "$command_link_dir/hermes" <<EOF' in text
|
|
assert 'unset PYTHONPATH' in text
|
|
assert 'unset PYTHONHOME' in text
|
|
assert 'exec "$HERMES_BIN" "\\$@"' in text
|