de083436bd
Gate review: TelegramAdapter kept a same-named override with a weaker contract (no finite guard, negatives clamped instead of reset), so the hierarchy had two parsers under one name. Both Telegram callers pass explicit bounds; the base method is a strict superset for them. The cadence test now pins the behaviour (≤ 0.5 s / ≤ 1.0 s) instead of echoing the constant.
43 lines
1.9 KiB
Python
43 lines
1.9 KiB
Python
"""Text-batch debounce defaults must not exceed Telegram's cadence (#44883, #25056).
|
|
|
|
WhatsApp (5s/10s) and Weixin (3s/5s) used to hold every reply for seconds
|
|
before dispatching; Telegram waits 0.3s (1.0s near a split chunk).
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
from gateway.platforms.event import MessageEvent, MessageType
|
|
from gateway.platforms.weixin import WeixinAdapter
|
|
from gateway.session import SessionSource
|
|
from plugins.platforms.whatsapp.adapter import WhatsAppAdapter
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
("adapter_cls", "platform"),
|
|
[(WhatsAppAdapter, Platform.WHATSAPP), (WeixinAdapter, Platform.WEIXIN)],
|
|
ids=["whatsapp", "weixin"],
|
|
)
|
|
def test_default_text_batch_delays_match_telegram_cadence(adapter_cls, platform, tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
adapter = adapter_cls(PlatformConfig(enabled=True, extra={}))
|
|
source = SessionSource(platform=platform, chat_id="c1", chat_type="dm", user_id="u1")
|
|
short_event = MessageEvent(text="hello", message_type=MessageType.TEXT, source=source)
|
|
short_event._last_chunk_len = len(short_event.text)
|
|
|
|
# Telegram's cadence: 0.3 s per message, 1.0 s when the last chunk sat near a split.
|
|
assert adapter._text_batch_delay_for(short_event) <= 0.5
|
|
assert adapter._text_batch_split_delay_seconds <= 1.0
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"adapter_cls", [WhatsAppAdapter, WeixinAdapter], ids=["whatsapp", "weixin"],
|
|
)
|
|
def test_text_batch_delays_clamped_to_shared_ceilings(adapter_cls, tmp_path, monkeypatch):
|
|
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
|
|
adapter = adapter_cls(PlatformConfig(
|
|
enabled=True, extra={"text_batch_delay_seconds": "2.5", "text_batch_split_delay_seconds": 7}))
|
|
|
|
assert adapter._text_batch_delay_seconds == adapter._TEXT_BATCH_MAX_DELAY_S
|
|
assert adapter._text_batch_split_delay_seconds == adapter._TEXT_BATCH_MAX_SPLIT_DELAY_S
|