c1693d7dcc
tests/gateway/conftest.py already installs a comprehensive telegram mock at collection time (line 330), before any test module's imports run. The per-file copies were fully redundant — each was a simpler subset (plain strings, setdefault, fewer error classes) of the conftest version (which uses _fake_str_enum for PTB-faithful StrEnum semantics, sys.modules overwrite to win over partial/broken imports, and a full error hierarchy including BadRequest, Forbidden, RetryAfter, Conflict, InvalidToken). Removed: function def + module-level call + now-unused imports (sys, MagicMock where no longer referenced) + dangling comment blocks that referenced the deleted mock, in 27 test files. Left untouched: tests/gateway/conftest.py (canonical source) and tests/e2e/conftest.py (separate conftest tree that may run in isolation). Found by /simplify-code review of PR #90560.
56 lines
1.7 KiB
Python
56 lines
1.7 KiB
Python
"""Regression guard: send_slash_confirm must use format_message + MARKDOWN_V2."""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
from types import SimpleNamespace
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
_repo = str(Path(__file__).resolve().parents[2])
|
|
if _repo not in sys.path:
|
|
sys.path.insert(0, _repo)
|
|
from plugins.platforms.telegram.adapter import TelegramAdapter
|
|
from gateway.config import PlatformConfig
|
|
|
|
|
|
def _make_adapter():
|
|
config = PlatformConfig(enabled=True, token="test-token", extra={})
|
|
adapter = TelegramAdapter(config)
|
|
adapter._bot = AsyncMock()
|
|
adapter._app = MagicMock()
|
|
return adapter
|
|
|
|
|
|
class TestSendSlashConfirm:
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_uses_markdown_v2_and_escapes_special_chars(self):
|
|
"""send_slash_confirm must pass preview through format_message and use
|
|
MARKDOWN_V2 — so commands with underscores, dots, or brackets don't
|
|
raise BadRequest: Can't parse entities."""
|
|
adapter = _make_adapter()
|
|
sent = {}
|
|
|
|
async def mock_send(**kwargs):
|
|
sent.update(kwargs)
|
|
return SimpleNamespace(message_id=7)
|
|
|
|
adapter._bot.send_message = AsyncMock(side_effect=mock_send)
|
|
|
|
result = await adapter.send_slash_confirm(
|
|
chat_id="100",
|
|
title="Confirm",
|
|
message="/run script_name.sh --flag=value [option]",
|
|
session_key="sk",
|
|
confirm_id="cid1",
|
|
)
|
|
|
|
assert result.success is True
|
|
assert "MARKDOWN_V2" in repr(sent["parse_mode"])
|
|
# Underscores and dots must be escaped by format_message
|
|
assert "script\\_name" in sent["text"]
|
|
assert "\\." in sent["text"]
|
|
|
|
|