c622dd53c4
Same bug class as the warm-up: `_start_free_tier_bootstrap` ran on a bare executor thread, and `anon_auth.ensure_portal_identity` resolves the Portal through `_nous_portal_env_override`, so under multiplex a non-production HERMES_PORTAL_BASE_URL read as absent and the identity would be minted against the production Portal. Route the hop through `_run_boot_probe_in_launch_scope`. Gated behind guest onboarding, so latent on today's fleet; one test pins the binding.
101 lines
4.1 KiB
Python
101 lines
4.1 KiB
Python
"""Boot probes run inside the launch profile's scope under multiplex.
|
|
|
|
``get_tool_definitions`` runs every ``check_fn``; the vision probe resolves Nous runtime
|
|
credentials, whose Portal / inference routing overrides read through ``agent.secret_scope.get_secret``.
|
|
With multiplex active and no scope on the executor thread that read fails closed, the override is
|
|
absent, and a non-production Portal's refresh token is POSTed to the production Portal. The warm-up
|
|
must run under the same binding a routed turn gets, and the binding must reach the executor thread.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import asyncio
|
|
import types
|
|
|
|
import pytest
|
|
|
|
from agent import secret_scope
|
|
from gateway import run as gateway_run
|
|
from gateway.run_startup import GatewayStartupMixin
|
|
|
|
PORTAL = "https://portal.staging-nousresearch.com"
|
|
|
|
|
|
@pytest.fixture
|
|
def multiplex_home(tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
home.mkdir()
|
|
(home / ".env").write_text(f"HERMES_PORTAL_BASE_URL={PORTAL}\n")
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.delenv("HERMES_PORTAL_BASE_URL", raising=False)
|
|
monkeypatch.delenv("NOUS_PORTAL_BASE_URL", raising=False)
|
|
secret_scope.set_multiplex_active(True)
|
|
try:
|
|
yield home
|
|
finally:
|
|
secret_scope.set_multiplex_active(False)
|
|
|
|
|
|
def _probe(seen: dict):
|
|
def probe() -> int:
|
|
from hermes_cli.auth_nous import _nous_portal_env_override
|
|
seen["scope_installed"] = secret_scope._SECRET_SCOPE.get() is not None
|
|
seen["portal_override"] = _nous_portal_env_override()
|
|
return 1
|
|
return probe
|
|
|
|
|
|
class _Runner(GatewayStartupMixin):
|
|
def __init__(self, *, multiplex: bool):
|
|
self.config = types.SimpleNamespace(multiplex_profiles=multiplex)
|
|
|
|
|
|
def _run_warmup(monkeypatch, *, multiplex: bool) -> dict:
|
|
"""Drive ``_warm_turn_prerequisites`` with the sync warm-up replaced by a probe that records what
|
|
the executor thread can see, then what the loop task sees once the warm-up has returned."""
|
|
seen: dict = {}
|
|
monkeypatch.setattr(gateway_run, "_warm_turn_machinery_sync", _probe(seen))
|
|
|
|
async def drive() -> None:
|
|
await _Runner(multiplex=multiplex)._warm_turn_prerequisites()
|
|
# Same task as the warm-up (asyncio.run copies the context, so the caller's view proves nothing).
|
|
from hermes_constants import get_hermes_home_override
|
|
seen["scope_after"] = secret_scope._SECRET_SCOPE.get()
|
|
seen["home_override_after"] = get_hermes_home_override()
|
|
|
|
asyncio.run(drive())
|
|
return seen
|
|
|
|
|
|
def test_multiplex_warmup_runs_check_fns_inside_the_launch_profile_scope(multiplex_home, monkeypatch):
|
|
"""The executor thread sees the launch profile's secret scope, so the .env routing override resolves
|
|
exactly as it does on a routed turn — never the fail-closed 'absent' that heals to production. The
|
|
binding is per activity: once the warm-up returns, the loop thread is unscoped again."""
|
|
seen = _run_warmup(monkeypatch, multiplex=True)
|
|
assert seen["scope_installed"] is True
|
|
assert seen["portal_override"] == PORTAL
|
|
assert seen["scope_after"] is None
|
|
assert seen["home_override_after"] is None
|
|
|
|
|
|
def test_single_profile_warmup_keeps_environ_semantics(tmp_path, monkeypatch):
|
|
"""Multiplex off: no scope is installed and the process env stays the override source."""
|
|
home = tmp_path / "home"
|
|
home.mkdir()
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_PORTAL_BASE_URL", PORTAL)
|
|
secret_scope.set_multiplex_active(False)
|
|
seen = _run_warmup(monkeypatch, multiplex=False)
|
|
assert seen["scope_installed"] is False
|
|
assert seen["portal_override"] == PORTAL
|
|
|
|
|
|
def test_multiplex_free_tier_bootstrap_runs_inside_the_launch_profile_scope(multiplex_home, monkeypatch):
|
|
"""The free-tier bootstrap mints the Portal identity at boot through the same override; it is the
|
|
sibling unscoped executor hop and gets the same binding."""
|
|
seen: dict = {}
|
|
runner = _Runner(multiplex=True)
|
|
runner._start_free_tier_bootstrap = _probe(seen)
|
|
asyncio.run(runner._run_free_tier_bootstrap())
|
|
assert seen["scope_installed"] is True
|
|
assert seen["portal_override"] == PORTAL
|