39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
51 lines
1.8 KiB
Python
51 lines
1.8 KiB
Python
"""Tests for Discord thread participation persistence.
|
|
|
|
Verifies that _threads (ThreadParticipationTracker) survives adapter restarts by
|
|
being persisted to ~/.hermes/discord_threads.json.
|
|
"""
|
|
|
|
import json
|
|
import os
|
|
from unittest.mock import patch
|
|
|
|
|
|
class TestDiscordThreadPersistence:
|
|
"""Thread IDs are saved to disk and reloaded on init."""
|
|
|
|
def _make_adapter(self, tmp_path):
|
|
"""Build a minimal DiscordAdapter with HERMES_HOME pointed at tmp_path."""
|
|
from gateway.config import PlatformConfig
|
|
from plugins.platforms.discord.adapter import DiscordAdapter
|
|
|
|
config = PlatformConfig(enabled=True, token="test-token")
|
|
with patch.dict(os.environ, {"HERMES_HOME": str(tmp_path)}):
|
|
return DiscordAdapter(config=config)
|
|
|
|
def test_starts_empty_when_no_state_file(self, tmp_path):
|
|
adapter = self._make_adapter(tmp_path)
|
|
assert "$nonexistent" not in adapter._threads
|
|
|
|
def test_track_thread_persists_to_disk(self, tmp_path):
|
|
adapter = self._make_adapter(tmp_path)
|
|
with patch.dict(os.environ, {"HERMES_HOME": str(tmp_path)}):
|
|
adapter._threads.mark("111")
|
|
adapter._threads.mark("222")
|
|
|
|
state_file = tmp_path / "discord_threads.json"
|
|
assert state_file.exists()
|
|
saved = json.loads(state_file.read_text())
|
|
assert set(saved) == {"111", "222"}
|
|
|
|
def test_threads_survive_restart(self, tmp_path):
|
|
"""Threads tracked by one adapter instance are visible to the next."""
|
|
adapter1 = self._make_adapter(tmp_path)
|
|
with patch.dict(os.environ, {"HERMES_HOME": str(tmp_path)}):
|
|
adapter1._threads.mark("aaa")
|
|
adapter1._threads.mark("bbb")
|
|
|
|
adapter2 = self._make_adapter(tmp_path)
|
|
assert "aaa" in adapter2._threads
|
|
assert "bbb" in adapter2._threads
|
|
|
|
|