39975613b1
Second, deeper pass over tools/gateway/hermes_cli plus first pass over the trees wave 1 missed (acp, acp_adapter, skills, computer_use, docker, dashboard, conformance, monitoring, secret_sources, hermes_state, providers). Same rubric as wave 1 (AGENTS.md test policy); security, alternation/caching invariants, issue-number regressions, and E2E kept. Real test-quality fixes found and rooted out along the way: - tests/tools/test_command_guards.py made real auxiliary-LLM HTTPS calls (DEFAULT_CONFIG smart-approval leaked in) — pinned approval mode=manual via autouse fixture: 17.4s → 0.4s. - test_model_switch_custom_providers.py / test_user_providers_model_switch.py silently probed live provider catalogs (~2s/test) — stubbed cached_provider_model_ids/provider_model_ids/fetch_api_models. - test_telegram_noise_filter.py: 15-platform copy-paste matrix over shared gateway.run logic → 3 representative platforms (55s → 3.9s). - test_gateway_shutdown.py: stop()'s 5s interrupt-deadline loop spun on MagicMock agents — interrupt.side_effect now clears _running_agents (22s → 1.0s). - test_gateway_inactivity_timeout.py poll-harness timings shrunk 3-5x (24s → 1.1s); test_mcp_stability.py backoff/SIGTERM-grace sleeps patched (15.4s → 2.5s); test_async_delegation.py negative-drain wait 5s → 0.5s. - test_telegram_init_deadline.py: loop-block margin restored to 1.0s with rationale comment — the watchdog-dump assertion needs the loop blocked well past deadline+grace under parallel load (flaked once in the 40-worker verification run at a 0.2s margin). Verification: full hermetic suite via scripts/run_tests.sh — 2,438 files, 21,718 tests passed, 0 failed, 293.9s wall. Suite totals vs original baseline: 46,820 → 19,757 test functions (−57.8%), wall 583.5s → 293.9s (−50%), subprocess CPU 13,564s → 11,623s.
74 lines
2.5 KiB
Python
74 lines
2.5 KiB
Python
"""Tests for Discord system message filtering (thread renames, pins, etc.)."""
|
|
|
|
import pytest
|
|
import unittest
|
|
from unittest.mock import MagicMock
|
|
|
|
discord = pytest.importorskip("discord")
|
|
|
|
|
|
def _make_author(*, bot: bool = False, is_self: bool = False):
|
|
"""Create a mock Discord author."""
|
|
author = MagicMock()
|
|
author.bot = bot
|
|
author.id = 99999 if is_self else 12345
|
|
author.name = "TestBot" if bot else "TestUser"
|
|
author.display_name = author.name
|
|
return author
|
|
|
|
|
|
def _make_message(*, author=None, content="hello", msg_type=None):
|
|
"""Create a mock Discord message with a specific type."""
|
|
msg = MagicMock()
|
|
msg.author = author or _make_author()
|
|
msg.content = content
|
|
msg.attachments = []
|
|
msg.mentions = []
|
|
msg.type = msg_type if msg_type is not None else discord.MessageType.default
|
|
msg.channel = MagicMock()
|
|
msg.channel.id = 222
|
|
msg.channel.name = "test-channel"
|
|
msg.channel.guild = MagicMock()
|
|
msg.channel.guild.name = "TestServer"
|
|
return msg
|
|
|
|
|
|
class TestDiscordSystemMessageFilter(unittest.TestCase):
|
|
"""Test that Discord system messages (thread renames, pins, etc.) are ignored."""
|
|
|
|
def _run_filter(self, message, client_user=None):
|
|
"""Simulate the on_message filter logic and return whether message was accepted.
|
|
|
|
Replicates the guard added to discord.py:
|
|
if message.type not in (discord.MessageType.default, discord.MessageType.reply):
|
|
return # ignored
|
|
"""
|
|
# Own messages always ignored
|
|
if message.author == client_user:
|
|
return False
|
|
|
|
# System message filter (the fix being tested)
|
|
if message.type not in {discord.MessageType.default, discord.MessageType.reply}:
|
|
return False
|
|
|
|
return True # message accepted
|
|
|
|
def test_default_messages_accepted(self):
|
|
"""Regular user messages (type=default) should be accepted."""
|
|
msg = _make_message(msg_type=discord.MessageType.default)
|
|
self.assertTrue(self._run_filter(msg))
|
|
|
|
def test_reply_messages_accepted(self):
|
|
"""Reply messages (type=reply) should be accepted — users reply to bot messages."""
|
|
msg = _make_message(msg_type=discord.MessageType.reply)
|
|
self.assertTrue(self._run_filter(msg))
|
|
|
|
def test_thread_rename_ignored(self):
|
|
"""Thread rename system messages should be ignored."""
|
|
msg = _make_message(msg_type=discord.MessageType.channel_name_change)
|
|
self.assertFalse(self._run_filter(msg))
|
|
|
|
|
|
if __name__ == "__main__":
|
|
unittest.main()
|