8969511209
on_turn_start already received the author trio. sync_turn did not, so a provider that wanted to write the turn under its author had to stash state between the two hooks. sync_turn now takes turn_author as a keyword-only argument, and MemoryManager sends it only to providers whose signature accepts it, so existing providers keep working unchanged. build_turn_context resets the author on the agent at the start of every turn so a cached gateway agent never carries a bot author into the next human turn. agent/turn_author.py holds the parsing and the HERMES_TURN_AUTHOR carrier. MemoryProvider.identity_signature() is a new optional hook: the identity values a provider writes under, declared by the provider itself, for the gateway's agent cache to key on.
106 lines
3.9 KiB
Python
106 lines
3.9 KiB
Python
"""Regression guard for #15218 — external memory sync must skip interrupted turns.
|
|
|
|
Before this fix, ``run_conversation`` called
|
|
``memory_manager.sync_all(original_user_message, final_response)`` at the
|
|
end of every turn where both args were present. That gate didn't check
|
|
the ``interrupted`` flag, so an external memory backend received partial
|
|
assistant output, aborted tool chains, or mid-stream resets as durable
|
|
conversational truth. Downstream recall then treated that not-yet-real
|
|
state as if the user had seen it complete.
|
|
|
|
The fix is ``AIAgent._sync_external_memory_for_turn`` — a small helper
|
|
that replaces the inline block and returns early when ``interrupted``
|
|
is True (regardless of whether ``final_response`` and
|
|
``original_user_message`` happen to be populated).
|
|
|
|
These tests exercise the helper directly on a bare ``AIAgent`` built
|
|
via ``__new__`` so the full ``run_conversation`` machinery isn't needed
|
|
— the method is pure logic and three state arguments.
|
|
"""
|
|
from unittest.mock import MagicMock
|
|
|
|
import pytest
|
|
|
|
|
|
def _bare_agent():
|
|
"""Build an ``AIAgent`` with only the attributes
|
|
``_sync_external_memory_for_turn`` touches — matches the bare-agent
|
|
pattern used across ``tests/run_agent/test_interrupt_propagation.py``.
|
|
"""
|
|
from run_agent import AIAgent
|
|
|
|
agent = AIAgent.__new__(AIAgent)
|
|
agent._memory_manager = MagicMock()
|
|
# session_id is now propagated into sync_all / queue_prefetch_all so
|
|
# providers that cache per-session state can update it mid-process
|
|
# (see #6672).
|
|
agent.session_id = "test_session_001"
|
|
return agent
|
|
|
|
|
|
class TestSyncExternalMemoryForTurn:
|
|
# --- Interrupt guard (the #15218 fix) -------------------------------
|
|
|
|
def test_interrupted_turn_does_not_sync(self):
|
|
"""The whole point of #15218: even with a final_response and a
|
|
user message, an interrupted turn must NOT reach the memory
|
|
backend."""
|
|
agent = _bare_agent()
|
|
agent._sync_external_memory_for_turn(
|
|
original_user_message="What time is it?",
|
|
final_response="It is 3pm.", # looks complete — but partial
|
|
interrupted=True,
|
|
)
|
|
agent._memory_manager.sync_all.assert_not_called()
|
|
agent._memory_manager.queue_prefetch_all.assert_not_called()
|
|
|
|
# --- Per-turn author (stashed by build_turn_context) -----------------
|
|
|
|
def test_stashed_bot_author_reaches_sync_all(self):
|
|
agent = _bare_agent()
|
|
agent._turn_author = {"id": "bot:alpha", "name": "Alpha", "is_bot": True}
|
|
|
|
agent._sync_external_memory_for_turn(
|
|
original_user_message="Message from Alpha: status?", final_response="All green.", interrupted=False,
|
|
)
|
|
|
|
kwargs = agent._memory_manager.sync_all.call_args.kwargs
|
|
assert kwargs["turn_author"] == {"id": "bot:alpha", "name": "Alpha", "is_bot": True}
|
|
assert kwargs["session_id"] == "test_session_001"
|
|
|
|
@pytest.mark.parametrize("stash", ["human turn", "no stash yet"])
|
|
def test_human_turn_or_agent_without_stash_sends_no_author_keyword(self, stash):
|
|
"""A bare agent built before any turn has no stash; the sync must not depend on it."""
|
|
agent = _bare_agent()
|
|
if stash == "human turn":
|
|
agent._turn_author = None
|
|
|
|
agent._sync_external_memory_for_turn(
|
|
original_user_message="status?", final_response="All green.", interrupted=False,
|
|
)
|
|
|
|
agent._memory_manager.sync_all.assert_called_once()
|
|
assert "turn_author" not in agent._memory_manager.sync_all.call_args.kwargs
|
|
|
|
# --- Normal completed turn still syncs ------------------------------
|
|
|
|
|
|
|
|
|
|
# --- Edge cases (pre-existing behaviour preserved) ------------------
|
|
|
|
|
|
|
|
|
|
# --- Exception safety ----------------------------------------------
|
|
|
|
|
|
|
|
# --- Multimodal content flattening ----------------------------------
|
|
|
|
|
|
|
|
|
|
# --- The specific matrix the reporter asked about ------------------
|
|
|