713a983e4a
Hermes now pins its toolchain to Node 26 everywhere. Every path that installs, accepts, heals, or upgrades a Node runtime moves from the old 22-default / `^20.19 || >=22.12` floor to a single rule: Node >=26. Installers: - scripts/install.sh — NODE_VERSION=26; node_satisfies_build() collapses the two-branch Vite floor to `major >= 26`; user-facing messages updated. - scripts/install.ps1 — $NodeVersion=26; Test-NodeVersionOk likewise; winget fallback switches OpenJS.NodeJS.LTS -> OpenJS.NodeJS (26 is Current, not LTS — the LTS manifest would reinstall a too-old Node). - Dockerfile — node_source stage node:22-bookworm-slim -> node:26 (digest pinned, amd64 sha256:9e6f...bf73). - nix/ was already on nodejs_26 (lib.nix, npm-12-0-2.nix); the checks.nix wrapper check ratchets from `>= 20` to `>= 26`. Heal/upgrade paths: - scripts/lib/node-bootstrap.sh — HERMES_NODE_TARGET_MAJOR default 22->26 and HERMES_NODE_MIN_VERSION default 20->26, so heal_managed_node, _nb_install_bundled_node, and the fnm/proto/nvm/brew rungs all target 26 and stop accepting an on-PATH Node below it. Both remain env-overridable. - hermes_constants.py — _HERMES_NODE_TARGET_MAJOR fallback 22->26, which drives the Windows heal path's latest-v26.x download. Version gates: - package.json engines.node >=20 -> >=26; apps/desktop engines `^20.19.0 || >=22.12.0` -> `>=26.0.0`. - CI setup-node: all five workflows 22 -> 26. - Docs describing Hermes's own toolchain updated (windows-native, docker, acp, nix-setup, contributing). Skill docs describing third-party tools' own requirements are untouched. Termux still installs via `pkg install nodejs` best-effort (nodejs.org ships no Android tarballs); that path was never version-gated. Verified: bash -n on both shell scripts, PowerShell AST parse of install.ps1, latest-v26.x index resolves (node-v26.5.1), and the install test suite — 18 tests across the 5 install/runtime test files — passes.
80 lines
2.5 KiB
YAML
80 lines
2.5 KiB
YAML
# .github/workflows/js-tests.yml
|
|
name: JS Tests
|
|
|
|
on:
|
|
workflow_call:
|
|
|
|
jobs:
|
|
workspaces:
|
|
name: List npm workspaces
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
outputs:
|
|
checks: ${{ steps.set-matrix.outputs.checks }}
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
|
with:
|
|
node-version: 26
|
|
cache: npm
|
|
|
|
- name: grab npm 12
|
|
run: |
|
|
npm i -g npm@12
|
|
|
|
- uses: ./.github/actions/retry
|
|
with:
|
|
command: npm ci --ignore-scripts
|
|
- id: set-matrix
|
|
run: |
|
|
node -e '
|
|
const { execSync } = require("child_process");
|
|
const pkgs = JSON.parse(execSync("npm query .workspace", { encoding: "utf-8" }));
|
|
if (pkgs.length === 0) {
|
|
console.error("::error::Workspace discovery produced an empty package list — refusing to emit a zero-length matrix (would skip all JS/TS checks silently).");
|
|
process.exit(1);
|
|
}
|
|
const checks = [];
|
|
for (const pkg of pkgs) {
|
|
const scripts = pkg.scripts || {};
|
|
const subs = Object.keys(scripts).filter(s => /^check:.+$/.test(s));
|
|
if (subs.length > 0) {
|
|
for (const script of subs) {
|
|
checks.push({ package: pkg.location, script });
|
|
}
|
|
} else if (scripts.check) {
|
|
checks.push({ package: pkg.location, script: "check" });
|
|
}
|
|
}
|
|
if (checks.length === 0) {
|
|
console.error("::error::No check scripts found in any workspace package.");
|
|
process.exit(1);
|
|
}
|
|
process.stdout.write("checks=" + JSON.stringify(checks) + "\n");
|
|
' >> "$GITHUB_OUTPUT"
|
|
|
|
check:
|
|
name: ${{ matrix.package }} / ${{ matrix.script }}
|
|
needs: workspaces
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
strategy:
|
|
matrix:
|
|
include: ${{ fromJson(needs.workspaces.outputs.checks) }}
|
|
fail-fast: false # report all failures, not just the first one
|
|
steps:
|
|
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
|
|
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
|
|
with:
|
|
node-version: 26
|
|
cache: npm
|
|
|
|
- name: grab npm 12
|
|
run: |
|
|
npm i -g npm@12
|
|
|
|
- uses: ./.github/actions/retry
|
|
with:
|
|
command: npm ci
|
|
- run: npm run --prefix ${{ matrix.package }} ${{ matrix.script }}
|