a994f7e690
A failure of the check itself (no Node, no VM module API) must never be reported as a broken renderer chunk; assert the kind, not just the text.
39 lines
2.2 KiB
JavaScript
39 lines
2.2 KiB
JavaScript
import { execFileSync, spawnSync } from 'node:child_process'
|
|
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { fileURLToPath } from 'node:url'
|
|
import { expect, test } from 'vitest'
|
|
|
|
const checker = new URL('../apps/desktop/scripts/assert-dist-built.mjs', import.meta.url).href
|
|
const parser = fileURLToPath(new URL('../apps/desktop/scripts/check-chunks-parse.mjs', import.meta.url))
|
|
|
|
test('renderer syntax checks use the running Node without PATH and preserve explicit NODE', () => {
|
|
const root = mkdtempSync(join(tmpdir(), 'renderer check with spaces-'))
|
|
const asset = join(root, 'assets', 'index-fixture.js')
|
|
mkdirSync(join(root, 'assets'))
|
|
writeFileSync(join(root, 'index.html'), '<!doctype html>')
|
|
const env = Object.fromEntries(Object.entries(process.env)
|
|
.filter(([key]) => !['PATH', 'NODE'].includes(key.toUpperCase())))
|
|
const check = (node) => JSON.parse(execFileSync(process.execPath, [
|
|
'--input-type=module', '-e',
|
|
`import { checkDistBuilt } from ${JSON.stringify(checker)}; console.log(JSON.stringify(checkDistBuilt(process.argv[1])))`,
|
|
root,
|
|
], { cwd: root, env: { ...env, PATH: '', ...(node ? { NODE: node } : {}) }, encoding: 'utf8' }))
|
|
try {
|
|
// Parsing must not evaluate the renderer, even when its code would throw.
|
|
writeFileSync(asset, 'export const value = 1; throw new Error("do not execute")')
|
|
expect(check()).toEqual({ ok: true })
|
|
expect(check(process.execPath)).toEqual({ ok: true })
|
|
// Without the VM module API the CHECK failed, not the bundle: never blame a valid chunk.
|
|
const noVm = spawnSync(process.execPath, [parser, join(root, 'assets')], { encoding: 'utf8' })
|
|
expect(JSON.parse(noVm.stdout.trim().split('\n').at(-1))).toMatchObject({ ok: false, kind: 'harness' })
|
|
writeFileSync(asset, 'export const = ;')
|
|
expect(check()).toMatchObject({ ok: false, kind: 'bundle', error: expect.stringContaining('not valid ES module syntax') })
|
|
const missingNode = join(root, 'missing-node')
|
|
expect(check(missingNode)).toMatchObject({ ok: false, kind: 'harness', error: expect.stringContaining('could not run node') })
|
|
} finally {
|
|
rmSync(root, { recursive: true, force: true })
|
|
}
|
|
}, 120_000)
|