d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
70 lines
2.3 KiB
Python
70 lines
2.3 KiB
Python
"""Tests for the per-plugin durable storage convention (plugins/plugin_storage).
|
|
|
|
The contract under test: data lives under ``<hermes home>/plugin-data/<name>/``
|
|
(NOT the ``plugins/<name>/`` install tree), names that could escape the root
|
|
are rejected, and the sqlite helper opens a WAL-mode connection inside the
|
|
data dir.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
|
|
from plugins.plugin_storage import plugin_data_dir, plugin_db
|
|
|
|
|
|
@pytest.fixture
|
|
def hermes_home(tmp_path):
|
|
token = set_hermes_home_override(str(tmp_path))
|
|
try:
|
|
yield tmp_path
|
|
finally:
|
|
reset_hermes_home_override(token)
|
|
|
|
|
|
def test_data_dir_lives_outside_the_install_tree(hermes_home):
|
|
root = plugin_data_dir("my-plugin")
|
|
|
|
assert root == hermes_home / "plugin-data" / "my-plugin"
|
|
assert root.is_dir()
|
|
# The invariant that motivated the module: data must not live under the
|
|
# install tree that `hermes plugins remove` deletes.
|
|
assert (hermes_home / "plugins") not in root.parents
|
|
|
|
|
|
def test_data_dir_is_stable_across_calls(hermes_home):
|
|
assert plugin_data_dir("p") == plugin_data_dir("p")
|
|
|
|
|
|
@pytest.mark.parametrize("bad", ["", ".", "..", "../escape", "a/b", "a\\b", "x" * 65])
|
|
def test_hostile_names_are_rejected(hermes_home, bad):
|
|
with pytest.raises(ValueError):
|
|
plugin_data_dir(bad)
|
|
|
|
|
|
def test_plugin_db_journal_mode_is_the_shared_fallback_verdict(hermes_home):
|
|
"""Plugin DBs take the journal mode the core WAL helper decides for this SQLite build and
|
|
filesystem (WAL normally; DELETE on WAL-reset-bug builds or network FS) — never a raw PRAGMA."""
|
|
from hermes_state_wal import is_sqlite_wal_reset_vulnerable
|
|
|
|
conn = plugin_db("board")
|
|
try:
|
|
conn.execute("CREATE TABLE t (x)")
|
|
conn.execute("INSERT INTO t VALUES (1)")
|
|
conn.commit()
|
|
|
|
mode = conn.execute("PRAGMA journal_mode").fetchone()[0]
|
|
assert mode == ("delete" if is_sqlite_wal_reset_vulnerable() else "wal")
|
|
finally:
|
|
conn.close()
|
|
|
|
assert (hermes_home / "plugin-data" / "board" / "data.db").exists()
|
|
|
|
|
|
def test_plugin_db_rejects_path_shaped_filenames(hermes_home):
|
|
with pytest.raises(ValueError):
|
|
plugin_db("board", filename="../outside.db")
|
|
with pytest.raises(ValueError):
|
|
plugin_db("board", filename="")
|