d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
102 lines
4.4 KiB
Python
102 lines
4.4 KiB
Python
"""Tests for /tools slash command handler in the interactive CLI."""
|
|
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli(enabled_toolsets=None):
|
|
"""Build a minimal HermesCLI stub without running __init__."""
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj.enabled_toolsets = set(enabled_toolsets or ["web", "memory"])
|
|
cli_obj._command_running = False
|
|
cli_obj.console = MagicMock()
|
|
return cli_obj
|
|
|
|
|
|
# ── /tools (no subcommand) ──────────────────────────────────────────────────
|
|
|
|
|
|
class TestToolsSlashNoSubcommand:
|
|
|
|
def test_bare_tools_shows_tool_list(self):
|
|
cli_obj = _make_cli()
|
|
with patch.object(cli_obj, "show_tools") as mock_show:
|
|
cli_obj._handle_tools_command("/tools")
|
|
mock_show.assert_called_once()
|
|
|
|
|
|
|
|
# ── /tools list ─────────────────────────────────────────────────────────────
|
|
|
|
|
|
class TestToolsSlashList:
|
|
|
|
def test_list_calls_backend(self, capsys):
|
|
cli_obj = _make_cli()
|
|
with patch("hermes_cli.tools_config.load_config",
|
|
return_value={"platform_toolsets": {"cli": ["web"]}}), \
|
|
patch("hermes_cli.tools_config.save_config"):
|
|
cli_obj._handle_tools_command("/tools list")
|
|
out = capsys.readouterr().out
|
|
assert "web" in out
|
|
|
|
|
|
|
|
# ── /tools disable (session reset) ──────────────────────────────────────────
|
|
|
|
|
|
class TestToolsSlashDisableWithReset:
|
|
|
|
def test_disable_applies_directly_and_resets_session(self):
|
|
"""Disable applies immediately (no confirmation prompt) and resets session."""
|
|
cli_obj = _make_cli(["web", "memory"])
|
|
with patch("hermes_cli.tools_config.load_config",
|
|
return_value={"platform_toolsets": {"cli": ["web", "memory"]}}), \
|
|
patch("hermes_cli.tools_config.save_config"), \
|
|
patch("hermes_cli.tools_config._get_platform_tools", return_value={"memory"}), \
|
|
patch("hermes_cli.config.load_config", return_value={}), \
|
|
patch.object(cli_obj, "new_session") as mock_reset:
|
|
cli_obj._handle_tools_command("/tools disable web")
|
|
mock_reset.assert_called_once()
|
|
assert "web" not in cli_obj.enabled_toolsets
|
|
|
|
|
|
def test_disable_always_resets_session(self):
|
|
"""Even without a confirmation prompt, disable always resets the session."""
|
|
cli_obj = _make_cli(["web", "memory"])
|
|
with patch("hermes_cli.tools_config.load_config",
|
|
return_value={"platform_toolsets": {"cli": ["web", "memory"]}}), \
|
|
patch("hermes_cli.tools_config.save_config"), \
|
|
patch("hermes_cli.tools_config._get_platform_tools", return_value={"memory"}), \
|
|
patch("hermes_cli.config.load_config", return_value={}), \
|
|
patch.object(cli_obj, "new_session") as mock_reset:
|
|
cli_obj._handle_tools_command("/tools disable web")
|
|
mock_reset.assert_called_once()
|
|
|
|
|
|
|
|
# ── /tools enable (session reset) ───────────────────────────────────────────
|
|
|
|
|
|
class TestToolsSlashEnableWithReset:
|
|
|
|
def test_enable_applies_directly_and_resets_session(self):
|
|
"""Enable applies immediately (no confirmation prompt) and resets session."""
|
|
cli_obj = _make_cli(["memory"])
|
|
with patch("hermes_cli.tools_config.load_config",
|
|
return_value={"platform_toolsets": {"cli": ["memory"]}}), \
|
|
patch("hermes_cli.tools_config.save_config"), \
|
|
patch("hermes_cli.tools_config._get_platform_tools", return_value={"memory", "web"}), \
|
|
patch("hermes_cli.config.load_config", return_value={}), \
|
|
patch.object(cli_obj, "new_session") as mock_reset:
|
|
cli_obj._handle_tools_command("/tools enable web")
|
|
mock_reset.assert_called_once()
|
|
assert "web" in cli_obj.enabled_toolsets
|
|
|
|
def test_enable_missing_name_prints_usage(self, capsys):
|
|
cli_obj = _make_cli()
|
|
cli_obj._handle_tools_command("/tools enable")
|
|
out = capsys.readouterr().out
|
|
assert "Usage" in out
|