244d296646
Personality persistence used to be split per surface: the TUI/desktop wrote the NAME to display.personality while the CLI/gateway wrote rendered TEXT into agent.system_prompt (and their /personality none only blanked the text, leaving the name behind). When #81946 made display.personality authoritative everywhere, stale names written long ago resurrected personalities users had turned off - kawaii defaulting on after updating. - hermes_cli/personality.py: new single owner of personality state. Built-in personality definitions, neutral-name normalization, rendering, availability (built-ins overlaid by agent.personalities), overlay resolution, and the ONLY sanctioned persistence path (persist_personality -> display.personality; never agent.system_prompt). - v34 config migration: one-time reset of display.personality to none (announcing which personality was cleared and how to re-enable), plus a scrub of agent.system_prompt when it verbatim-equals a known personality render (machine-written by the old CLI/gateway). Hand-written manual prompts are never touched. - All surfaces rewired through the module: CLI /personality (incl. active marker in the list), gateway /personality, TUI config.set + slash path (which previously applied without persisting), TUI config.get (reports the EFFECTIVE personality), completer, hermes config display, and the tui_gateway health probe. - cli.py/config duplicates removed: built-ins now defined once; the desktop mirrors them from one lib module (src/lib/personalities.ts). - Docs updated: selection lives in display.personality, built-ins always available, one-time reset note.
240 lines
9.3 KiB
Python
240 lines
9.3 KiB
Python
"""Tests for /personality none — clearing personality overlay.
|
|
|
|
Updated for the single-owner unification (hermes_cli.personality): built-ins
|
|
always exist, resolution reads config (agent.personalities overlays), and
|
|
persistence flows exclusively through persist_personality().
|
|
"""
|
|
import os
|
|
import pytest
|
|
from unittest.mock import MagicMock, patch
|
|
import yaml
|
|
|
|
|
|
# ── CLI tests ──────────────────────────────────────────────────────────────
|
|
|
|
class TestCLIPersonalityNone:
|
|
|
|
def _make_cli(self, personalities=None):
|
|
from cli import HermesCLI
|
|
from hermes_cli.personality import available_personalities
|
|
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
user = personalities or {
|
|
"helpful": "You are helpful.",
|
|
"concise": "You are concise.",
|
|
}
|
|
cli.config = {"agent": {"personalities": user}}
|
|
cli.personalities = available_personalities(cli.config)
|
|
cli.system_prompt = "You are kawaii~"
|
|
cli.agent = MagicMock()
|
|
cli.console = MagicMock()
|
|
return cli
|
|
|
|
def test_set_persists_display_personality_not_system_prompt(self):
|
|
cli = self._make_cli()
|
|
saves = []
|
|
|
|
def _persist(name):
|
|
saves.append(("display.personality", name))
|
|
return True
|
|
|
|
with patch("hermes_cli.personality.persist_personality", side_effect=_persist):
|
|
cli._handle_personality_command("/personality helpful")
|
|
|
|
assert cli.system_prompt == "You are helpful."
|
|
assert ("display.personality", "helpful") in saves
|
|
assert not any(k == "agent.system_prompt" for k, _ in saves)
|
|
|
|
def test_neutral_restores_manual_system_prompt_without_wiping_config(self):
|
|
cli = self._make_cli()
|
|
saves = []
|
|
|
|
def _persist(name):
|
|
saves.append(("display.personality", name))
|
|
return True
|
|
|
|
with (
|
|
patch("hermes_cli.personality.persist_personality", side_effect=_persist),
|
|
patch(
|
|
"hermes_cli.config.read_raw_config",
|
|
return_value={"agent": {"system_prompt": "manual forever"}},
|
|
),
|
|
):
|
|
cli._handle_personality_command("/personality neutral")
|
|
|
|
assert cli.system_prompt == "manual forever"
|
|
assert ("display.personality", "") in saves
|
|
assert not any(k == "agent.system_prompt" for k, _ in saves)
|
|
|
|
def test_builtin_personality_works_without_config_entry(self):
|
|
# Built-ins come from hermes_cli.personality, not from config.
|
|
cli = self._make_cli(personalities={})
|
|
with patch("hermes_cli.personality.persist_personality", return_value=True):
|
|
cli._handle_personality_command("/personality kawaii")
|
|
assert "kawaii" in cli.system_prompt.lower()
|
|
|
|
|
|
# ── Gateway tests ──────────────────────────────────────────────────────────
|
|
|
|
class TestGatewayPersonalityNone:
|
|
|
|
def _make_event(self, args=""):
|
|
event = MagicMock()
|
|
event.get_command.return_value = "personality"
|
|
event.get_command_args.return_value = args
|
|
return event
|
|
|
|
def _make_runner(self, personalities=None):
|
|
from gateway.run import GatewayRunner
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner._ephemeral_system_prompt = "You are kawaii~"
|
|
runner.config = {
|
|
"agent": {
|
|
"personalities": personalities or {"helpful": "You are helpful."}
|
|
}
|
|
}
|
|
return runner
|
|
|
|
def _gateway_env(self, tmp_path):
|
|
# The gateway reads via _load_gateway_config (rooted at
|
|
# gateway.run._hermes_home) and persists via persist_personality
|
|
# (rooted at HERMES_HOME) — point both at the same tmp dir.
|
|
return (
|
|
patch("gateway.run._hermes_home", tmp_path),
|
|
patch.dict(os.environ, {"HERMES_HOME": str(tmp_path)}),
|
|
)
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_default_clears_ephemeral_prompt(self, tmp_path):
|
|
runner = self._make_runner()
|
|
config_data = {
|
|
"agent": {
|
|
"system_prompt": "manual forever",
|
|
"personalities": {"helpful": "You are helpful."},
|
|
},
|
|
"display": {"personality": "helpful"},
|
|
}
|
|
config_file = tmp_path / "config.yaml"
|
|
config_file.write_text(yaml.dump(config_data))
|
|
|
|
p1, p2 = self._gateway_env(tmp_path)
|
|
with p1, p2:
|
|
event = self._make_event("default")
|
|
result = await runner._handle_personality_command(event)
|
|
|
|
saved = yaml.safe_load(config_file.read_text())
|
|
assert saved["agent"]["system_prompt"] == "manual forever"
|
|
assert saved.get("display", {}).get("personality", None) == ""
|
|
assert runner._ephemeral_system_prompt == "manual forever"
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_set_persists_display_personality_not_system_prompt(self, tmp_path):
|
|
runner = self._make_runner()
|
|
config_data = {
|
|
"agent": {
|
|
"system_prompt": "manual forever",
|
|
"personalities": {"helpful": "You are helpful."},
|
|
}
|
|
}
|
|
config_file = tmp_path / "config.yaml"
|
|
config_file.write_text(yaml.dump(config_data))
|
|
|
|
p1, p2 = self._gateway_env(tmp_path)
|
|
with p1, p2:
|
|
event = self._make_event("helpful")
|
|
result = await runner._handle_personality_command(event)
|
|
|
|
saved = yaml.safe_load(config_file.read_text())
|
|
assert saved["agent"]["system_prompt"] == "manual forever"
|
|
assert saved["display"]["personality"] == "helpful"
|
|
assert runner._ephemeral_system_prompt == "You are helpful."
|
|
assert "helpful" in result.lower()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_unknown_shows_none_in_available(self, tmp_path):
|
|
runner = self._make_runner()
|
|
config_data = {"agent": {"personalities": {"helpful": "You are helpful."}}}
|
|
config_file = tmp_path / "config.yaml"
|
|
config_file.write_text(yaml.dump(config_data))
|
|
|
|
p1, p2 = self._gateway_env(tmp_path)
|
|
with p1, p2:
|
|
event = self._make_event("nonexistent")
|
|
result = await runner._handle_personality_command(event)
|
|
|
|
assert "none" in result.lower()
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_empty_personality_list_still_lists_builtins(self, tmp_path):
|
|
# Built-ins are always available — an empty agent.personalities no
|
|
# longer means "no personalities configured".
|
|
runner = self._make_runner(personalities={})
|
|
(tmp_path / "config.yaml").write_text(yaml.dump({"agent": {"personalities": {}}}))
|
|
|
|
p1, p2 = self._gateway_env(tmp_path)
|
|
with p1, p2:
|
|
event = self._make_event("")
|
|
result = await runner._handle_personality_command(event)
|
|
|
|
assert "kawaii" in result.lower()
|
|
assert "pirate" in result.lower()
|
|
|
|
|
|
class TestPersonalityDictFormat:
|
|
"""Test dict-format custom personalities with description, tone, style."""
|
|
|
|
def _make_cli(self, personalities):
|
|
from cli import HermesCLI
|
|
from hermes_cli.personality import available_personalities
|
|
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
cli.config = {"agent": {"personalities": personalities}}
|
|
cli.personalities = available_personalities(cli.config)
|
|
cli.system_prompt = ""
|
|
cli.agent = None
|
|
cli.console = MagicMock()
|
|
return cli
|
|
|
|
def test_dict_personality_uses_system_prompt(self):
|
|
cli = self._make_cli({
|
|
"coder": {
|
|
"description": "Expert programmer",
|
|
"system_prompt": "You are an expert programmer.",
|
|
"tone": "technical",
|
|
"style": "concise",
|
|
}
|
|
})
|
|
with patch("hermes_cli.personality.persist_personality", return_value=True):
|
|
cli._handle_personality_command("/personality coder")
|
|
assert "You are an expert programmer." in cli.system_prompt
|
|
|
|
def test_dict_personality_includes_style(self):
|
|
cli = self._make_cli({
|
|
"coder": {
|
|
"system_prompt": "You are an expert programmer.",
|
|
"style": "use code examples",
|
|
}
|
|
})
|
|
with patch("hermes_cli.personality.persist_personality", return_value=True):
|
|
cli._handle_personality_command("/personality coder")
|
|
assert "Style: use code examples" in cli.system_prompt
|
|
|
|
def test_string_personality_still_works(self):
|
|
cli = self._make_cli({"helper": "You are helpful."})
|
|
with patch("hermes_cli.personality.persist_personality", return_value=True):
|
|
cli._handle_personality_command("/personality helper")
|
|
assert cli.system_prompt == "You are helpful."
|
|
|
|
def test_resolve_prompt_dict_no_tone_no_style(self):
|
|
from cli import HermesCLI
|
|
result = HermesCLI._resolve_personality_prompt({
|
|
"description": "A helper",
|
|
"system_prompt": "You are helpful.",
|
|
})
|
|
assert result == "You are helpful."
|
|
|
|
def test_resolve_prompt_string(self):
|
|
from cli import HermesCLI
|
|
result = HermesCLI._resolve_personality_prompt("You are helpful.")
|
|
assert result == "You are helpful."
|