5c215ffa21
The onboarding card needs to list catalog plugins beside the hosted connectors (NS-960 D1, D4) and grey a plugin whose app is absent (D5). The catalog had no curated flag, and the manage_catalog row left app_state empty. - `onboarding: true` and `title` on catalog entries (loader, validator, docs); set on blender, nvidia-app and nvidia-broadcast. - hermes_cli/plugin_catalog_presence.py reads the plugin.json at the catalog's pinned commit once per pin and judges its app declaration with the hermes_platform resolver the installer and the Plugins-tab pill use. No declaration or an unreadable one is `unknown`, never `present`. - `plugins.manage action=onboarding` lists the curated entries this OS runs (platform mismatch is the only exclusion) with app_state and the sentence the card greys the row with. - manage_catalog plugin rows now carry app_state and the catalog title. - A live entry that differs from the in-tree entry at the same pin (new metadata) now follows the same newer-catalog rule as a new pin, so a checkout that adds `onboarding` is not masked by a published doc that predates it.
48 lines
2.5 KiB
Python
48 lines
2.5 KiB
Python
"""The onboarding card's catalog plugins: curated flag, platform filter, and the pinned app declaration."""
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import plugin_catalog as pc
|
|
from hermes_cli import plugin_catalog_presence as presence_mod
|
|
|
|
SHA = "0" * 40
|
|
NEEDS_APP = {"extensions": {"com.nousresearch.hermes": {"servers": {"srv": {
|
|
"app": {"darwin": {"presence": "executable", "location": "/nonexistent/fx-app"},
|
|
"linux": {"presence": "executable", "location": "/nonexistent/fx-app"},
|
|
"win32": {"presence": "executable", "location": "C:/nonexistent/fx-app.exe"}},
|
|
"requires": {"app": True}}}}}}
|
|
|
|
|
|
def _entry(name, *, onboarding=True, platforms=(), title=""):
|
|
return pc.entry_from_mapping({"name": name, "repo": f"https://github.com/fx/{name}", "sha": SHA,
|
|
"description": f"{name} does things. More.", "maintainer": "fx",
|
|
"tier": "official", "category": "tools", "platforms": list(platforms),
|
|
"onboarding": onboarding, "title": title}, name)
|
|
|
|
|
|
@pytest.fixture
|
|
def catalog(monkeypatch):
|
|
from hermes_platform.host import facts
|
|
|
|
here = {"darwin": "macos", "win32": "windows"}.get(facts.os_family(), "linux")
|
|
other = "windows" if here != "windows" else "macos"
|
|
entries = [_entry("everywhere", title="Everywhere App"), _entry("not-curated", onboarding=False),
|
|
_entry("here-only", platforms=[here]), _entry("elsewhere", platforms=[other])]
|
|
monkeypatch.setattr(pc, "load_catalog_live", lambda: entries)
|
|
manifests = {"everywhere": NEEDS_APP, "here-only": {"name": "here-only"}}
|
|
monkeypatch.setattr(presence_mod, "_pinned_manifest", lambda repo, sha, subdir: manifests.get(repo.rsplit("/", 1)[-1]))
|
|
return entries
|
|
|
|
|
|
def test_onboarding_rows_are_curated_entries_this_os_runs(catalog):
|
|
rows = {r["name"]: r for r in presence_mod.onboarding_entries()}
|
|
assert set(rows) == {"everywhere", "here-only"}
|
|
assert rows["everywhere"]["title"] == "Everywhere App" and rows["here-only"]["title"] == "here-only"
|
|
|
|
|
|
def test_app_state_comes_from_the_pinned_declaration(catalog):
|
|
rows = {r["name"]: r for r in presence_mod.onboarding_entries()}
|
|
# A declared app that is absent greys the row with a reason; no declaration is unknown, never "present".
|
|
assert rows["everywhere"]["app_state"] == "missing_app" and "Everywhere App" in rows["everywhere"]["sentence"]
|
|
assert rows["here-only"]["app_state"] == "unknown" and rows["here-only"]["sentence"] == ""
|