d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
98 lines
4.5 KiB
Python
98 lines
4.5 KiB
Python
"""Parity guard for the slash-command dispatch table in cli.HermesCLI.
|
|
|
|
Every canonical command that had a branch in the old if/elif chain must
|
|
resolve to a handler in ``_SLASH_DISPATCH``, and the pre-dispatch side effects
|
|
(pre_command hook, pending-resume reset, unknown-command fallthrough) must
|
|
keep their old semantics.
|
|
"""
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from cli import HermesCLI
|
|
|
|
# Command names that had an explicit branch in the pre-dispatch-table chain.
|
|
OLD_CHAIN_COMMANDS = [
|
|
"exit", "quit", "help", "palette", "whoami", "profile", "tools", "toolsets",
|
|
"config", "redraw", "clear", "history", "title", "handoff", "new", "resume",
|
|
"sessions", "model", "codex-runtime", "personality", "pet", "hatch", "retry",
|
|
"prompt", "undo", "branch", "worktree", "save", "cron", "suggestions",
|
|
"blueprint", "curator", "kanban", "skills", "learn", "init", "memory",
|
|
"platforms", "status", "context", "egress", "statusbar", "diff", "battery",
|
|
"timestamps", "verbose", "focus", "footer", "yolo", "approvals", "reasoning",
|
|
"fast", "compress", "usage", "subscription", "topup", "insights", "copy",
|
|
"debug", "update", "version", "paste", "image", "reload", "reload-mcp",
|
|
"reload-skills", "bundles", "browser", "plugins", "rollback", "snapshot",
|
|
"export", "import", "stop", "agents", "journey", "bg", "btw", "queue",
|
|
"steer", "goal", "heartbeat", "refine", "review", "loop", "plan", "moa",
|
|
"subgoal", "skin", "voice", "wake", "busy", "indicator",
|
|
]
|
|
|
|
|
|
def test_every_old_branch_resolves_to_a_handler():
|
|
for name in OLD_CHAIN_COMMANDS:
|
|
entry = HermesCLI._slash_handler(name)
|
|
assert entry is not None, name
|
|
method_name, pass_arg = entry
|
|
assert callable(getattr(HermesCLI, method_name)), name
|
|
assert isinstance(pass_arg, bool)
|
|
# explicit table entries are only the ones the naming convention can't cover
|
|
for name, (method_name, pass_arg) in HermesCLI._SLASH_DISPATCH.items():
|
|
assert name in OLD_CHAIN_COMMANDS
|
|
assert (method_name, pass_arg) != (f"_handle_{name.replace('-', '_')}_command", True), name
|
|
|
|
|
|
def test_registry_names_resolve_into_the_table():
|
|
from hermes_cli.commands import COMMAND_REGISTRY, resolve_command
|
|
|
|
for name in HermesCLI._SLASH_DISPATCH:
|
|
cmd = resolve_command(name)
|
|
assert cmd is not None and HermesCLI._slash_handler(cmd.name) is not None, name
|
|
# registry commands the CLI never handled inline must still fall through
|
|
dispatched = {c.name for c in COMMAND_REGISTRY if HermesCLI._slash_handler(c.name)}
|
|
# /login has no old branch; it resolves through the naming-convention fallback.
|
|
assert dispatched == set(OLD_CHAIN_COMMANDS) - {"exit"} | {"quit", "login"}
|
|
|
|
|
|
def _cli():
|
|
c = HermesCLI.__new__(HermesCLI)
|
|
c._pending_resume_sessions = ["x"]
|
|
c.session_id = "s1"
|
|
c.config = {}
|
|
return c
|
|
|
|
|
|
def test_dispatch_return_semantics_and_side_effects():
|
|
c = _cli()
|
|
with patch.object(HermesCLI, "_toggle_yolo", return_value=None) as m, \
|
|
patch("hermes_cli.plugins.fire_pre_command_hook") as hook:
|
|
assert c.process_command("/yolo") is True
|
|
m.assert_called_once_with()
|
|
hook.assert_called_once()
|
|
assert hook.call_args.kwargs["command"] == "yolo"
|
|
assert c._pending_resume_sessions is None # non-resume command disarms it
|
|
|
|
c = _cli()
|
|
with patch.object(HermesCLI, "_handle_resume_command") as m:
|
|
assert c.process_command("/resume 2") is True
|
|
m.assert_called_once_with("/resume 2")
|
|
assert c._pending_resume_sessions == ["x"]
|
|
|
|
c = _cli()
|
|
assert c.process_command("/exit") is False
|
|
c = _cli()
|
|
with patch.object(HermesCLI, "_handle_handoff_command", return_value=False):
|
|
assert c.process_command("/handoff telegram") is False
|
|
with patch.object(HermesCLI, "_handle_handoff_command", return_value=True):
|
|
assert c.process_command("/handoff telegram") is True
|
|
with patch.object(HermesCLI, "_handle_update_command", return_value=True):
|
|
assert c.process_command("/update") is False
|
|
with patch.object(HermesCLI, "_handle_update_command", return_value=False):
|
|
assert c.process_command("/update") is True
|
|
|
|
|
|
def test_unknown_command_falls_through():
|
|
c = _cli()
|
|
c._console_print = MagicMock()
|
|
with patch.object(HermesCLI, "_process_unregistered_slash", return_value=True) as m:
|
|
assert c.process_command("/definitely-not-a-command x") is True
|
|
m.assert_called_once_with("/definitely-not-a-command x", "/definitely-not-a-command x")
|