d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
102 lines
4.0 KiB
Python
102 lines
4.0 KiB
Python
"""Tests for /help declutter + Ctrl+P command palette (C-04 / C-05)."""
|
|
|
|
from types import SimpleNamespace
|
|
|
|
from cli import HermesCLI
|
|
from hermes_cli.commands import HELP_SESSION_SUBGROUPS
|
|
|
|
|
|
def _bare_cli():
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
return cli
|
|
|
|
|
|
class TestHelpSubgroups:
|
|
def test_session_subgroups_defined(self):
|
|
# The oversized Session category is split into readable sub-headers.
|
|
assert "Context" in HELP_SESSION_SUBGROUPS
|
|
assert "Background & Automation" in HELP_SESSION_SUBGROUPS
|
|
# Representative members land in the right buckets.
|
|
assert "compress" in HELP_SESSION_SUBGROUPS["Context"]
|
|
assert "goal" in HELP_SESSION_SUBGROUPS["Background & Automation"]
|
|
|
|
|
|
class TestCommandPaletteFilter:
|
|
def _state(self, entries, query):
|
|
cli = _bare_cli()
|
|
cli._command_palette_state = {
|
|
"entries": entries, "filter": query, "selected": 0, "_scroll_offset": 0,
|
|
}
|
|
return cli
|
|
|
|
ENTRIES = [
|
|
("/model", "Model", "Switch model"),
|
|
("/compress", "Context", "Compress the conversation"),
|
|
("/goal", "Background", "Set an autonomous goal"),
|
|
("/status", "Context", "Show session status"),
|
|
]
|
|
|
|
def test_empty_query_returns_all(self):
|
|
cli = self._state(self.ENTRIES, "")
|
|
assert cli._command_palette_visible_entries() == self.ENTRIES
|
|
|
|
def test_filter_by_command_name(self):
|
|
cli = self._state(self.ENTRIES, "model")
|
|
rows = cli._command_palette_visible_entries()
|
|
assert [r[0] for r in rows] == ["/model"]
|
|
|
|
def test_filter_by_description(self):
|
|
cli = self._state(self.ENTRIES, "autonomous")
|
|
rows = cli._command_palette_visible_entries()
|
|
assert [r[0] for r in rows] == ["/goal"]
|
|
|
|
def test_subsequence_match(self):
|
|
# "cmp" is a subsequence of "/compress"
|
|
cli = self._state(self.ENTRIES, "cmprs")
|
|
rows = cli._command_palette_visible_entries()
|
|
assert "/compress" in [r[0] for r in rows]
|
|
|
|
def test_no_match(self):
|
|
cli = self._state(self.ENTRIES, "zzznope")
|
|
assert cli._command_palette_visible_entries() == []
|
|
|
|
def test_command_name_matches_rank_above_description(self):
|
|
# "status" matches /status by name (rank<=2). A row that only matches
|
|
# in its description must rank strictly after any name match.
|
|
entries = [
|
|
("/goal", "Background", "check the status of things"), # desc-only match
|
|
("/status", "Context", "Show session status"), # name match
|
|
]
|
|
cli = self._state(entries, "status")
|
|
rows = cli._command_palette_visible_entries()
|
|
assert rows[0][0] == "/status" # name match ranks first
|
|
|
|
def test_query_does_not_overmatch_via_description(self):
|
|
# A short query must not match a row solely because its letters appear
|
|
# as a scattered subsequence of the description (the "steer" bug).
|
|
entries = [
|
|
("/new", "Session", "Start a totally separate resettable session"),
|
|
]
|
|
cli = self._state(entries, "steer")
|
|
# "steer" is NOT a subsequence of "/new" and not a substring of the
|
|
# description, so the row is dropped.
|
|
assert cli._command_palette_visible_entries() == []
|
|
|
|
|
|
class TestCommandPaletteSelectionInserts:
|
|
def test_selection_prefills_exact_command(self):
|
|
cli = _bare_cli()
|
|
cli._command_palette_state = {
|
|
"entries": [("/model", "Model", "Switch model")],
|
|
"filter": "", "selected": 0, "_scroll_offset": 0,
|
|
}
|
|
# Fake prompt_toolkit app + buffer.
|
|
buf = SimpleNamespace(text="", cursor_position=0)
|
|
cli._app = SimpleNamespace(current_buffer=buf)
|
|
cli._invalidate = lambda **k: None
|
|
cli._restore_modal_input_snapshot = lambda: None
|
|
cli._handle_command_palette_selection()
|
|
# Exact command string inserted (with trailing space), never executed.
|
|
assert buf.text == "/model "
|
|
assert cli._command_palette_state is None # palette closed
|