arminanton
e2fa509bf3
fix(review): isolate the background-review fork from the canonical session
...
The forked skill/memory review agent shares the parent's session_id for
prompt-cache warmth. Without isolation it wrote its harness turn ('Review the
conversation above and update the skill library…') plus its curator-mode reply
straight into the user's REAL session in state.db; the next live turn re-read
that injected user message as a standing instruction and the agent 'became' the
curator, refusing the actual task.
Root fix: a _persist_disabled flag on the fork that hard-stops every DB write
and lazy-open path (_flush_messages_to_session_db, _ensure_db_session,
_get_session_db_for_recall) — the review writes only to the skill/memory stores
via its tools. Defense-in-depth: _strip_background_review_harness drops any
stray harness message (and the assistant reply that followed) at load time in
get_messages_as_conversation, so an already-polluted session resumes clean.
Salvaged from #50296 .
Co-authored-by: arminanton <29869547+arminanton@users.noreply.github.com >
2026-07-01 16:21:39 +05:30
..
2026-06-30 16:22:18 -07:00
2026-06-30 15:41:44 -05:00
2026-06-08 22:46:57 -07:00
2026-07-01 14:37:22 +05:30
2026-05-28 00:20:11 -07:00
2026-06-12 08:51:10 +00:00
2026-07-01 16:21:39 +05:30
2026-07-01 00:20:32 -07:00
2026-07-01 15:42:15 +05:30
2026-05-15 14:00:01 -07:00
2026-07-01 01:52:06 -07:00
2026-05-18 10:14:38 -07:00
2026-07-01 16:21:39 +05:30
2026-06-15 05:25:17 -07:00
2026-06-19 01:53:32 +05:30
2026-05-17 04:04:15 -07:00
2026-05-29 04:22:27 -07:00
2026-07-01 02:18:56 -07:00
2026-06-17 17:33:32 -07:00
2026-06-21 16:39:02 -07:00
2026-06-30 00:59:59 -05:00
2026-06-29 09:18:10 -04:00
2026-07-01 02:48:32 -07:00
2026-07-01 13:36:50 +05:30
2026-07-01 02:43:49 -07:00
2026-06-30 13:36:29 +05:30
2026-07-01 03:18:41 -07:00
2026-06-28 22:52:51 -07:00
2026-05-25 00:32:08 -07:00
2026-07-01 02:45:07 -07:00
2026-05-26 15:41:11 -07:00
2026-06-12 08:51:10 +00:00
2026-06-17 05:40:05 -07:00
2026-06-28 15:10:21 -07:00
2026-06-29 20:31:17 -07:00
2026-07-01 16:14:16 +05:30
2026-06-13 21:14:32 -07:00
2026-07-01 01:02:35 -07:00
2026-06-30 11:51:22 -07:00
2026-04-28 06:46:45 -07:00
2026-06-03 12:00:27 -07:00
2026-06-18 22:13:07 -07:00
2026-05-13 22:31:28 -07:00
2026-06-28 22:52:59 -07:00
2026-06-07 18:33:20 -07:00
2026-05-16 17:59:32 -07:00
2026-05-28 00:20:11 -07:00
2026-06-30 16:56:01 -07:00
2026-06-30 11:54:16 -05:00
2026-06-30 03:44:41 -05:00
2026-06-30 15:16:21 -05:00
2026-04-28 12:27:36 -07:00
2026-04-30 23:03:54 -07:00
2026-05-11 16:49:13 -07:00
2026-06-25 02:17:29 +05:30
2026-06-21 12:03:46 -07:00
2026-06-19 15:23:41 +08:00
2026-06-25 12:24:34 -05:00
2026-07-01 01:59:00 -07:00
2026-07-01 00:09:42 -07:00
2026-07-01 03:17:48 -07:00
2026-05-27 00:43:32 -07:00
2026-06-13 05:51:41 -07:00
2026-05-08 14:27:40 -07:00
2026-06-07 08:36:48 -07:00
2026-06-23 08:01:50 +00:00
2026-05-10 07:09:28 -07:00
2026-05-12 20:49:20 -07:00
2026-06-27 21:22:49 -07:00
2026-06-28 20:46:32 -07:00
2026-05-12 20:46:04 -07:00
2026-04-13 16:32:04 -07:00
2026-06-25 19:00:48 -07:00
2026-07-01 02:45:22 -07:00
2026-06-27 20:56:49 -07:00
2026-06-25 00:17:17 -07:00
2026-06-02 20:23:09 +00:00
2026-06-19 07:34:15 -07:00
2026-06-30 00:59:29 -05:00
2026-05-18 21:38:05 -07:00
2026-06-16 10:37:37 -07:00
2026-06-28 05:28:45 -07:00
2026-06-25 22:03:02 -07:00
2026-06-13 21:14:32 -07:00
2026-05-28 04:53:27 -07:00
2026-05-25 23:17:33 -07:00
2026-06-22 06:42:30 -07:00
2026-05-05 04:33:38 -07:00
2026-06-25 19:00:48 -07:00
2026-06-30 17:28:33 -07:00
2026-06-19 17:15:52 -07:00
2026-07-01 02:44:09 -07:00
2026-07-01 14:56:52 +05:30
2026-05-19 00:12:12 -07:00
2026-05-13 06:46:23 -07:00
2026-02-21 22:31:43 -08:00
2026-05-25 01:41:19 -07:00
2026-05-25 01:41:19 -07:00
2026-05-24 18:04:54 -07:00
2026-05-24 18:04:54 -07:00
2026-06-30 20:01:16 +05:30
2026-07-01 03:34:49 -07:00
2026-06-28 01:15:21 -07:00
2026-06-30 23:08:37 -07:00
2026-06-24 23:03:45 -05:00
2026-06-30 01:43:08 -05:00
2026-06-30 00:59:29 -05:00
2026-05-13 16:39:41 -07:00
2026-05-13 16:39:41 -07:00
2026-05-28 04:52:42 -07:00
2026-05-28 04:52:42 -07:00