d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
90 lines
2.8 KiB
Python
90 lines
2.8 KiB
Python
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
from cli import (
|
|
HermesCLI,
|
|
_collect_query_images,
|
|
_format_image_attachment_badges,
|
|
_termux_example_image_path,
|
|
)
|
|
|
|
|
|
def _make_cli():
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj._attached_images = []
|
|
return cli_obj
|
|
|
|
|
|
def _make_image(path: Path) -> Path:
|
|
path.parent.mkdir(parents=True, exist_ok=True)
|
|
path.write_bytes(b"\x89PNG\r\n\x1a\n")
|
|
return path
|
|
|
|
|
|
class TestImageCommand:
|
|
def test_handle_image_command_attaches_local_image(self, tmp_path):
|
|
img = _make_image(tmp_path / "photo.png")
|
|
cli_obj = _make_cli()
|
|
|
|
with patch("cli._cprint"):
|
|
cli_obj._handle_image_command(f"/image {img}")
|
|
|
|
assert cli_obj._attached_images == [img]
|
|
|
|
|
|
def test_handle_image_command_rejects_non_image_file(self, tmp_path):
|
|
file_path = tmp_path / "notes.txt"
|
|
file_path.write_text("hello\n", encoding="utf-8")
|
|
cli_obj = _make_cli()
|
|
|
|
with patch("cli._cprint") as mock_print:
|
|
cli_obj._handle_image_command(f"/image {file_path}")
|
|
|
|
assert cli_obj._attached_images == []
|
|
rendered = " ".join(str(arg) for call in mock_print.call_args_list for arg in call.args)
|
|
assert "Not a supported image file" in rendered
|
|
|
|
|
|
class TestCollectQueryImages:
|
|
def test_collect_query_images_accepts_explicit_image_arg(self, tmp_path):
|
|
img = _make_image(tmp_path / "diagram.png")
|
|
|
|
message, images = _collect_query_images("describe this", str(img))
|
|
|
|
assert message == "describe this"
|
|
assert images == [img]
|
|
|
|
|
|
def test_collect_query_images_supports_tilde_paths(self, tmp_path, monkeypatch):
|
|
home = tmp_path / "home"
|
|
img = _make_image(home / "storage" / "shared" / "Pictures" / "cat.png")
|
|
monkeypatch.setenv("HOME", str(home))
|
|
# ntpath.expanduser ignores HOME (Python 3.8+) — it wants USERPROFILE.
|
|
monkeypatch.setenv("USERPROFILE", str(home))
|
|
|
|
message, images = _collect_query_images("describe this", "~/storage/shared/Pictures/cat.png")
|
|
|
|
assert message == "describe this"
|
|
assert images == [img]
|
|
|
|
|
|
class TestTermuxImageHints:
|
|
def test_termux_example_image_path_prefers_real_shared_storage_root(self, monkeypatch):
|
|
existing = {"/sdcard", "/storage/emulated/0"}
|
|
monkeypatch.setattr("cli.os.path.isdir", lambda path: path in existing)
|
|
|
|
hint = _termux_example_image_path()
|
|
|
|
assert hint == "/sdcard/Pictures/cat.png"
|
|
|
|
|
|
class TestImageBadgeFormatting:
|
|
def test_compact_badges_use_filename_on_narrow_terminals(self, tmp_path):
|
|
img = _make_image(tmp_path / "Screenshot 2026-04-09 at 11.22.33 AM.png")
|
|
|
|
badges = _format_image_attachment_badges([img], image_counter=1, width=40)
|
|
|
|
assert badges.startswith("[📎 ")
|
|
assert "Image #1" not in badges
|
|
|