284dbaf537
Activation reaches plugin discovery before the application dependencies exist. Give PM its own locked Python project and runtime so it can install or repair the application without importing that dependency tree. Keep PM outside the application workspace. A shared uv workspace resolves the application graph and cannot provide this isolation. Route mutations through an isolated worker and preserve transaction callbacks, cancellation, custom package registrations, and correlated receipts. Use the same runtime builder for source installs and packaged payloads. Keep offline wheelhouse support in that builder. Nix builds the independent PM lock as a separate derivation. Refuse lazy-disabled bootstrap before installing tools or dependencies. Move first-party YAML readers and writers to ruamel. Keep the application lock's transitive PyYAML requirements for third-party packages. Verification: - Focused canonical Python suite: 177 passed, 1 host-gated skip. - Electron backend probes: 12 passed. Electron typecheck passed. - Both uv locks, scoped lint, Bash syntax, and whitespace checks passed. - Cold activation, corrupt-app repair, offline staging, and relocation ran. - Built and exercised the Nix PM runtime and standalone YAML merge script. Six broader caller test files retain the same 24 failing test IDs as an archive of HEAD. The existing real-home guard blocks those tests before they can exercise the affected paths. No full-suite pass is claimed. Native Windows signing and full Bionic package execution remain unverified.
85 lines
3.6 KiB
Python
85 lines
3.6 KiB
Python
"""Every update surface validates staged code before changing an active plugin."""
|
|
from __future__ import annotations
|
|
|
|
import subprocess
|
|
|
|
import pytest
|
|
|
|
from tests.hermes_cli.test_plugin_update_transaction import installed, _version # noqa: F401
|
|
from tests.pm.test_plugin_survival_contract import admission_env # noqa: F401
|
|
|
|
|
|
@pytest.mark.parametrize("installed", ["catalog", "custom"], indirect=True)
|
|
def test_cli_update_scan_refusal_keeps_the_installed_tree(installed, monkeypatch):
|
|
from hermes_cli import plugins_cmd as pc
|
|
|
|
_, home, repo, target, state = installed
|
|
old = (target / "__init__.py").read_bytes()
|
|
before = (home / "config.yaml").read_bytes()
|
|
state["sha"] = _version(repo, "2.0.0")
|
|
scans = []
|
|
|
|
def refuse(staged, source, **kwargs):
|
|
scans.append(staged)
|
|
assert staged != target
|
|
assert (target / "__init__.py").read_bytes() == old
|
|
raise pc.PluginScanBlocked("fixture refuses candidate")
|
|
|
|
monkeypatch.setattr(pc, "_scan_plugin_tree", refuse)
|
|
with pytest.raises(SystemExit):
|
|
pc.cmd_update("transactional", interactive=False)
|
|
assert len(scans) == 1
|
|
assert (target / "__init__.py").read_bytes() == old
|
|
assert (home / "config.yaml").read_bytes() == before
|
|
|
|
|
|
@pytest.mark.parametrize("installed", ["catalog", "custom"], indirect=True)
|
|
def test_disabled_update_does_not_change_dependencies_or_enablement(installed, monkeypatch):
|
|
from hermes_cli import plugins_cmd as pc
|
|
from pm import paths
|
|
|
|
_, home, repo, target, state = installed
|
|
pc._set_plugin_enabled("transactional", enable=False)
|
|
config = (home / "config.yaml").read_bytes()
|
|
facts = paths.runtime_facts_path().read_bytes()
|
|
state["sha"] = _version(repo, "2.0.0")
|
|
monkeypatch.setattr("pm.client.sync_venv",
|
|
lambda **kwargs: pytest.fail("disabled plugin changed the dependency selection"))
|
|
result = pc.dashboard_update_user_plugin("transactional")
|
|
assert result["ok"], result
|
|
assert subprocess.check_output(["git", "rev-parse", "HEAD"], cwd=target, text=True).strip() == state["sha"]
|
|
assert (home / "config.yaml").read_bytes() == config
|
|
assert paths.runtime_facts_path().read_bytes() == facts
|
|
|
|
|
|
@pytest.mark.parametrize("installed", ["catalog", "custom"], indirect=True)
|
|
def test_enablement_before_lock_acquisition_cannot_skip_validation(installed, monkeypatch):
|
|
from contextlib import contextmanager
|
|
from hermes_cli import plugins_cmd as pc, runtime_state
|
|
from pm import paths
|
|
|
|
_, home, repo, target, state = installed
|
|
pc._set_plugin_enabled("transactional", enable=False)
|
|
watched = [target / "__init__.py", target / "pyproject.toml", home / "plugins/.install-metadata.json"]
|
|
before = {path: path.read_bytes() for path in watched}
|
|
state["sha"] = _version(repo, "2.0.0", broken=True)
|
|
lock = runtime_state.runtime_lock
|
|
enabled = {}
|
|
|
|
@contextmanager
|
|
def enable_before_acquiring_lock(project):
|
|
if not enabled:
|
|
enabled["begun"] = True
|
|
pc._set_plugin_enabled("transactional", enable=True)
|
|
enabled["config"] = (home / "config.yaml").read_bytes()
|
|
enabled["facts"] = paths.runtime_facts_path().read_bytes()
|
|
with lock(project):
|
|
yield
|
|
|
|
monkeypatch.setattr(runtime_state, "runtime_lock", enable_before_acquiring_lock)
|
|
result = pc.dashboard_update_user_plugin("transactional")
|
|
assert result["ok"] is False, result
|
|
assert {path: path.read_bytes() for path in watched} == before
|
|
assert (home / "config.yaml").read_bytes() == enabled["config"]
|
|
assert paths.runtime_facts_path().read_bytes() == enabled["facts"]
|