d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
75 lines
2.5 KiB
Python
75 lines
2.5 KiB
Python
"""plugins.manage optional ``profile`` param — per-profile plugins scoping.
|
|
|
|
Mirrors ``cron.manage`` / ``mcp.servers.*``: when a ``profile`` is passed the
|
|
handler resolves ``get_profile_dir(profile)`` and wraps the action dispatch in
|
|
``set_hermes_home_override`` / ``reset_hermes_home_override``. Because
|
|
``_plugins_dir()`` keys off ``get_hermes_home()``, the list action must then
|
|
scan THAT profile's ``plugins/`` dir, not the launch profile's.
|
|
"""
|
|
|
|
from tui_gateway import server
|
|
|
|
|
|
def test_plugins_manage_profile_reads_that_profiles_dir(tmp_path, monkeypatch):
|
|
# A temp profile home with one user plugin in its plugins dir.
|
|
profile_home = tmp_path / "profiles" / "botA"
|
|
plugin_dir = profile_home / "plugins" / "bota-only-plugin"
|
|
plugin_dir.mkdir(parents=True)
|
|
(plugin_dir / "plugin.yaml").write_text(
|
|
"name: bota-only-plugin\nversion: '1.0'\ndescription: BotA-only plugin\n",
|
|
encoding="utf-8",
|
|
)
|
|
|
|
# Route the profile name the handler resolves to our temp home.
|
|
import hermes_cli.profiles as profiles
|
|
|
|
monkeypatch.setattr(profiles, "get_profile_dir", lambda name: profile_home)
|
|
|
|
resp = server.handle_request(
|
|
{
|
|
"id": "1",
|
|
"method": "plugins.manage",
|
|
"params": {"action": "list", "profile": "botA"},
|
|
}
|
|
)
|
|
|
|
assert "result" in resp, resp
|
|
user_rows = [
|
|
p for p in resp["result"]["plugins"] if p.get("source") == "user"
|
|
]
|
|
assert "bota-only-plugin" in [p["name"] for p in user_rows]
|
|
|
|
# The override must not leak: an unscoped call after this one resolves the
|
|
# launch profile again.
|
|
from hermes_constants import get_hermes_home_override
|
|
|
|
assert get_hermes_home_override() is None
|
|
|
|
|
|
def test_plugins_manage_unknown_profile_errors(tmp_path, monkeypatch):
|
|
import hermes_cli.profiles as profiles
|
|
|
|
missing = tmp_path / "profiles" / "ghost"
|
|
monkeypatch.setattr(profiles, "get_profile_dir", lambda name: missing)
|
|
|
|
resp = server.handle_request(
|
|
{
|
|
"id": "2",
|
|
"method": "plugins.manage",
|
|
"params": {"action": "list", "profile": "ghost"},
|
|
}
|
|
)
|
|
|
|
assert "error" in resp, resp
|
|
assert resp["error"]["code"] == 4064
|
|
|
|
|
|
def test_plugins_manage_unscoped_still_lists(monkeypatch):
|
|
# No profile param — the pre-existing contract is unchanged.
|
|
resp = server.handle_request(
|
|
{"id": "3", "method": "plugins.manage", "params": {"action": "list"}}
|
|
)
|
|
|
|
assert "result" in resp, resp
|
|
assert "plugins" in resp["result"]
|