David Metcalfe
91dcca9a9b
fix(desktop): scope keychain reset to the legacy ad-hoc fallback only
...
The previous commit deleted the 'Hermes Safe Storage' keychain item after
every successful re-sign, including the stable certificate-anchored
identity path. On that path the designated requirement is stable across
rebuilds, so after the first launch under the new identity the keychain
ACL already matches; deleting the item on every update permanently
orphaned gateway-token and native-OAuth credentials that were working
fine (both are safeStorage-backed: electron/main.ts connection config
and native-oauth-tokens.json).
Addresses review feedback on #90961 :
- Rename _desktop_macos_update_keychain_acl -> _desktop_macos_reset_keychain_safe_storage (it deletes, it does not update an ACL).
- Only invoke it on the legacy ad-hoc fallback path, where every rebuild
produces a new cdhash so the ACL can never match and the alternative
is a recurring prompt. The trade-off (re-enter credentials once per
update) is documented; the durable fix is a stable signing identity.
- Add regression tests: stable path must NOT reset, ad-hoc fallback MUST.
2026-08-25 23:23:11 -07:00
..
2026-08-24 16:58:51 +10:00
2026-08-12 18:52:08 -07:00
2026-08-18 20:42:06 -04:00
2026-08-25 16:24:19 -07:00
2026-08-24 20:10:44 -07:00
2026-08-21 05:16:27 -07:00
2026-08-23 01:47:26 -07:00
2026-08-23 01:47:26 -07:00
2026-08-24 03:20:37 -07:00
2026-08-16 02:03:22 -07:00
2026-08-20 03:05:46 -07:00
2026-08-25 01:34:56 +05:30
2026-08-15 00:33:01 -07:00
2026-08-08 23:56:46 -07:00
2026-08-12 16:26:55 -07:00
2026-08-07 08:57:39 -07:00
2026-08-07 08:57:39 -07:00
2026-08-23 20:00:53 -07:00
2026-08-25 10:55:53 +10:00
2026-08-21 14:39:02 -07:00
2026-08-17 15:47:17 -07:00
2026-08-07 17:45:06 +05:30
2026-08-20 21:54:25 -07:00
2026-08-19 19:34:36 -07:00
2026-08-08 15:10:35 +05:30
2026-08-16 06:32:08 -07:00
2026-08-22 03:59:28 +05:30
2026-08-23 17:38:38 -07:00
2026-08-24 15:42:58 +05:30
2026-08-23 02:14:35 -07:00
2026-08-23 17:38:38 -07:00
2026-08-25 21:59:04 -07:00
2026-08-25 02:45:10 -07:00
2026-08-25 04:00:27 -07:00
2026-08-24 00:34:26 -07:00
2026-08-19 19:22:48 -07:00
2026-08-25 14:02:40 -07:00
2026-08-23 21:12:20 -07:00
2026-08-24 15:45:52 +05:30
2026-08-23 00:52:50 -07:00
2026-08-21 23:01:30 -07:00
2026-08-13 02:38:28 -07:00
2026-08-13 02:38:28 -07:00
2026-08-25 22:10:12 -07:00
2026-08-19 16:16:37 -07:00
2026-08-15 13:28:14 -07:00
2026-08-20 02:06:05 -07:00
2026-08-21 14:13:28 +10:00
2026-08-16 06:26:12 -07:00
2026-08-23 18:01:59 -07:00
2026-08-15 04:33:47 -07:00
2026-08-21 02:48:14 +08:00
2026-08-18 16:08:29 -07:00
2026-08-13 23:10:16 +05:30
2026-08-22 22:00:19 -07:00
2026-08-17 14:16:21 +05:30
2026-08-10 12:43:46 -07:00
2026-08-10 12:43:46 -07:00
2026-08-17 14:16:21 +05:30
2026-08-21 13:41:39 -07:00
2026-08-18 16:08:29 -07:00
2026-08-25 22:10:12 -07:00
2026-08-25 23:23:11 -07:00
2026-08-14 22:37:46 -07:00
2026-08-25 04:21:37 -07:00
2026-08-25 04:21:37 -07:00
2026-08-07 09:44:21 -07:00
2026-08-19 23:15:01 -07:00
2026-08-12 21:50:35 -07:00
2026-08-12 21:50:35 -07:00
2026-08-14 01:31:31 -07:00
2026-08-14 01:06:13 -07:00
2026-08-20 20:21:12 -07:00
2026-08-21 14:38:19 -07:00
2026-08-14 01:06:13 -07:00
2026-08-21 00:24:32 -07:00
2026-08-21 04:39:31 -07:00
2026-08-24 13:36:23 -07:00
2026-08-07 19:47:40 +05:30
2026-08-22 21:36:55 -07:00
2026-08-14 21:35:30 -07:00
2026-08-23 03:56:37 -07:00
2026-08-09 10:33:58 -07:00
2026-08-15 00:32:44 -07:00
2026-08-12 20:10:51 -07:00
2026-08-12 20:10:51 -07:00
2026-08-12 18:39:22 -07:00
2026-08-12 18:52:08 -07:00
2026-08-12 19:56:44 -07:00
2026-08-19 19:34:36 -07:00
2026-08-24 20:11:18 -07:00
2026-08-20 04:47:38 -07:00
2026-08-24 20:25:10 -07:00
2026-08-15 00:33:11 -07:00
2026-08-16 06:24:56 -07:00
2026-08-21 00:24:32 -07:00
2026-08-21 00:24:32 -07:00
2026-08-20 12:16:20 +05:30
2026-08-14 13:51:26 -07:00
2026-08-19 08:52:03 -07:00
2026-08-10 17:02:56 -07:00
2026-08-23 18:25:35 -07:00
2026-08-15 01:55:22 -07:00
2026-08-08 12:32:23 -07:00
2026-08-14 21:07:21 -07:00
2026-08-15 02:04:49 -07:00
2026-08-15 02:04:49 -07:00
2026-08-15 00:31:37 -07:00
2026-08-12 19:43:47 -07:00
2026-08-20 02:06:05 -07:00
2026-08-19 19:34:36 -07:00
2026-08-24 20:25:10 -07:00
2026-08-08 15:10:35 +05:30
2026-08-24 20:25:10 -07:00
2026-08-19 19:34:36 -07:00
2026-08-18 02:27:18 -07:00
2026-08-24 20:10:44 -07:00
2026-08-16 01:54:35 -07:00
2026-08-07 17:45:06 +05:30
2026-08-15 18:15:18 -07:00
2026-08-20 04:08:57 -07:00
2026-08-25 21:59:52 -07:00
2026-08-22 13:39:04 -04:00
2026-08-25 22:10:12 -07:00
2026-08-23 04:45:29 -07:00
2026-08-22 23:46:06 -07:00
2026-08-14 16:43:37 -07:00
2026-08-07 10:11:05 -07:00
2026-08-15 01:05:39 -07:00
2026-08-16 20:53:44 -07:00
2026-08-15 01:21:40 -07:00
2026-08-24 20:11:18 -07:00
2026-08-19 23:55:20 -07:00
2026-08-19 23:55:20 -07:00