7546680ff8
BtbN deletes daily autobuild tags after 14 days and keeps the last build of each month for two years (util/prunetags.sh). btbn_index took the newest daily, so every `pm update ffmpeg` wrote a pin that 404s two weeks later (#125350, #122240). It now skips the current month's tags (still dailies the next build displaces) and every tag but the last in each finished month, so the tool only ever pins a retained build.
79 lines
3.3 KiB
Python
79 lines
3.3 KiB
Python
"""Ffmpeg pin resolution uses the advertised version and target, never a guessed URL."""
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
|
|
from pm import update
|
|
from pm.package import InstallError
|
|
from pm.packages import Ffmpeg
|
|
|
|
|
|
@pytest.fixture
|
|
def indexes(monkeypatch):
|
|
tag = "autobuild-2026-09-30-12-00" # last September build: the only retained tag
|
|
version = "9.1.2"
|
|
assets = [
|
|
f"ffmpeg-n{version}-1-gabcdef-linux64-gpl-9.1.tar.xz",
|
|
f"ffmpeg-n{version}-1-gabcdef-linuxarm64-gpl-9.1.tar.xz",
|
|
f"ffmpeg-n{version}-1-gabcdef-linux64-gpl-shared-9.1.tar.xz",
|
|
f"ffmpeg-n{version}-1-gabcdef-linux64-lgpl-9.1.tar.xz",
|
|
f"ffmpeg-n{version}-1-gabcdef-win64-gpl-shared-9.1.zip",
|
|
f"ffmpeg-n{version}-1-gabcdef-win64-lgpl-9.1.zip",
|
|
f"ffmpeg-n{version}-1-gabcdef-win64-gpl-9.1.zip",
|
|
f"ffmpeg-n{version}-1-gabcdef-winarm64-gpl-9.1.zip",
|
|
]
|
|
|
|
def release(release_version, tag_date):
|
|
name = f"ffmpeg-n{release_version}-1-gabcdef-win64-gpl-9.1.zip"
|
|
return {"tag_name": f"autobuild-{tag_date}", "assets": [{"name": name}]}
|
|
|
|
monkeypatch.setattr(update, "_get_json", lambda url: [
|
|
# The current month's newest tag and an older daily in a finished
|
|
# month are both deleted by BtbN within two weeks.
|
|
release("9.1.3", "2026-10-02-12-00"),
|
|
{"tag_name": tag, "assets": [{"name": name} for name in assets]},
|
|
release("9.1.1", "2026-09-10-12-00"),
|
|
])
|
|
paths = {
|
|
f"{osname}-{arch}": f"{source_os}/{source_arch}/1788300000_{version}/ffmpeg.zip"
|
|
for osname, source_os in (("linux", "linux"), ("darwin", "macos"))
|
|
for arch, source_arch in (("x64", "amd64"), ("arm64", "arm64"))
|
|
}
|
|
monkeypatch.setattr(update, "_get_text", lambda url: "\n".join(
|
|
f'<a href="/download/{path}">Ffmpeg</a>' for path in paths.values()
|
|
))
|
|
return version, tag, paths
|
|
|
|
|
|
@pytest.mark.parametrize("target", [
|
|
"win32-x64", "win32-arm64", "linux-x64", "linux-arm64", "darwin-x64", "darwin-arm64",
|
|
])
|
|
def test_resolved_version_fetches_its_exact_target_asset(indexes, target):
|
|
version, tag, paths = indexes
|
|
package = Ffmpeg()
|
|
# URL resolution and update discovery must agree about target identities.
|
|
url = package.fetch_url(version, target)
|
|
assert version in package.latest_versions(target)
|
|
if target.startswith(("win32", "linux")):
|
|
arch = "64" if target.endswith("-x64") else "arm64"
|
|
if target.startswith("win32"):
|
|
expected = f"ffmpeg-n{version}-1-gabcdef-win{arch}-gpl-9.1.zip"
|
|
else:
|
|
expected = f"ffmpeg-n{version}-1-gabcdef-linux{arch}-gpl-9.1.tar.xz"
|
|
assert url == f"https://github.com/BtbN/FFmpeg-Builds/releases/download/{tag}/{expected}"
|
|
else:
|
|
assert url == f"https://ffmpeg.martin-riedl.de/download/{paths[target]}"
|
|
|
|
|
|
@pytest.mark.parametrize("target", ["win32-x64", "win32-arm64", "linux-x64", "darwin-arm64"])
|
|
def test_unadvertised_version_refuses_instead_of_relabelling_old_bytes(indexes, target):
|
|
with pytest.raises(InstallError, match="9.9.9"):
|
|
Ffmpeg().fetch_url("9.9.9", target)
|
|
|
|
|
|
def test_only_retained_month_end_builds_are_pinned(indexes):
|
|
versions = Ffmpeg().latest_versions("win32-x64")
|
|
assert "9.1.2" in versions
|
|
assert "9.1.3" not in versions # current month: still a daily
|
|
assert "9.1.1" not in versions # older daily in a finished month
|