d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
55 lines
1.6 KiB
Python
55 lines
1.6 KiB
Python
"""Regression tests for AIAgent.commit_memory_session.
|
|
|
|
Issue #22394: commit_memory_session was calling MemoryManager.on_session_end
|
|
but never ContextEngine.on_session_end. Context engines that accumulate
|
|
per-session state (LCM-style DAGs, summary stores) leaked that state from a
|
|
rotated-out session into whatever continued under the same compressor
|
|
instance.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _make_minimal_agent(memory_manager, context_compressor, session_id="abc"):
|
|
"""Build an object with just enough surface for commit_memory_session to run.
|
|
|
|
AIAgent.__init__ is too heavy for a focused unit test — bind the method
|
|
to a SimpleNamespace-style object that has the attributes the method
|
|
actually touches.
|
|
"""
|
|
from run_agent import AIAgent
|
|
|
|
obj = SimpleNamespace(
|
|
_memory_manager=memory_manager,
|
|
context_compressor=context_compressor,
|
|
session_id=session_id,
|
|
)
|
|
obj.commit_memory_session = AIAgent.commit_memory_session.__get__(obj)
|
|
return obj
|
|
|
|
|
|
def test_commit_memory_session_notifies_context_engine():
|
|
"""Both the memory manager AND the context engine receive on_session_end."""
|
|
mm = MagicMock()
|
|
ctx = MagicMock()
|
|
agent = _make_minimal_agent(mm, ctx, session_id="sess-42")
|
|
|
|
msgs = [{"role": "user", "content": "hi"}, {"role": "assistant", "content": "yo"}]
|
|
agent.commit_memory_session(msgs)
|
|
|
|
mm.on_session_end.assert_called_once_with(msgs)
|
|
ctx.on_session_end.assert_called_once_with("sess-42", msgs)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|