Cluster: agent/{curator,curator_backup,background_review,review_engine,
review_idle_queue,insights,learning_graph,learning_graph_render,
learning_mutations,learn_prompt,verification_evidence,verification_stop,
verify_hooks,side_question,title_generator,turn_summary,
manual_compression_feedback,trajectory,moa_trace,trace_upload,verify/*}.
13662 -> 10693 LOC (-2969, -21.7%), behavior-neutral.
- Dead code: 27 private helpers with zero references removed
(_auto_title_session, _resolve_review_model, _parse_make_targets,
_filter_verifiable_paths, _find_subsequence, _is_under_root/_temp_dir,
_merge_runs, learning_graph_render bucket/period/node helpers,
_memories_dir/_memory_local_index/_node_detail, _cron_jobs_file,
_retention_cutoff, _scope_for_args, _clean_token, _count_diff_lines,
_ordered_verbs, _hermes_meta, _iter_skill_files).
- Unified helpers: _read_config_section (curator + curator_backup),
_write_file/_write_json (4 curator report writers), _msg_text
(background_review <- side_question), _report_failure/_notify_title
(title_generator instant/auto paths), _is_under (verification_evidence),
_scoped SQL pair builder + _query (insights), _optional_lock
(background_review), verify.recipes table-driven detection.
- if/elif routing -> dict dispatch: side_question role labels,
curator_backup summary bits, learning_graph_render buckets, insights
section rendering, verify recipe pickers.
- Redundant defensive layers, single-use wrappers and verbose narrative
comments collapsed; every non-obvious WHY/invariant kept in compact form.
Verification: parity.py (all REMOVED symbols zero-ref), import smoke for
every module + cli/run_agent/gateway.run/hermes_cli.main/
agent.conversation_loop/tui_gateway.server, old-vs-new fuzz parity on all
shared pure functions, SQL trace parity for insights and
verification_evidence, cluster tests 1354 passed / 0 failed (46 files).
44 lines
1.7 KiB
Python
44 lines
1.7 KiB
Python
"""Trajectory saving utilities and static helpers.
|
|
|
|
_convert_to_trajectory_format stays as an AIAgent method (batch_runner.py calls
|
|
agent._convert_to_trajectory_format); only static helpers and file-write logic live here.
|
|
"""
|
|
|
|
import json
|
|
import logging
|
|
from datetime import datetime
|
|
from typing import Any, Dict, List
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
|
|
def convert_scratchpad_to_think(content: str) -> str:
|
|
"""Convert <REASONING_SCRATCHPAD> tags to <think> tags."""
|
|
if not content or "<REASONING_SCRATCHPAD>" not in content:
|
|
return content
|
|
return content.replace("<REASONING_SCRATCHPAD>", "<think>").replace("</REASONING_SCRATCHPAD>", "</think>")
|
|
|
|
|
|
def has_incomplete_scratchpad(content: str) -> bool:
|
|
"""Whether content has an opening <REASONING_SCRATCHPAD> without a closing tag."""
|
|
return bool(content) and "<REASONING_SCRATCHPAD>" in content and "</REASONING_SCRATCHPAD>" not in content
|
|
|
|
|
|
def save_trajectory(trajectory: List[Dict[str, Any]], model: str, completed: bool, filename: str = None):
|
|
"""Append a ShareGPT-format trajectory entry to a JSONL file (default
|
|
trajectory_samples.jsonl / failed_trajectories.jsonl based on ``completed``)."""
|
|
if filename is None:
|
|
filename = "trajectory_samples.jsonl" if completed else "failed_trajectories.jsonl"
|
|
entry = {
|
|
"conversations": trajectory,
|
|
"timestamp": datetime.now().isoformat(),
|
|
"model": model,
|
|
"completed": completed,
|
|
}
|
|
try:
|
|
with open(filename, "a", encoding="utf-8") as f:
|
|
f.write(json.dumps(entry, ensure_ascii=False) + "\n")
|
|
logger.info("Trajectory saved to %s", filename)
|
|
except Exception as e:
|
|
logger.warning("Failed to save trajectory: %s", e)
|