5e4a2a3d24
Competing installers and checkout-local venv assumptions bypassed PM selection, install consent, and generation lifetimes. Route consumers through PM and installation-bound launchers. Refresh source launchers before obsolete Python entries can be collected. Remove Node, browser, and CUA acquisition engines, obsolete venv-holder handling, detached sync, and unused PM APIs. Keep historical updater exports inert and preserve external tool ownership and native integration. Share product freshness and prepared inputs across builders. Align plugin admission, Docker provisioning, setup instructions, and behavioral tests. Verified targeted Python and JavaScript tests, desktop and web typechecks, scoped lint, real product builds, and the Docker frontend smoke test. The missed post-setup test cleanup is included and verified. Native Windows/macOS execution, full Rust compilation, and the complete repository suite remain unverified. Historical compatibility requirements were preserved and extended, not fully rescanned.
67 lines
3.3 KiB
Python
67 lines
3.3 KiB
Python
"""Only declared Python dependencies require Python install consent."""
|
|
import json
|
|
import os
|
|
import subprocess
|
|
|
|
import pytest
|
|
import hermes_yaml as yaml
|
|
|
|
from hermes_cli import plugins_cmd
|
|
from tests.pm.test_plugin_survival_contract import admission_env # noqa: F401
|
|
|
|
|
|
@pytest.mark.parametrize('python_surface', [None, 'pyproject', 'legacy'])
|
|
def test_install_only_requests_relevant_python_consent(admission_env, monkeypatch, capsys, python_surface):
|
|
root, home = admission_env
|
|
source = root / 'plugin-source'
|
|
source.mkdir()
|
|
manifest = {'name': 'sidecar-plugin'}
|
|
if python_surface == 'legacy':
|
|
manifest['python_dependencies'] = ['never-install-without-consent==1']
|
|
(source / 'plugin.yaml').write_text(yaml.safe_dump(manifest), encoding='utf-8')
|
|
(source / '__init__.py').write_text('def register(ctx):\n pass\n', encoding='utf-8')
|
|
(source / 'package.json').write_text(json.dumps({'name': 'sidecar-plugin', 'version': '1.0.0'}), encoding='utf-8')
|
|
if python_surface == 'pyproject':
|
|
(source / 'pyproject.toml').write_text(
|
|
'[project]\nname="sidecar-plugin"\nversion="1.0"\nrequires-python=">=3.14"\n', encoding='utf-8')
|
|
env = {k: v for k, v in os.environ.items() if k not in {'GIT_DIR', 'GIT_WORK_TREE', 'GIT_INDEX_FILE'}}
|
|
for args in [('init', '-q'), ('add', '.'), ('-c', 'user.name=test', '-c', 'user.email=test@example.invalid', 'commit', '-qm', 'fixture')]:
|
|
subprocess.run(['git', *args], cwd=source, env=env, check=True, capture_output=True, timeout=30)
|
|
monkeypatch.setattr(plugins_cmd.sys.stdin, 'isatty', lambda: False)
|
|
config_path = home / 'config.yaml'
|
|
before = config_path.read_bytes()
|
|
plugins_cmd.cmd_install(source.as_uri(), enable=True, allow_removed=True)
|
|
installed = home / 'plugins' / 'sidecar-plugin'
|
|
assert (installed / 'package.json').is_file()
|
|
assert not (installed / 'node_modules').exists()
|
|
enabled = yaml.safe_load(config_path.read_text(encoding='utf-8'))['plugins']['enabled']
|
|
output = capsys.readouterr().out
|
|
if python_surface is None:
|
|
assert 'sidecar-plugin' in enabled
|
|
assert 'declares Python dependencies' not in output
|
|
else:
|
|
assert 'sidecar-plugin' not in enabled
|
|
assert config_path.read_bytes() == before
|
|
assert 'dependency install skipped (non-interactive)' in output
|
|
|
|
|
|
def test_node_sidecar_question_stays_independent(tmp_path, monkeypatch):
|
|
from pm import workspace
|
|
|
|
target = tmp_path / 'plugin'
|
|
target.mkdir()
|
|
(target / 'package.json').write_text('{}', encoding='utf-8')
|
|
prompts, installs, lines = [], [], []
|
|
monkeypatch.setattr(plugins_cmd.sys.stdin, 'isatty', lambda: True)
|
|
monkeypatch.setattr(plugins_cmd.sys.stdout, 'isatty', lambda: True)
|
|
monkeypatch.setattr('builtins.input', lambda prompt: prompts.append(prompt) or 'yes')
|
|
monkeypatch.setattr(workspace, 'install_node_sidecar', lambda path, **kwargs: installs.append((path, kwargs)))
|
|
from types import SimpleNamespace
|
|
|
|
result = plugins_cmd._install_plugin_python_deps(
|
|
{'name': 'sidecar'}, target, SimpleNamespace(print=lambda *args, **kwargs: lines.extend(args)))
|
|
assert result == (True, None)
|
|
assert installs == [(target, {'explicit': True})]
|
|
assert len(prompts) == 1 and 'node_modules' in prompts[0]
|
|
assert not any('Python dependencies' in str(line) for line in lines)
|