d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
77 lines
3.1 KiB
Python
77 lines
3.1 KiB
Python
"""Regression tests: installers provision cua-driver (Computer Use).
|
|
|
|
Policy: choosing Computer Use should be a config flip, not a surprise
|
|
multi-minute binary fetch. The installers pre-install cua-driver
|
|
(best-effort, skippable), and the dashboard toggle auto-installs when the
|
|
binary is still missing (see test_web_routers_tools_install_on_enable.py).
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parent.parent.parent.parent
|
|
INSTALL_SH = REPO_ROOT / "scripts" / "install.sh"
|
|
INSTALL_PS1 = REPO_ROOT / "scripts" / "install.ps1"
|
|
|
|
|
|
class TestInstallSh:
|
|
def test_has_skip_flag(self) -> None:
|
|
text = INSTALL_SH.read_text()
|
|
assert "--skip-computer-use)" in text
|
|
assert "SKIP_COMPUTER_USE=true" in text
|
|
assert "SKIP_COMPUTER_USE=false" in text # default off
|
|
assert "--skip-computer-use Skip the cua-driver" in text
|
|
|
|
def test_install_function_wired_into_main_and_stage(self) -> None:
|
|
text = INSTALL_SH.read_text()
|
|
assert "install_computer_use_driver() {" in text
|
|
# main() flow and the node-deps stage both run it.
|
|
assert text.count("install_computer_use_driver\n") >= 2
|
|
|
|
def test_install_is_timeboxed_above_upstream_lock_window(self) -> None:
|
|
"""The upstream installer serializes on a lock with a 600s stale
|
|
window; a ceiling below that reintroduces the self-perpetuating
|
|
wedge (#58762). Must stay >= 660."""
|
|
text = INSTALL_SH.read_text()
|
|
assert "run_with_timeout 660 /bin/bash -c" in text
|
|
|
|
def test_install_is_best_effort(self) -> None:
|
|
text = INSTALL_SH.read_text()
|
|
assert "Computer Use driver install failed" in text
|
|
assert "hermes computer-use install" in text
|
|
|
|
def test_skips_unwritable_applications_dir(self) -> None:
|
|
"""Non-admin macOS accounts can't receive CuaDriver.app (#47865
|
|
class) — skip cleanly instead of failing every install."""
|
|
text = INSTALL_SH.read_text()
|
|
assert '[ -d /Applications ] && [ ! -w /Applications ]' in text
|
|
|
|
|
|
class TestInstallPs1:
|
|
def test_has_skip_switch(self) -> None:
|
|
text = INSTALL_PS1.read_text()
|
|
assert "[switch]$SkipComputerUse," in text
|
|
assert "if ($SkipComputerUse)" in text
|
|
|
|
def test_install_function_wired_into_node_deps(self) -> None:
|
|
text = INSTALL_PS1.read_text()
|
|
assert "function Install-CuaDriver {" in text
|
|
assert " Install-CuaDriver\n" in text
|
|
|
|
def test_install_is_timeboxed_above_upstream_lock_window(self) -> None:
|
|
text = INSTALL_PS1.read_text()
|
|
assert "Wait-Job $job -Timeout 660" in text
|
|
|
|
def test_install_is_best_effort(self) -> None:
|
|
text = INSTALL_PS1.read_text()
|
|
assert "Computer Use driver install timed out" in text
|
|
assert "hermes computer-use install" in text
|
|
|
|
def test_install_rechecks_runtime_contract_before_success(self) -> None:
|
|
text = INSTALL_PS1.read_text()
|
|
assert "$installedCuaDriver = Get-Command cua-driver" in text
|
|
assert (
|
|
"Test-CuaDriverRuntimeContract -DriverPath $installedCuaDriver.Source"
|
|
in text
|
|
)
|
|
assert "did not produce a compatible runtime" in text
|