d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
86 lines
2.8 KiB
Python
86 lines
2.8 KiB
Python
"""Tests for `/exit --delete` and `/quit --delete` session deletion.
|
|
|
|
Ports the behavior from google-gemini/gemini-cli#19332: running `/exit` or
|
|
`/quit` with the `--delete` flag arms a one-shot `_delete_session_on_exit`
|
|
flag that the CLI shutdown path uses to remove the current session from
|
|
SQLite + on-disk transcripts before exit.
|
|
"""
|
|
|
|
from unittest.mock import MagicMock
|
|
|
|
|
|
def _make_cli():
|
|
"""Bare HermesCLI suitable for process_command() tests.
|
|
|
|
Uses ``__new__`` to skip the heavy __init__; only sets the attributes
|
|
the /exit branch touches.
|
|
"""
|
|
from cli import HermesCLI
|
|
cli = HermesCLI.__new__(HermesCLI)
|
|
cli.config = {}
|
|
cli.console = MagicMock()
|
|
cli.agent = None
|
|
cli.conversation_history = []
|
|
cli.session_id = "test-session"
|
|
cli._delete_session_on_exit = False
|
|
return cli
|
|
|
|
|
|
class TestExitDeleteFlag:
|
|
|
|
|
|
def test_exit_delete_arms_flag(self):
|
|
cli = _make_cli()
|
|
result = cli.process_command("/exit --delete")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
def test_quit_delete_arms_flag(self):
|
|
cli = _make_cli()
|
|
result = cli.process_command("/quit --delete")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
def test_exit_delete_short_form(self):
|
|
"""`-d` is a convenience alias for `--delete`."""
|
|
cli = _make_cli()
|
|
result = cli.process_command("/exit -d")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
|
|
|
|
def test_delete_flag_trims_whitespace(self):
|
|
cli = _make_cli()
|
|
result = cli.process_command("/exit --delete ")
|
|
assert result is False
|
|
assert cli._delete_session_on_exit is True
|
|
|
|
|
|
def test_unknown_exit_argument_prints_help(self):
|
|
cli = _make_cli()
|
|
# _cprint goes through module-level print, so capture via console.
|
|
# We can't patch _cprint directly without import juggling; the
|
|
# previous assertion already proves the unknown-arg branch is
|
|
# reached (result True + flag False).
|
|
result = cli.process_command("/exit garbage")
|
|
assert result is True
|
|
assert cli._delete_session_on_exit is False
|
|
|
|
|
|
class TestCommandRegistry:
|
|
def test_quit_command_advertises_delete_flag(self):
|
|
"""The CommandDef args_hint should surface `--delete` in /help and
|
|
CLI autocomplete."""
|
|
from hermes_cli.commands import resolve_command
|
|
cmd = resolve_command("quit")
|
|
assert cmd is not None
|
|
assert cmd.args_hint == "[--delete]"
|
|
|
|
def test_exit_alias_resolves_to_quit_with_hint(self):
|
|
from hermes_cli.commands import resolve_command
|
|
cmd = resolve_command("exit")
|
|
assert cmd is not None
|
|
assert cmd.name == "quit"
|
|
assert cmd.args_hint == "[--delete]"
|