d10bb2ab6f
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
103 lines
4.4 KiB
Python
103 lines
4.4 KiB
Python
"""Tests for slash command prefix matching in HermesCLI.process_command."""
|
|
from unittest.mock import MagicMock, patch
|
|
from cli import HermesCLI
|
|
|
|
|
|
def _make_cli():
|
|
cli_obj = HermesCLI.__new__(HermesCLI)
|
|
cli_obj.config = {}
|
|
cli_obj.console = MagicMock()
|
|
cli_obj.agent = None
|
|
cli_obj.conversation_history = []
|
|
cli_obj.session_id = None
|
|
cli_obj._pending_input = MagicMock()
|
|
return cli_obj
|
|
|
|
|
|
class TestSlashCommandPrefixMatching:
|
|
def test_unique_prefix_dispatches_command(self):
|
|
"""/con should dispatch to /config when it uniquely matches."""
|
|
cli_obj = _make_cli()
|
|
with patch.object(cli_obj, 'show_config') as mock_config:
|
|
cli_obj.process_command("/con")
|
|
mock_config.assert_called_once()
|
|
|
|
|
|
|
|
def test_ambiguous_prefix_shows_suggestions(self):
|
|
"""/re matches multiple commands — should show ambiguous message."""
|
|
cli_obj = _make_cli()
|
|
with patch("cli._cprint") as mock_cprint:
|
|
cli_obj.process_command("/re")
|
|
printed = " ".join(str(c) for c in mock_cprint.call_args_list)
|
|
assert "Ambiguous" in printed or "Did you mean" in printed
|
|
|
|
|
|
|
|
def test_skill_command_prefix_matches(self):
|
|
"""A prefix that uniquely matches a skill command should dispatch it."""
|
|
cli_obj = _make_cli()
|
|
fake_skill = {"/test-skill-xyz": {"name": "Test Skill", "description": "test"}}
|
|
printed = []
|
|
cli_obj.console.print = lambda *a, **kw: printed.append(str(a))
|
|
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill):
|
|
cli_obj.process_command("/test-skill-xy")
|
|
|
|
# Should NOT show "Unknown command" — should have dispatched or attempted skill
|
|
unknown = any("Unknown command" in p for p in printed)
|
|
assert not unknown, f"Expected skill prefix to match, got: {printed}"
|
|
|
|
def test_ambiguous_between_builtin_and_skill(self):
|
|
"""Ambiguous prefix spanning builtin + skill commands shows suggestions."""
|
|
cli_obj = _make_cli()
|
|
# /help-extra is a fake skill that shares /hel prefix with /help
|
|
fake_skill = {"/help-extra": {"name": "Help Extra", "description": "test"}}
|
|
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill), patch.object(cli_obj, 'show_help') as mock_help:
|
|
cli_obj.process_command("/help")
|
|
|
|
# /help is an exact match so should work normally, not show ambiguous
|
|
mock_help.assert_called_once()
|
|
printed = " ".join(str(c) for c in cli_obj.console.print.call_args_list)
|
|
assert "Ambiguous" not in printed
|
|
|
|
def test_shortest_match_preferred_over_longer_skill(self):
|
|
"""/qui should dispatch to /quit (5 chars) not report ambiguous with /quint-pipeline (15 chars)."""
|
|
cli_obj = _make_cli()
|
|
fake_skill = {"/quint-pipeline": {"name": "Quint Pipeline", "description": "test"}}
|
|
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill):
|
|
# /quit is caught by the exact "/quit" branch → process_command returns False
|
|
result = cli_obj.process_command("/qui")
|
|
|
|
# Returns False because /quit was dispatched (exits chat loop)
|
|
assert result is False
|
|
printed = " ".join(str(c) for c in cli_obj.console.print.call_args_list)
|
|
assert "Ambiguous" not in printed
|
|
|
|
def test_tied_shortest_matches_still_ambiguous(self):
|
|
"""/re matches /reset and /retry (both 6 chars) — no unique shortest, stays ambiguous."""
|
|
cli_obj = _make_cli()
|
|
printed = []
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_cprint', side_effect=lambda t: printed.append(t)):
|
|
cli_obj.process_command("/re")
|
|
combined = " ".join(printed)
|
|
assert "Ambiguous" in combined or "Did you mean" in combined
|
|
|
|
def test_exact_typed_name_dispatches_over_longer_match(self):
|
|
"""/help typed with /help-extra skill installed → exact match wins."""
|
|
cli_obj = _make_cli()
|
|
fake_skill = {"/help-extra": {"name": "Help Extra", "description": ""}}
|
|
import cli as cli_mod
|
|
with patch.object(cli_mod, '_skill_commands', fake_skill), \
|
|
patch.object(cli_obj, 'show_help') as mock_help:
|
|
cli_obj.process_command("/help")
|
|
mock_help.assert_called_once()
|
|
printed = " ".join(str(c) for c in cli_obj.console.print.call_args_list)
|
|
assert "Ambiguous" not in printed
|