Files
hermes-agent/tools/slash_confirm.py
Teknium 2776813df3 compat(plugins): temporary import-path shims for external plugins — ONE commit, revert on schedule
The Sep 2026 decomposition (PR #102117) makes internal import paths a non-API: names now live in
the focused modules that define them. This commit is the ONLY thing keeping the old paths alive,
so external plugins have time to update. It is deliberately a single, unsquashed commit:

    git revert <this sha>

removes every shim, stub and manifest at once on the announced date. Nothing in-tree may depend on
these pointers: scripts/check_compat_pointers.py (wired into lint.yml) fails CI if it does.

What it adds (see COMPAT_MANIFEST.md, compat_manifest.json):
- 332 facade modules get one delimited `PLUGIN-COMPAT` block appended at the end of the file
- 1,172 moved names resolved lazily via a module `__getattr__` (PEP 562) — never a top-level import,
  so no import cycles; facades that already had `__getattr__` get a chained one
- 592 third-party/stdlib names the old modules used to expose, with their original import statements
- 266 public definitions that had been deleted as unused, restored byte-for-byte from the pre-decomposition
  tree (+40 private helpers and 16 imports pulled in only because a restored definition needs them)
- 3 deleted modules recreated as re-export stubs (gateway/startup_watchdog, hermes_cli/observability/
  relay_runtime, tools/environments/modal_utils)
- private names (`_x`) get no pointer: they were never API (3,792 skipped)

Verified: all 335 touched modules import under a fresh HERMES_HOME and every manifest name resolves;
the lint reports zero in-tree uses; ruff clean; targeted suites unchanged.
2026-09-03 17:13:22 -07:00

124 lines
4.7 KiB
Python

"""Generic slash-command confirmation primitive (gateway-side).
Slash commands with an expensive side effect (currently only ``/reload-mcp``, which invalidates
the provider prompt cache) route through here. Button-UI adapters render Approve Once / Always
Approve / Cancel and call ``resolve()``; text-only adapters get a prompt and the gateway
intercepts ``/approve``, ``/always``, ``/cancel``. State is module-level (like ``tools.approval``)
so adapters can resolve without a ``GatewayRunner`` backreference. The CLI has its own
synchronous variant (``_prompt_slash_confirm`` in ``cli.py``).
"""
from __future__ import annotations
import logging
import threading
import time
from typing import Any, Awaitable, Callable, Dict, Optional
logger = logging.getLogger(__name__)
# session_key -> {"confirm_id", "command", "handler", "created_at"}
_pending: Dict[str, Dict[str, Any]] = {}
_lock = threading.RLock()
# Older pending confirms are discarded when the session's next message arrives (buttons live
# as long as the adapter keeps callback_data).
DEFAULT_TIMEOUT_SECONDS = 300
def register(session_key: str, confirm_id: str, command: str,
handler: Callable[[str], Awaitable[Optional[str]]]) -> None:
"""Register a pending confirm, superseding any prior one for the session."""
with _lock:
_pending[session_key] = {"confirm_id": confirm_id, "command": command,
"handler": handler, "created_at": time.time()}
def get_pending(session_key: str) -> Optional[Dict[str, Any]]:
"""Return a copy of the pending confirm dict for a session, or None."""
with _lock:
entry = _pending.get(session_key)
return dict(entry) if entry else None
def clear(session_key: str) -> None:
"""Drop the pending confirm for ``session_key`` without running it."""
with _lock:
_pending.pop(session_key, None)
def _is_stale(entry: Dict[str, Any], timeout: float) -> bool:
return time.time() - float(entry.get("created_at", 0) or 0) > timeout
def clear_if_stale(session_key: str, timeout: float = DEFAULT_TIMEOUT_SECONDS) -> bool:
"""Drop the pending confirm if older than ``timeout`` seconds; True if dropped."""
with _lock:
entry = _pending.get(session_key)
stale = bool(entry and _is_stale(entry, timeout))
if stale:
_pending.pop(session_key, None)
return stale
async def resolve(session_key: str, confirm_id: str, choice: str,
timeout: float = DEFAULT_TIMEOUT_SECONDS) -> Optional[str]:
"""Run the pending handler with ``choice`` ("once" / "always" / "cancel").
Returns the handler's output string, or None if the confirm was stale, already resolved,
or the confirm_id doesn't match (superseded prompt).
"""
with _lock:
entry = _pending.get(session_key)
if not entry or entry.get("confirm_id") != confirm_id:
return None
# Pop before running so duplicate callbacks (button double-click) cannot run it twice.
_pending.pop(session_key, None)
if _is_stale(entry, timeout):
return None
handler = entry.get("handler")
command = entry.get("command", "?")
if not handler:
return None
try:
result = await handler(choice)
except Exception as exc:
logger.error("Slash-confirm handler for /%s raised: %s", command, exc, exc_info=True)
return f"❌ Error handling confirmation: {exc}"
return result if isinstance(result, str) else None
# ---- BEGIN PLUGIN-COMPAT (revert-scheduled; see COMPAT_MANIFEST.md) ----
# Names external plugins imported from this module before the Sep 2026 decomposition.
# Internal code MUST NOT use these (scripts/check_compat_pointers.py fails CI if it does).
# The whole block is removed by reverting the commit that added it.
import asyncio # noqa: F401,E402
def resolve_sync_compat(
loop: asyncio.AbstractEventLoop,
session_key: str,
confirm_id: str,
choice: str,
) -> Optional[str]:
"""Synchronous helper: schedule resolve() on a loop and wait for the result.
Used by platform callback paths that run on a different thread than the
event loop (e.g. Discord's button click handler in some configurations).
Prefer the async ``resolve()`` from an async context.
"""
try:
from agent.async_utils import safe_schedule_threadsafe
fut = safe_schedule_threadsafe(
resolve(session_key, confirm_id, choice), loop,
logger=logger,
log_message="resolve_sync_compat scheduling failed",
)
if fut is None:
return None
return fut.result(timeout=30)
except Exception as exc:
logger.error("resolve_sync_compat failed: %s", exc)
return None
# ---- END PLUGIN-COMPAT ----