a5bd246865
* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule The PLUGIN-COMPAT layer (2776813df3+d63e380324+0a5164cebe) kept pre-#102117 import paths alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader has already been skipping plugins that use the old paths. This removes the layer itself: - 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party names, restored dead definitions) and the three re-export stub modules (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils) - COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step - the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section, the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the `plugins.allow_deprecated_imports` escape hatch An external plugin that still imports an old path now fails to load with its ImportError as the reason in `hermes plugins list`, the same path as any broken plugin. hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect, summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout swap (tests/compat/old_updater_surface.json). In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its `shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed `run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the seam production reads, like every sibling test in that file. * chore: retrigger CI (zero-job startup_failure phantom) * test: drop resolution allowlist rows for the two deleted which() sites hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available (a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires their allowlist entries go with them.
79 lines
3.0 KiB
Python
79 lines
3.0 KiB
Python
#!/usr/bin/env python3
|
|
"""The `desktop_preview` tool — the preview pane beside the chat, as ONE tool.
|
|
|
|
open/close/read used to be three tools that each re-taught "the preview pane" world;
|
|
one action enum states it once (~576 -> ~210 schema tokens). action=read keeps its
|
|
agent-level callback dispatch (agent_runtime_helpers -> agent.read_preview_callback).
|
|
Lives in the ``desktop_ui`` toolset — desktop-app sessions only.
|
|
"""
|
|
|
|
from tools import desktop_ui
|
|
from tools.open_preview_tool import _normalize_target, open_preview_tool
|
|
from tools.registry import registry, tool_error
|
|
|
|
|
|
def preview_close(url: str = "") -> str:
|
|
target = _normalize_target(url or "")
|
|
return desktop_ui.emit_or_error(
|
|
"preview.close",
|
|
{"url": target},
|
|
"Failed to close the preview: ",
|
|
"The preview pane is only available in the Hermes desktop app.",
|
|
{"success": True, "closed": target or "all"},
|
|
)
|
|
|
|
|
|
_ACTIONS = {
|
|
"open": lambda args: open_preview_tool(url=args.get("url", ""), label=args.get("label", "")),
|
|
"close": lambda args: preview_close(url=args.get("url", "")),
|
|
# read needs the GUI callback and is dispatched at the agent level.
|
|
"read": lambda args: tool_error(
|
|
"preview read must run inside a desktop session (no GUI callback here)."),
|
|
}
|
|
|
|
|
|
def _handle_preview(args, **kw):
|
|
"""Non-read actions only: action=read is dispatched at the agent level."""
|
|
fn = _ACTIONS.get((args.get("action") or "").strip())
|
|
if fn is None:
|
|
return tool_error("action must be one of: open, close, read.")
|
|
return fn(args)
|
|
|
|
|
|
PREVIEW_SCHEMA = {
|
|
"name": "desktop_preview",
|
|
"description": (
|
|
"Open, close, or read the preview pane beside the chat. open: show "
|
|
"a web URL (bare domains fine), a localhost dev server, or a file path "
|
|
"(HTML renders live) — opens for the current window only. close: dismiss "
|
|
"the whole pane, or one tab via url. read: what the pane currently shows "
|
|
"— returns {kind, url, title, text, start, end, total_chars}; a Browser "
|
|
"tab's text is the rendered page's visible text, paged with start/count "
|
|
"(char offsets); a file tab answers identity only (read the file with "
|
|
"read_file)."
|
|
),
|
|
"parameters": {
|
|
"type": "object",
|
|
"properties": {
|
|
"action": {"type": "string", "enum": ["open", "close", "read"]},
|
|
"url": {
|
|
"type": "string",
|
|
"description": "open: the target. close: one tab (omit for the whole pane).",
|
|
},
|
|
"label": {"type": "string", "description": "open: optional tab label."},
|
|
"start": {"type": "integer", "description": "read: 0-indexed char offset."},
|
|
"count": {"type": "integer", "description": "read: chars to return (capped per read)."},
|
|
},
|
|
"required": ["action"],
|
|
},
|
|
}
|
|
|
|
|
|
registry.register(
|
|
name="desktop_preview",
|
|
toolset="desktop_ui",
|
|
schema=PREVIEW_SCHEMA,
|
|
handler=_handle_preview,
|
|
emoji="🖼️",
|
|
)
|