c13ea774e6
Runtime identity resolved through hermes_cli.__version__ (a static 0.0.0 on source installs, rewritten by release stamping) leaked v0.0.0 into About, /api/health, User-Agents, and plugin compat, and source updates showed "couldn't reach update server" because identity and channel authority disagreed with the checkout. Now: get_version_info() resolves install stamp -> live git -> unknown, never pyproject metadata, never a package constant. Source checkouts derive identity from their reachable release tag; the completion tail of every successful install/update/historical takeover atomically rewrites install-stamp.json with that identity; a stale source stamp whose commit no longer matches HEAD defers to live git. ACP/TUI use derived_version for display and base_version for protocol fields; all ~44 runtime __version__ consumers migrated; hermes_cli.__version__ and generated _version.py are gone; release stamping only touches the native manifests external builders consume (nix/tauri/cargo) and passes release identity straight into write_install_stamp.py; pyproject.toml stays inert 0.0.0. Desktop no longer synthesizes a competing install-stamp.json: the checkout owns its stamp, and desktop-bootstrap classification keys on the bootstrap-complete marker. verify-bootstrap-version-stamp.py now cross-checks the checkout's stamp (baseVersion + commit == HEAD). Validation: 31-file focused suite green (version identity, stamping, adoption, providers, gateway, acp/tui runtime identity, api server via extras env, release graph); desktop tsc + 25 vitest green; real-repo probe: base=unknown derived=git.0635606.dirty source=git on this checkout; clean-env imports resolve entirely from this tree; windows footgun + compat-pointer scans clean.
85 lines
3.5 KiB
Python
85 lines
3.5 KiB
Python
"""Release stamping changes only metadata consumed by external builders."""
|
|
import json
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
|
|
def _tree(root: Path) -> None:
|
|
(root / "hermes_cli").mkdir()
|
|
(root / "hermes_cli" / "__init__.py").write_text(
|
|
'__release_date__ = "2026.1.1"\n', encoding="utf-8")
|
|
(root / "pyproject.toml").write_text('version = "0.0.0"\n', encoding="utf-8")
|
|
desktop = root / "apps" / "desktop"
|
|
desktop.mkdir(parents=True)
|
|
(desktop / "package.json").write_text('{"version": "0.0.0"}\n', encoding="utf-8")
|
|
(root / "package-lock.json").write_text(
|
|
'{"version": "0.0.0", "packages": {'
|
|
'"apps/desktop": {"name": "hermes", "version": "0.0.0"}, '
|
|
'"apps/bootstrap-installer": {"name": "@hermes/bootstrap-installer", "version": "0.0.0"}}}\n',
|
|
encoding="utf-8")
|
|
(root / "uv.lock").write_text(
|
|
'[[package]]\nname = "hermes-agent"\nversion = "0.0.0"\n'
|
|
'[[package]]\nname = "other"\nversion = "0.0.0"\n', encoding="utf-8")
|
|
(root / "nix").mkdir()
|
|
(root / "nix" / "hermes-agent.nix").write_text(
|
|
'{\n version ? "0.0.0",\n}: version\n', encoding="utf-8")
|
|
installer = root / "apps" / "bootstrap-installer" / "src-tauri"
|
|
installer.mkdir(parents=True)
|
|
(root / "apps" / "bootstrap-installer" / "package.json").write_text(
|
|
'{"name": "x", "version": "0.0.0"}\n', encoding="utf-8")
|
|
(installer / "tauri.conf.json").write_text(
|
|
'{"productName": "Hermes", "version": "0.0.0"}\n', encoding="utf-8")
|
|
(installer / "Cargo.toml").write_text('[package]\nversion = "0.0.0"\n', encoding="utf-8")
|
|
(installer / "Cargo.lock").write_text(
|
|
'[[package]]\nname = "bootstrap-installer"\nversion = "0.21.1"\n', encoding="utf-8")
|
|
|
|
|
|
def test_stamping_only_writes_external_builder_inputs(tmp_path):
|
|
from scripts.releases.stamping import stamp
|
|
|
|
build = tmp_path / "build"
|
|
build.mkdir()
|
|
_tree(build)
|
|
inert = [
|
|
build / "hermes_cli" / "__init__.py",
|
|
build / "pyproject.toml",
|
|
build / "uv.lock",
|
|
build / "apps" / "desktop" / "package.json",
|
|
build / "package-lock.json",
|
|
build / "apps" / "bootstrap-installer" / "package.json",
|
|
build / "apps" / "bootstrap-installer" / "src-tauri" / "Cargo.lock",
|
|
]
|
|
before = {path: path.read_bytes() for path in inert}
|
|
|
|
written = stamp(build, "0.21.5")
|
|
|
|
assert not (build / "hermes_cli" / "_version.py").exists()
|
|
assert {path: path.read_bytes() for path in inert} == before
|
|
assert 'version ? "0.21.5"' in (build / "nix" / "hermes-agent.nix").read_text()
|
|
tauri = build / "apps" / "bootstrap-installer" / "src-tauri" / "tauri.conf.json"
|
|
cargo = build / "apps" / "bootstrap-installer" / "src-tauri" / "Cargo.toml"
|
|
assert json.loads(tauri.read_text())["version"] == "0.21.5"
|
|
assert 'version = "0.21.5"' in cargo.read_text()
|
|
assert set(written) == {build / "nix" / "hermes-agent.nix", tauri, cargo}
|
|
|
|
tauri.write_text('{"version": "0.0.0"}\n', encoding="utf-8")
|
|
from scripts.releases.stamping import validate_bootstrap_version
|
|
with pytest.raises(ValueError, match="Tauri config"):
|
|
validate_bootstrap_version(build, "0.21.5")
|
|
|
|
|
|
def test_stamping_a_payload_snapshot_without_external_inputs_is_a_noop(tmp_path):
|
|
import shutil
|
|
|
|
from scripts.releases.stamping import stamp
|
|
|
|
_tree(tmp_path)
|
|
shutil.rmtree(tmp_path / "apps")
|
|
|
|
shutil.rmtree(tmp_path / "nix")
|
|
|
|
before = (tmp_path / "pyproject.toml").read_bytes()
|
|
assert stamp(tmp_path, "0.21.5") == []
|
|
assert (tmp_path / "pyproject.toml").read_bytes() == before
|