Files
hermes-agent/tests/hermes_cli/test_atomic_yaml_write.py
ethernet 284dbaf537 fix(pm): isolate bootstrap dependencies and unify YAML on ruamel
Activation reaches plugin discovery before the application dependencies
exist. Give PM its own locked Python project and runtime so it can install
or repair the application without importing that dependency tree.

Keep PM outside the application workspace. A shared uv workspace resolves
the application graph and cannot provide this isolation. Route mutations
through an isolated worker and preserve transaction callbacks, cancellation,
custom package registrations, and correlated receipts.

Use the same runtime builder for source installs and packaged payloads.
Keep offline wheelhouse support in that builder. Nix builds the independent
PM lock as a separate derivation. Refuse lazy-disabled bootstrap before
installing tools or dependencies.

Move first-party YAML readers and writers to ruamel. Keep the application
lock's transitive PyYAML requirements for third-party packages.

Verification:
- Focused canonical Python suite: 177 passed, 1 host-gated skip.
- Electron backend probes: 12 passed. Electron typecheck passed.
- Both uv locks, scoped lint, Bash syntax, and whitespace checks passed.
- Cold activation, corrupt-app repair, offline staging, and relocation ran.
- Built and exercised the Nix PM runtime and standalone YAML merge script.

Six broader caller test files retain the same 24 failing test IDs as an
archive of HEAD. The existing real-home guard blocks those tests before
they can exercise the affected paths. No full-suite pass is claimed.
Native Windows signing and full Bionic package execution remain unverified.
2026-09-11 12:23:51 -04:00

69 lines
2.5 KiB
Python
Raw Permalink Blame History

This file contains ambiguous Unicode characters

This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.

"""Tests for utils.atomic_yaml_write — crash-safe YAML file writes."""
from unittest.mock import patch
import pytest
import hermes_yaml as yaml
from utils import atomic_yaml_write
class TestAtomicYamlWrite:
def test_writes_valid_yaml(self, tmp_path):
target = tmp_path / "data.yaml"
data = {"key": "value", "nested": {"a": 1}}
atomic_yaml_write(target, data)
assert yaml.safe_load(target.read_text(encoding="utf-8")) == data
def test_cleans_up_temp_file_on_baseexception(self, tmp_path):
class SimulatedAbort(BaseException):
pass
target = tmp_path / "data.yaml"
original = {"preserved": True}
target.write_text(yaml.safe_dump(original), encoding="utf-8")
with patch("utils.yaml.safe_dump", side_effect=SimulatedAbort):
with pytest.raises(SimulatedAbort):
atomic_yaml_write(target, {"new": True})
tmp_files = [f for f in tmp_path.iterdir() if ".tmp" in f.name]
assert len(tmp_files) == 0
assert yaml.safe_load(target.read_text(encoding="utf-8")) == original
def test_writes_unicode_unescaped_and_round_trips(self, tmp_path):
"""Emoji/kaomoji are written as real UTF-8, not fragile escape sequences.
Regression for GitHub #51356: without allow_unicode=True, PyYAML emitted
astral-plane chars (emoji) as 8-digit `\\UXXXXXXXX` escapes inside
multi-line double-quoted strings wrapped with `\\` continuations, which
stricter/non-PyYAML parsers and hand-edits broke into unclosed quotes,
corrupting the entire config.
"""
target = tmp_path / "config.yaml"
# Mirrors the default personalities + skin cursor shipped in cli.py.
data = {
"personalities": {
"kawaii": "kawaii desu~! (◕‿◕) ★ ♪ ヽ(>∀<☆)ノ",
"catgirl": "nya~! (=^・ω・^=) ฅ^•ﻌ•^ฅ",
"surfer": "Cowabunga! 🤙 totally rad bro",
"hype": "LET'S GOOOO!!! 🔥 LEGENDARY!",
},
"display": {"cursor": " ▉"},
}
atomic_yaml_write(target, data)
text = target.read_text(encoding="utf-8")
# No escape artifacts of any kind — real characters on disk.
assert "\\U" not in text
assert "\\u" not in text
# Real glyphs are present verbatim.
assert "🔥" in text
assert "(=^・ω・^=)" in text
# And it reloads to exactly what was written.
assert yaml.safe_load(text) == data