Files
hermes-agent/tests/hermes_cli/conftest.py
ethernet 793605bc78 merge origin/main (7 commits) into ethie/pm-clean
Host-scoped update-restart obligation (061195fac1 / 953b6f6f08 / 3be255eca6)
lands on the PM model: the obligation record, its readers and the legacy
per-home marker compat come in as-is. The catch-up restart path
(`_apply_pending_fleet_restart_catchup` / `_run_pending_fleet_restart`) is
retired here (the fleet restart rides the completion owner), so main's
per-host restart-once guard on that path is not carried; its unit→live
MainPID collapse IS ported into the live post-update systemd pass
(`_restart_systemd_gateway_units`), with the two collapse tests rewritten
against that function (red on the pre-port tree: `_unit_main_pid` absent).
Tests that exercised only the retired catch-up path are dropped.

Desktop: main's shared log-rotation planner replaces the inline constants
in main.ts; the merge keeps our machine-profile import beside its import.

utf-8 → utf-8-sig on the three new BOM-intolerant reads (footguns lint).
2026-09-21 10:51:15 -04:00

157 lines
6.3 KiB
Python

"""Fixtures shared across hermes_cli tests."""
from __future__ import annotations
import pytest
@pytest.fixture
def all_assignees_spawnable(monkeypatch):
"""Pretend every assignee maps to a real Hermes profile.
Most dispatcher tests use synthetic assignees ("alice", "bob") that
don't correspond to actual profile directories on disk. Without this
patch, the dispatcher's profile-exists guard (PR #20105) routes
those tasks into ``skipped_nonspawnable`` instead of spawning, which
would break tests that assert spawn behavior.
"""
from hermes_cli import profiles
monkeypatch.setattr(profiles, "profile_exists", lambda name: True)
@pytest.fixture(autouse=True)
def _suppress_concurrent_hermes_gate(request, monkeypatch):
"""Default ``_detect_concurrent_hermes_instances`` to ``[]`` for every test.
The Windows update path now refuses to proceed when another
``hermes.exe`` is detected (issue #26670). On a developer's Windows
machine running the test suite via ``hermes`` itself, this would
flag the running agent as a concurrent instance and abort every
``cmd_update`` test. Tests that want to exercise the gate explicitly
re-patch ``_detect_concurrent_hermes_instances`` with their own
return value — autouse here gives a clean default without touching
the rest of the suite.
Tests that need to call the REAL function (e.g. unit tests for the
helper itself) opt out with ``@pytest.mark.real_concurrent_gate``.
"""
if request.node.get_closest_marker("real_concurrent_gate"):
return
try:
from hermes_cli import main as _cli_main
except Exception:
return
# raising=False: under pytest's per-test spawn isolation, a concurrent
# xdist worker importing a module that transitively touches hermes_cli.main
# can briefly expose a partially-initialized module object here — one where
# _detect_concurrent_hermes_instances isn't defined yet. A bare setattr
# would raise AttributeError and error the (unrelated) test. The attribute
# always exists once main.py finishes importing, so a no-op when it's
# transiently absent is the correct, race-free default.
monkeypatch.setattr(
_cli_main,
"_detect_concurrent_hermes_instances",
lambda *_a, **_k: [],
raising=False,
)
@pytest.fixture(autouse=True)
def _source_channels_resolve_locally(request, monkeypatch):
"""Every unflagged ``hermes update`` resolves its channel through R2; tests must
not reach the network for that. Default every channel to a ``source-branch``
record delivering ``origin/<name>`` through the documented seam. Channel tests
that model records themselves re-patch ``_resolve_channel`` after this runs;
the marker opts out entirely for tests of the reader's own network path.
"""
if request.node.get_closest_marker("real_release_channels"):
return
from hermes_cli import source_releases
from hermes_cli.release_channels import ChannelResolution
def resolve(name, repository):
record = {"schema": 1, "name": name, "repository": repository, "policy": "source-branch",
"state": "active", "identity": None, "nextSequence": 1, "head": None,
"delivery": {"kind": "source-branch", "branch": name}}
return ChannelResolution(record, record, None)
monkeypatch.setattr(source_releases, "_resolve_channel", resolve)
@pytest.fixture(autouse=True)
def _discharge_host_update_obligation():
"""Start and end every ``hermes_cli`` test with NO host update-restart obligation.
The record is host-scoped on purpose (one multiplexer per host), so it lives in the
per-OS-USER host state dir — not in the per-test ``HERMES_HOME``. The root conftest pins
that dir per test only when the caller supplied no ``HERMES_GATEWAY_LOCK_DIR`` (#118097
keeps the documented override working), so with one set every test in a file shares it and
a test that arms the obligation makes the next one read a restart it never owed. Clearing
the record — rather than re-pinning the dir — leaves that override rule untouched.
"""
def _clear() -> None:
try:
from hermes_cli.update_host_obligation import clear_host_obligation
clear_host_obligation()
except Exception:
# Import/env failure here must never error an unrelated test.
pass
_clear()
yield
_clear()
@pytest.fixture
def isolated_source_completion(monkeypatch):
"""Unit-test the completion tail in-process; real transport is tested separately."""
from hermes_cli import update_cmd, update_completion
monkeypatch.setattr("hermes_cli.source_build.build_update_products", lambda *a, **kw: None)
monkeypatch.setattr("hermes_cli.venv_sync.publish_launchers", lambda *a: None)
def complete(request):
update_completion._complete_selected(request)
return {"exit_code": 0, "receipt": update_completion._read_terminal_receipt(request),
"windows_resume": request["windows_resume"]}
monkeypatch.setattr(update_cmd, "run_completion", complete)
@pytest.fixture(autouse=True)
def _reset_prompt_toolkit_output_cache():
"""Clear prompt_toolkit's cached AppSession output around each CLI test.
See the module docstring for the capsys/prompt_toolkit interaction this
guards against.
"""
def _clear() -> None:
try:
from prompt_toolkit.application.current import get_app_session
get_app_session()._output = None
except Exception:
# prompt_toolkit not importable / internal shape changed — the
# tests that rely on this simply keep their prior behavior.
pass
_clear()
yield
_clear()
@pytest.fixture
def probe_root(tmp_path):
"""A fixture checkout the installation launcher can boot from.
``runtime_command`` prepends the checkout root and runs ``import hermes_bootstrap``
before the probe body, exactly as production does. Tests that point the import
guard at a scratch tree need that module present, or the probe dies before its
health marker — a developer venv whose editable ``.pth`` shadows the root hides
the dependency, CI's clean environment does not.
"""
(tmp_path / "hermes_bootstrap.py").write_text("", encoding="utf-8")
return tmp_path