Files
hermes-agent/tests/gateway/test_image_input_routing_runtime.py
kshitijk4poor ab2f4602de refactor: MessageEvent to gateway/platforms/event.py; ElicitationHandler takes a call_context thunk
Breaks the two import cycles that forced Protocol stand-ins in the F821 sweep, so the two
sites now name the real types.

gateway/platforms/event.py (new leaf): MessageType, ProcessingOutcome, MessageEvent moved
out of base.py verbatim. Their only dependency is gateway.session.SessionSource; base.py
imported helpers.py at module level, so helpers could not name MessageEvent. Now
TextBatchAggregator is typed by the real MessageEvent. 249 importers repointed
(`from gateway.platforms.base import` -> `.event`, preserving each import's layout);
gateway.platforms.__init__ re-exports from .event. The three revert-scheduled PLUGIN-COMPAT
pointers that named these symbols (gateway.slash_commands → MessageType, dingtalk → MessageType,
photon → ProcessingOutcome) and their COMPAT_MANIFEST rows now target gateway.platforms.event.
Docs updated: ADDING_A_PLATFORM.md, adding-platform-adapters.md (en + zh-Hans).

tools/mcp_tool_sampling.py: ElicitationHandler no longer holds a back-reference to its
MCPServerTask (mcp_tool imports sampling, so the task type cannot be named there). It only
ever read owner._pending_call_context, so it takes `call_context: Callable[[], Context | None]`
and MCPServerTask passes `lambda: self._pending_call_context`. The consent call is one
`functools.partial`, run directly or inside the captured Context.

ty on the 11 touched production files vs origin/main: 0 new diagnostics, 14 resolved.
(The one `source: SessionSource = None` diagnostic moves with the class; typing it Optional
exposes ~60 unguarded call sites — separate follow-up.)

Tests: tests/gateway + tests/plugins + tests/tools + touched files, 18,235 passed; the 31
failures reproduce identically on origin/main (macOS /private/tmp, systemd socket,
long-path fixtures, live-service tests).
2026-09-07 22:47:33 +05:30

170 lines
4.8 KiB
Python

import pytest
from gateway.config import GatewayConfig, Platform, PlatformConfig
from gateway.platforms.event import MessageEvent, MessageType
from gateway.run import GatewayRunner
from gateway.session import SessionSource
def _make_runner() -> GatewayRunner:
runner = object.__new__(GatewayRunner)
runner.config = GatewayConfig(
platforms={Platform.TELEGRAM: PlatformConfig(enabled=True, token="fake")}
)
runner.adapters = {}
runner._pending_native_image_paths_by_session = {}
runner._session_model_overrides = {}
runner._session_reasoning_overrides = {}
return runner
def _source() -> SessionSource:
return SessionSource(
platform=Platform.TELEGRAM,
chat_id="273403055",
chat_type="dm",
user_id="42",
user_name="Maxim",
)
def _image_event(text: str = "look") -> MessageEvent:
return MessageEvent(
text=text,
message_type=MessageType.PHOTO,
source=_source(),
media_urls=["/tmp/cashback.png"],
media_types=["image/png"],
)
def _auto_config() -> dict:
return {
"agent": {"image_input_mode": "auto"},
"auxiliary": {"vision": {"provider": "auto", "model": "", "base_url": ""}},
"model": {"provider": "xiaomi", "default": "mimo-v2.5-pro"},
}
def test_pre_turn_named_custom_provider_identity_selects_vision_override(monkeypatch):
"""Gateway preprocessing must use the name retained by runtime resolution."""
runner = _make_runner()
cfg = {
"agent": {"image_input_mode": "auto"},
"model": {"provider": "default-proxy", "default": "shared-model"},
"custom_providers": [
{
"name": "default-proxy",
"models": {"shared-model": {"supports_vision": False}},
},
{
"name": "vision-provider",
"models": {"shared-model": {"supports_vision": True}},
},
],
}
monkeypatch.setattr(
runner,
"_resolve_session_agent_runtime",
lambda **_: (
"shared-model",
{
"provider": "custom",
"requested_provider": "vision-provider",
},
),
)
assert runner._decide_image_input_mode(
source=_source(),
user_config=cfg,
) == "native"
@pytest.mark.asyncio
async def test_prepare_route_identity_check_keeps_event_loop_responsive(monkeypatch):
"""A slow route-identity check must not block gateway heartbeats."""
import asyncio
import threading
from types import SimpleNamespace
runner = _make_runner()
source = _source()
event = MessageEvent(
text="inspect @AGENTS.md",
message_type=MessageType.TEXT,
source=source,
)
started = threading.Event()
released_by_event_loop = threading.Event()
seen = {}
main_thread = threading.current_thread()
cfg = {
"model": {
"default": "test-model",
"provider": "test-provider",
"base_url": "https://example.invalid/v1",
"context_length": 128000,
}
}
monkeypatch.setattr("gateway.run._load_gateway_config", lambda: cfg)
monkeypatch.setattr(
runner,
"_resolve_session_agent_runtime",
lambda **_kwargs: (
"test-model",
{
"provider": "test-provider",
"base_url": "https://example.invalid/v1",
"api_key": "",
},
),
)
def blocking_route_identity_check(*_args):
seen["thread"] = threading.current_thread()
started.set()
seen["event_loop_progressed"] = released_by_event_loop.wait(timeout=2)
return False
monkeypatch.setattr(
"hermes_cli.route_identity.should_clear_context_pin",
blocking_route_identity_check,
)
async def fake_context_length(*_args, **_kwargs):
return 128000
async def fake_preprocess(message, **_kwargs):
return SimpleNamespace(
blocked=False,
expanded=False,
message=message,
warnings=[],
)
monkeypatch.setattr(
"agent.model_metadata.get_model_context_length_async", fake_context_length
)
monkeypatch.setattr(
"agent.context_references.preprocess_context_references_async",
fake_preprocess,
)
async def heartbeat_ticker():
while not started.is_set():
await asyncio.sleep(0)
await asyncio.sleep(0)
released_by_event_loop.set()
heartbeat = asyncio.create_task(heartbeat_ticker())
result = await runner._prepare_inbound_message_text(
event=event, source=source, history=[]
)
await heartbeat
assert result == "inspect @AGENTS.md"
assert seen["event_loop_progressed"] is True
assert seen["thread"] is not main_thread