a5bd246865
* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule The PLUGIN-COMPAT layer (2776813df3+d63e380324+0a5164cebe) kept pre-#102117 import paths alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader has already been skipping plugins that use the old paths. This removes the layer itself: - 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party names, restored dead definitions) and the three re-export stub modules (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils) - COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step - the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section, the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the `plugins.allow_deprecated_imports` escape hatch An external plugin that still imports an old path now fails to load with its ImportError as the reason in `hermes plugins list`, the same path as any broken plugin. hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect, summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout swap (tests/compat/old_updater_surface.json). In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its `shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed `run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the seam production reads, like every sibling test in that file. * chore: retrigger CI (zero-job startup_failure phantom) * test: drop resolution allowlist rows for the two deleted which() sites hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available (a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires their allowlist entries go with them.
32 lines
1.3 KiB
Python
32 lines
1.3 KiB
Python
"""Helpers for Telegram Bot API chat identifiers: a ``chat_id`` is a numeric ID (int) or an ``@username``
|
|
string for public channels/groups; a bare ``int(chat_id)`` crashes on the username form."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import re
|
|
from typing import Any, Union
|
|
|
|
# Usernames are 5-32 chars (letters, digits, underscores) with a leading "@"; 4-char legacy handles are tolerated.
|
|
_TELEGRAM_USERNAME_RE = re.compile(r"@[A-Za-z0-9_]{4,32}")
|
|
|
|
|
|
def normalize_telegram_chat_id(chat_id: Any) -> Union[int, str]:
|
|
"""Bot API-compatible chat_id: numeric values (incl. negative channel IDs) as ``int``, anything
|
|
else (e.g. ``@username``) as a stripped string; never raises."""
|
|
chat_id_str = str(chat_id).strip()
|
|
try:
|
|
return int(chat_id_str)
|
|
except (TypeError, ValueError):
|
|
return chat_id_str
|
|
|
|
|
|
def looks_like_telegram_username(chat_id: Any) -> bool:
|
|
"""True when the value is an ``@username``-format Telegram chat identifier."""
|
|
return bool(_TELEGRAM_USERNAME_RE.fullmatch(str(chat_id).strip()))
|
|
|
|
|
|
def parse_telegram_username_target(target_ref: Any) -> Union[str, None]:
|
|
"""Return the value when it is an ``@username`` target, else ``None``."""
|
|
value = str(target_ref).strip()
|
|
return value if looks_like_telegram_username(value) else None
|