* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule The PLUGIN-COMPAT layer (2776813df3+d63e380324+0a5164cebe) kept pre-#102117 import paths alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader has already been skipping plugins that use the old paths. This removes the layer itself: - 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party names, restored dead definitions) and the three re-export stub modules (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils) - COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step - the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section, the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the `plugins.allow_deprecated_imports` escape hatch An external plugin that still imports an old path now fails to load with its ImportError as the reason in `hermes plugins list`, the same path as any broken plugin. hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect, summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout swap (tests/compat/old_updater_surface.json). In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its `shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed `run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the seam production reads, like every sibling test in that file. * chore: retrigger CI (zero-job startup_failure phantom) * test: drop resolution allowlist rows for the two deleted which() sites hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available (a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires their allowlist entries go with them.
70 lines
2.8 KiB
Python
70 lines
2.8 KiB
Python
"""Firecrawl cloud browser (``/v2/browser`` only; the web plugin under ``plugins/web/firecrawl/``
|
|
shares ``FIRECRAWL_API_KEY``). Config ``browser.cloud_provider: "firecrawl"`` (explicit only — not
|
|
in the legacy auto-detect walk). Env: ``FIRECRAWL_API_KEY``, ``FIRECRAWL_API_URL`` (default
|
|
https://api.firecrawl.dev), ``FIRECRAWL_BROWSER_TTL`` (default 300 s)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import logging
|
|
import os
|
|
from typing import Any, Dict, Optional
|
|
|
|
from agent.secret_scope import get_secret
|
|
from plugins.browser._common import CloudBrowserProvider
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
_BASE_URL = "https://api.firecrawl.dev"
|
|
|
|
|
|
class FirecrawlBrowserProvider(CloudBrowserProvider):
|
|
"""Firecrawl (https://firecrawl.dev) cloud browser backend."""
|
|
|
|
provider_id = "firecrawl"
|
|
label = "Firecrawl"
|
|
release_method = "delete"
|
|
release_path = "/v2/browser/{session_id}"
|
|
create_label_suffix = " browser"
|
|
setup_tag = "Cloud browser with remote execution"
|
|
setup_env_vars = [
|
|
{"key": "FIRECRAWL_API_KEY", "prompt": "Firecrawl API key", "url": "https://firecrawl.dev"},
|
|
]
|
|
|
|
def _api_url(self) -> str:
|
|
# Per-profile like the key: the scoped key must not be sent to the default profile's endpoint.
|
|
return get_secret("FIRECRAWL_API_URL", "") or _BASE_URL
|
|
|
|
def _get_config_or_none(self) -> Optional[Dict[str, Any]]:
|
|
return {"base_url": self._api_url()} if get_secret("FIRECRAWL_API_KEY") else None
|
|
|
|
def _get_config(self) -> Dict[str, Any]:
|
|
# Never raises: a missing key surfaces from _headers() inside the request try-block, so
|
|
# close_session logs it as an exception (legacy behaviour).
|
|
return {"base_url": self._api_url()}
|
|
|
|
def _headers(self, config: Optional[Dict[str, Any]] = None) -> Dict[str, str]:
|
|
api_key = get_secret("FIRECRAWL_API_KEY")
|
|
if not api_key:
|
|
raise ValueError(
|
|
"FIRECRAWL_API_KEY environment variable is required. "
|
|
"Get your key at https://firecrawl.dev")
|
|
return {"Content-Type": "application/json", "Authorization": f"Bearer {api_key}"}
|
|
|
|
def create_session(self, task_id: str) -> Dict[str, object]:
|
|
try:
|
|
ttl = int(os.environ.get("FIRECRAWL_BROWSER_TTL", "300"))
|
|
except (ValueError, TypeError):
|
|
ttl = 300
|
|
|
|
response = self._post_create(f"{self._api_url()}/v2/browser", self._headers(), {"ttl": ttl})
|
|
self._check_created(response)
|
|
data = response.json()
|
|
session_name = self._session_name(task_id)
|
|
logger.info("Created Firecrawl browser session %s", session_name)
|
|
return {
|
|
"session_name": session_name,
|
|
"bb_session_id": data["id"],
|
|
"cdp_url": data["cdpUrl"],
|
|
"features": {"firecrawl": True},
|
|
}
|