* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule The PLUGIN-COMPAT layer (2776813df3+d63e380324+0a5164cebe) kept pre-#102117 import paths alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader has already been skipping plugins that use the old paths. This removes the layer itself: - 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party names, restored dead definitions) and the three re-export stub modules (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils) - COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step - the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section, the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the `plugins.allow_deprecated_imports` escape hatch An external plugin that still imports an old path now fails to load with its ImportError as the reason in `hermes plugins list`, the same path as any broken plugin. hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect, summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout swap (tests/compat/old_updater_surface.json). In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its `shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed `run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the seam production reads, like every sibling test in that file. * chore: retrigger CI (zero-job startup_failure phantom) * test: drop resolution allowlist rows for the two deleted which() sites hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available (a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires their allowlist entries go with them.
80 lines
3.4 KiB
Python
80 lines
3.4 KiB
Python
"""Capability answers for models served by the managed runtime.
|
|
|
|
Capability lookups (vision, and whatever comes next) consult cloud-shaped catalogs that have never
|
|
heard of a local GGUF, so a vision-capable local model reads as text-only and images detour to an
|
|
auxiliary cloud model — the wrong behavior twice over for a local-first user (broken feature, and a
|
|
screenshot silently leaving the machine).
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from contextlib import suppress
|
|
import logging
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
from hermes_cli.local_runtime.endpoint import LLAMACPP_ALIASES as _LLAMACPP_ALIASES
|
|
|
|
# Image formats the managed server's decoder actually handles. llama.cpp decodes with stb_image:
|
|
# PNG/JPEG/GIF/BMP yes, WebP NO — and a WebP part fails SILENTLY (no HTTP error, no log line; the
|
|
# model just never sees an image and confabulates). Anything outside this set must be transcoded
|
|
# before the request. Measured live: the same red square answered 'Red' as PNG, 'Unseen' as WebP.
|
|
ACCEPTED_IMAGE_MIMES = frozenset({"image/png", "image/jpeg"})
|
|
|
|
|
|
def is_managed_provider(provider: str, base_url: str = "") -> bool:
|
|
"""True when this provider/base_url pair points at the managed server. ``custom`` only counts
|
|
when the base_url IS the managed endpoint — never claim someone else's custom server."""
|
|
p = (provider or "").strip().lower()
|
|
if p in _LLAMACPP_ALIASES:
|
|
return True
|
|
if p != "custom" or not base_url:
|
|
return False
|
|
with suppress(Exception):
|
|
from hermes_cli.local_runtime.growth import is_managed_endpoint
|
|
|
|
return is_managed_endpoint(base_url)
|
|
return False
|
|
|
|
|
|
def _props_modalities(model_id: str) -> "bool | None":
|
|
"""Ask the running server whether this loaded child sees images. None when the server is down,
|
|
the model isn't loaded, or the build doesn't report modalities."""
|
|
with suppress(Exception):
|
|
from hermes_cli.local_runtime.endpoint import managed_get_json, managed_root
|
|
|
|
ep = managed_root()
|
|
if ep is None:
|
|
return None
|
|
modalities = managed_get_json(*ep, f"/props?model={model_id}", timeout_s=3).get("modalities")
|
|
if isinstance(modalities, dict) and "vision" in modalities:
|
|
return bool(modalities["vision"])
|
|
return None
|
|
|
|
|
|
def managed_model_supports_vision(model_id: str) -> "bool | None":
|
|
"""Ground-truth vision capability for a staged model, or None when the model isn't ours /
|
|
nothing is known (caller keeps falling through)."""
|
|
if not model_id:
|
|
return None
|
|
|
|
with suppress(Exception):
|
|
from hermes_cli.local_runtime.bootstrap import assets_dir, staged_model_ids
|
|
from hermes_cli.local_runtime.catalog import entry_for_model
|
|
|
|
# Only answer for models actually staged with us.
|
|
if model_id not in staged_model_ids():
|
|
return None
|
|
live = _props_modalities(model_id)
|
|
if live is not None:
|
|
return live
|
|
# Staged but not loaded (or an older server build): the catalog knows whether this model
|
|
# ships a vision projector. Capability requires the projector to actually be on disk — a
|
|
# model downloaded before its mmproj (partial delete, old layout) genuinely cannot see.
|
|
entry = entry_for_model(model_id)
|
|
if entry is None:
|
|
return None
|
|
return (entry.mmproj is not None
|
|
and (assets_dir() / entry.mmproj.local_name).exists())
|
|
return None
|