3a21c2a75a
The bundle-skew probe was runGit's only caller. With the probe on execGit (timeout, process-tree reap, GIT_NO_LAZY_FETCH), runGit is dead: an untimed, untracked spawn nothing should reach for again. Its spawn-failure path goes with it. describeGitSpawnFailure and the GIT_UNUSABLE marker had exactly one producer, runGit, and the only runGit caller swallowed every error, so the hermes:updates:check handler's git-unusable branch could not fire; nothing in the renderer reads it.
35 lines
1.5 KiB
TypeScript
35 lines
1.5 KiB
TypeScript
export interface RunnableBinaryOptions {
|
|
/** Ordered candidate absolute paths, highest preference first. */
|
|
candidates: string[]
|
|
fileExists: (filePath: string) => boolean
|
|
/** Probe: does this candidate actually execute (`<binary> --version`)? */
|
|
binaryRuns: (filePath: string) => boolean
|
|
}
|
|
|
|
/**
|
|
* Pick the first candidate that both exists on disk and runs, falling back to
|
|
* the first that merely exists, then to null.
|
|
*
|
|
* A file can exist and still be unlaunchable: on macOS an Intel-only binary
|
|
* ahead on PATH (Homebrew under Rosetta gone after an OS update) fails at
|
|
* spawn time with errno -86 (EBADARCH, "Bad CPU type in executable"), which
|
|
* callers then misreport as a network/update-server problem because the
|
|
* failure only surfaces when the child is spawned. Existence-only selection
|
|
* (`candidates.find(fileExists)`, first PATH hit) commits to the broken
|
|
* candidate by construction and never looks at the working one right after it.
|
|
*
|
|
* The existence-only fallback keeps behaviour unchanged where the probe itself
|
|
* cannot run (locked-down execution policy, AV interposing on spawn) rather
|
|
* than skipping a binary that would have worked.
|
|
*
|
|
* Resolution order (first match wins):
|
|
* 1. a candidate that exists and runs
|
|
* 2. a candidate that merely exists
|
|
* 3. null — caller falls back to its own PATH/bare-name resolution
|
|
*/
|
|
export function selectRunnableBinary(opts: RunnableBinaryOptions): string | null {
|
|
const existing = opts.candidates.filter(opts.fileExists)
|
|
|
|
return existing.find(opts.binaryRuns) || existing[0] || null
|
|
}
|