"""``plugins remove`` (CLI, dashboard, ``plugins.manage`` RPC) leaves no config residue and never
follows a symlink (#54336, plugin-scan L2-F1/F2/F5).

Real removal core against a temp HERMES_HOME; the RPC path goes through ``tui_gateway.server``.
"""

from __future__ import annotations

import pytest
import hermes_yaml as yaml

from hermes_cli import plugins_cmd
from tui_gateway import server


def _write_plugin(root, rel, name, extra=""):
    d = root / rel
    d.mkdir(parents=True)
    (d / "plugin.yaml").write_text(f"name: {name}\nversion: '1.0'\n{extra}", encoding="utf-8")
    (d / "__init__.py").write_text("def register(ctx):\n    pass\n", encoding="utf-8")
    return d


@pytest.fixture
def home(tmp_path, monkeypatch):
    hermes_home = tmp_path / "hermes-home"
    (hermes_home / "plugins").mkdir(parents=True)
    monkeypatch.setenv("HERMES_HOME", str(hermes_home))
    return hermes_home


def _config(home):
    return yaml.safe_load((home / "config.yaml").read_text(encoding="utf-8")) or {}


def test_remove_forgets_every_config_trace_and_resets_the_memory_provider(home):
    """After an uninstall, plugins.enabled/disabled/entries no longer name the plugin (a reinstall
    must start from the "Enable now?" decision) and a ``memory.provider`` pointing at it is reset —
    otherwise the next agent init re-clones the provider from the catalog, undoing the uninstall."""
    _write_plugin(home / "plugins", "fakemem", "fakemem", "kind: exclusive\n")
    (home / "config.yaml").write_text(yaml.safe_dump({
        "plugins": {"enabled": ["fakemem", "keep-me"], "disabled": ["other"],
                    "entries": {"fakemem": {"allow_tool_override": True}, "keep-me": {}}},
        "memory": {"provider": "fakemem"},
    }), encoding="utf-8")

    resp = server.handle_request({"id": "1", "method": "plugins.manage",
                                  "params": {"action": "remove", "name": "fakemem"}})

    assert resp["result"] == {"ok": True, "name": "fakemem", "cleared_memory_provider": True}
    assert not (home / "plugins" / "fakemem").exists()
    cfg = _config(home)
    assert cfg["plugins"]["enabled"] == ["keep-me"] and cfg["plugins"]["disabled"] == ["other"]
    assert cfg["plugins"]["entries"] == {"keep-me": {}}
    assert not cfg["memory"]["provider"]


def test_remove_of_a_symlink_inside_the_plugins_dir_unlinks_only_the_link(home):
    """A dev alias pointing at a sibling install resolves INSIDE the plugins dir, so the containment
    check passes; removing the alias must not delete the sibling (or its install metadata)."""
    victim = _write_plugin(home / "plugins", "victim", "victim")
    (home / "plugins" / "alias").symlink_to(victim, target_is_directory=True)
    (home / "plugins" / ".install-metadata.json").write_text('{"victim": {"pinned_sha": "%s"}}' % ("a" * 40),
                                                             encoding="utf-8")
    (home / "config.yaml").write_text("plugins:\n  enabled: [victim]\n", encoding="utf-8")

    result = plugins_cmd.dashboard_remove_user_plugin("alias")

    assert result == {"ok": True, "name": "alias"}
    assert not (home / "plugins" / "alias").is_symlink()
    assert (victim / "plugin.yaml").exists()
    assert "victim" in (home / "plugins" / ".install-metadata.json").read_text(encoding="utf-8")
    assert _config(home)["plugins"]["enabled"] == ["victim"]